Mercurial > vim
view runtime/syntax/gnash.vim @ 34536:ad6cd802579d v9.1.0170
patch 9.1.0170: Re-allow curwin == prevwin, but document it instead
Commit: https://github.com/vim/vim/commit/d64801e913314d2e19dbb38f60e6d285238debff
Author: Sean Dewar <6256228+seandewar@users.noreply.github.com>
Date: Tue Mar 12 20:46:12 2024 +0100
patch 9.1.0170: Re-allow curwin == prevwin, but document it instead
Problem: more places exist where curwin == prevwin, and it may even be
expected in some cases.
Solution: revert v9.1.0001, but document that it's possible instead.
(Sean Dewar)
I've had a change of heart for the following reasons:
- A quick 'n dirty [GitHub code
search](https://github.com/search?q=%2F%28winnr%5C%28%5C%29%5Cs*%3D%3D%5Cs*winnr%5C%28%5B%27%22%5D%23%5B%27%22%5D%5C%29%7Cwinnr%5C%28%5B%27%22%5D%23%5B%27%22%5D%5C%29%5Cs*%3D%3D%5Cs*winnr%5C%28%5C%29%29%2F&type=code)
reveals some cases where it's expected in the wild.
Particularly, it made me aware `winnr() == winnr('#')` is possible when curwin
is changed temporarily during the evaluation of a &statusline expression item
(`%{...}`), and is used to show something different on the statusline
belonging to the previous window; that behaviour wasn't changed in v9.1.0001,
but it means curwin == prevwin makes sense in some cases.
- The definition and call sites of back_to_prevwin imply some expectation that
prevwin == wp (== curwin) is possible, as it's used to skip entering the
prevwin in that case.
- Prior to v9.1.0001, `:wincmd p` would not beep in the case that was patched in
v9.1.0001, but now does. That resulted in #14047 being opened, as it affected
the CtrlP plugin.
I find it odd that `:wincmd p` had cases where it wouldn't beep despite doing
nothing, but it may be preferable to keep things that way (or instead also
beep if curwin == prevwin, if that's preferred).
- After more digging, I found cases in win_free_mem, enter_tabpage,
aucmd_restbuf and qf_open_new_cwindow where curwin == prevwin is possible
(many of them from autocommands). Others probably exist too, especially in
places where curwin is changed temporarily.
fixes: #14047
closes: #14186
Signed-off-by: Sean Dewar <6256228+seandewar@users.noreply.github.com>
Signed-off-by: Christian Brabandt <cb@256bit.org>
| author | Christian Brabandt <cb@256bit.org> |
|---|---|
| date | Tue, 12 Mar 2024 21:00:11 +0100 |
| parents | 43efa4f5a8ea |
| children |
line wrap: on
line source
" Vim syntax file " Maintainer: Thilo Six " Contact: <vim-dev at vim dot org> " http://www.vim.org/maillist.php#vim-dev " " Description: highlight gnash configuration files " http://www.gnu.org/software/gnash/manual/gnashuser.html#gnashrc " File: runtime/syntax/gnash.vim " Last Change: 2012 May 19 " Modeline: vim: ts=8:sw=2:sts=2: " " Credits: derived from Nikolai Weibulls readline.vim " " License: VIM License " Vim is Charityware, see ":help Uganda" " " quit when a syntax file was already loaded if exists("b:current_syntax") || &compatible finish endif syn case match syn keyword GnashTodo contained TODO FIXME XXX NOTE " Comments syn match GnashComment "^#.*$" contains=@Spell,GnashTodo syn match GnashComment "\s#.*$" contains=@Spell,GnashTodo syn match GnashNumber display '\<\d\+\>' syn case ignore syn keyword GnashOn ON YES TRUE syn keyword GnashOff OFF NO FALSE syn match GnashSet '^\s*set\>' syn match GnashSet '^\s*append\>' syn match GnashKeyword '\<CertDir\>' syn match GnashKeyword '\<ASCodingErrorsVerbosity\>' syn match GnashKeyword '\<CertFile\>' syn match GnashKeyword '\<EnableExtensions\>' syn match GnashKeyword '\<HWAccel\>' syn match GnashKeyword '\<LCShmKey\>' syn match GnashKeyword '\<LocalConnection\>' syn match GnashKeyword '\<MalformedSWFVerbosity\>' syn match GnashKeyword '\<Renderer\>' syn match GnashKeyword '\<RootCert\>' syn match GnashKeyword '\<SOLReadOnly\>' syn match GnashKeyword '\<SOLSafeDir\>' syn match GnashKeyword '\<SOLreadonly\>' syn match GnashKeyword '\<SOLsafedir\>' syn match GnashKeyword '\<StartStopped\>' syn match GnashKeyword '\<StreamsTimeout\>' syn match GnashKeyword '\<URLOpenerFormat\>' syn match GnashKeyword '\<XVideo\>' syn match GnashKeyword '\<actionDump\>' syn match GnashKeyword '\<blacklist\>' syn match GnashKeyword '\<debugger\>' syn match GnashKeyword '\<debuglog\>' syn match GnashKeyword '\<delay\>' syn match GnashKeyword '\<enableExtensions\>' syn match GnashKeyword '\<flashSystemManufacturer\>' syn match GnashKeyword '\<flashSystemOS\>' syn match GnashKeyword '\<flashVersionString\>' syn match GnashKeyword '\<ignoreFSCommand\>' syn match GnashKeyword '\<ignoreShowMenu\>' syn match GnashKeyword '\<insecureSSL\>' syn match GnashKeyword '\<localSandboxPath\>' syn match GnashKeyword '\<localdomain\>' syn match GnashKeyword '\<localhost\>' syn match GnashKeyword '\<microphoneDevice\>' syn match GnashKeyword '\<parserDump\>' syn match GnashKeyword '\<pluginsound\>' syn match GnashKeyword '\<quality\>' syn match GnashKeyword '\<solLocalDomain\>' syn match GnashKeyword '\<sound\>' syn match GnashKeyword '\<splashScreen\>' syn match GnashKeyword '\<startStopped\>' syn match GnashKeyword '\<streamsTimeout\>' syn match GnashKeyword '\<urlOpenerFormat\>' syn match GnashKeyword '\<verbosity\>' syn match GnashKeyword '\<webcamDevice\>' syn match GnashKeyword '\<whitelist\>' syn match GnashKeyword '\<writelog\>' hi def link GnashOn Identifier hi def link GnashOff Preproc hi def link GnashComment Comment hi def link GnashTodo Todo hi def link GnashNumber Type hi def link GnashSet String hi def link GnashKeyword Keyword let b:current_syntax = "gnash"