view runtime/spell/yi/main.aap @ 34536:ad6cd802579d v9.1.0170

patch 9.1.0170: Re-allow curwin == prevwin, but document it instead Commit: https://github.com/vim/vim/commit/d64801e913314d2e19dbb38f60e6d285238debff Author: Sean Dewar <6256228+seandewar@users.noreply.github.com> Date: Tue Mar 12 20:46:12 2024 +0100 patch 9.1.0170: Re-allow curwin == prevwin, but document it instead Problem: more places exist where curwin == prevwin, and it may even be expected in some cases. Solution: revert v9.1.0001, but document that it's possible instead. (Sean Dewar) I've had a change of heart for the following reasons: - A quick 'n dirty [GitHub code search](https://github.com/search?q=%2F%28winnr%5C%28%5C%29%5Cs*%3D%3D%5Cs*winnr%5C%28%5B%27%22%5D%23%5B%27%22%5D%5C%29%7Cwinnr%5C%28%5B%27%22%5D%23%5B%27%22%5D%5C%29%5Cs*%3D%3D%5Cs*winnr%5C%28%5C%29%29%2F&type=code) reveals some cases where it's expected in the wild. Particularly, it made me aware `winnr() == winnr('#')` is possible when curwin is changed temporarily during the evaluation of a &statusline expression item (`%{...}`), and is used to show something different on the statusline belonging to the previous window; that behaviour wasn't changed in v9.1.0001, but it means curwin == prevwin makes sense in some cases. - The definition and call sites of back_to_prevwin imply some expectation that prevwin == wp (== curwin) is possible, as it's used to skip entering the prevwin in that case. - Prior to v9.1.0001, `:wincmd p` would not beep in the case that was patched in v9.1.0001, but now does. That resulted in #14047 being opened, as it affected the CtrlP plugin. I find it odd that `:wincmd p` had cases where it wouldn't beep despite doing nothing, but it may be preferable to keep things that way (or instead also beep if curwin == prevwin, if that's preferred). - After more digging, I found cases in win_free_mem, enter_tabpage, aucmd_restbuf and qf_open_new_cwindow where curwin == prevwin is possible (many of them from autocommands). Others probably exist too, especially in places where curwin is changed temporarily. fixes: #14047 closes: #14186 Signed-off-by: Sean Dewar <6256228+seandewar@users.noreply.github.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
author Christian Brabandt <cb@256bit.org>
date Tue, 12 Mar 2024 21:00:11 +0100
parents 6f8b578776ab
children
line wrap: on
line source

# Aap recipe for Yiddish Vim spell files.

# Use a freshly compiled Vim if it exists.
@if os.path.exists('../../../src/vim'):
    VIM = ../../../src/vim
@else:
    :progsearch VIM vim

SPELLDIR    = ..
FILES       = yi.dic yi.aff
WORDFILE    = wordlist.utf8.txt
FILES_TR    = yi_tr.dic yi_tr.aff
WORDFILE_TR = wordlist.txt

all: $SPELLDIR/yi.utf-8.spl $SPELLDIR/yi-tr.utf-8.spl \
        $SPELLDIR/yi.latin1.spl ../README_yi.txt

$SPELLDIR/yi.utf-8.spl : $FILES
    :sys $VIM -u NONE -e -c "set enc=utf-8"
            -c "mkspell! $SPELLDIR/yi yi" -c q

$SPELLDIR/yi-tr.utf-8.spl : $FILES_TR
    :sys $VIM -u NONE -e -c "set enc=utf-8"
            -c "mkspell! $SPELLDIR/yi-tr yi_tr" -c q

$SPELLDIR/yi.latin1.spl : $FILES_TR
    :sys $VIM -u NONE -e -c "set enc=latin1"
            -c "mkspell! $SPELLDIR/yi yi_tr" -c q

../README_yi.txt : README.txt
    :copy $source $target

#
# Fetch the word list when needed.
#
URLDIR = http://www.cs.uky.edu/~raphael/yiddish
:attr {fetch = $URLDIR/%file%} $WORDFILE $WORDFILE_TR

# We use the word list as a .dic file, so that we can use an affix file to
# define a few extra things.
$FILES: {buildcheck=}
        :assertpkg patch
        :fetch $WORDFILE
        :copy $WORDFILE yi.dic
        :touch {force} yi.aff
        @if os.path.exists('yi.diff'):
            :sys patch < yi.diff

$FILES_TR: {buildcheck=}
        :assertpkg patch
        :fetch $WORDFILE_TR
        :copy $WORDFILE_TR yi_tr.dic
        :touch {force} yi_tr.aff
        @if os.path.exists('yi_tr.diff'):
            :sys patch < yi_tr.diff

diff {virtual}:
    :assertpkg diff
    # Using a context of two lines to work around a bug in FreeBSD patch.
    :sys {force} diff -a -C 2 $WORDFILE yi.dic > yi.diff
    :sys {force} diff -a -N -C 1 /dev/null yi.aff >> yi.diff
    :sys {force} diff -a -C 2 $WORDFILE_TR yi_tr.dic > yi_tr.diff
    :sys {force} diff -a -N -C 1 /dev/null yi_tr.aff >> yi_tr.diff

# vim: set sts=4 sw=4 :