Mercurial > vim
view ci/unlisted.make @ 34451:d06ffca91441 v9.1.0142
patch 9.1.0142: getregion() can be improved
Commit: https://github.com/vim/vim/commit/19b718828d8d5fab52d94c6cdba694641879ab38
Author: Shougo Matsushita <Shougo.Matsu@gmail.com>
Date: Wed Feb 28 22:48:12 2024 +0100
patch 9.1.0142: getregion() can be improved
Problem: getregion() can be improved (after v9.1.120)
Solution: change getregion() implementation to use pos as lists and
one optional {opt} dictionary (Shougo Matsushita)
Note: The following is a breaking change!
Currently, the getregion() function (included as of patch v9.1.120) takes
3 arguments: the first 2 arguments are strings, describing a position,
arg3 is the type string.
However, that is slightly inflexible, there is no way to specify
additional arguments. So let's instead change the function signature to:
getregion(pos1, pos2 [, {Dict}]) where both pos1 and pos2 are lists.
This is slightly cleaner, and gives us the flexibility to specify
additional arguments as key/value pairs to the optional Dict arg.
Now it supports the "type" key to specify the selection type
(characterwise, blockwise or linewise) and now in addition one can also
define the selection type, independently of what the 'selection' option
actually is.
Technically, this is a breaking change, but since the getregion()
Vimscript function is still quite new, this should be fine.
closes: #14090
Co-authored-by: zeertzjq <zeertzjq@outlook.com>
Signed-off-by: Shougo Matsushita <Shougo.Matsu@gmail.com>
Signed-off-by: Christian Brabandt <cb@256bit.org>
author | Christian Brabandt <cb@256bit.org> |
---|---|
date | Wed, 28 Feb 2024 23:00:03 +0100 |
parents | e6c291944e18 |
children |
line wrap: on
line source
# vim: ft=make SHELL = /bin/bash # List all files that are tracked in git but not listed in Filelist. # Exit code is 2 ("Make encountered an error") if any such files exist. # Filelist is a Makefile that defines many variables, so we use Make itself to # query which variables it defines, then expand them all by wrapping each name # in $(...), importing Filelist and using $(eval). include Filelist $(eval all_patterns := $(shell \ make -f Filelist --question --print-data-base --no-builtin-rules \ --no-builtin-variables 2>/dev/null \ | sed -nre \ '/^# makefile .from \x27Filelist\x27,/ { \ n; \ s/ = .*//; \ T; \ s/.*/$$(\0)/; \ p; \ }')) # In Makefile's `prepeare` target, all the IN_README_DIR files are moved from # READMEdir to the root, so add those files in their Git-tracked location: all_patterns := $(all_patterns) \ $(foreach readme, $(IN_README_DIR), READMEdir/$(readme)) # The result 'all_patterns' is a list of patterns (globs), which we expand with # wildcard to get actual filenames. Note this means Filelist can list a file # that does not exist, and it will be omitted at this step. listed_files := $(wildcard $(all_patterns)) # Default target to actually run the comparison: .PHONY: check check: @# There are too many files to list on the command line, so we write @# that to a temporary file, one per line. $(file > Filelist-listed-files) $(foreach filename, $(listed_files),\ $(file >> Filelist-listed-files,$(filename))) @# Compare the sorted lists. Delete that temporary file on both @# success and failure, but exit with diff's exit code. diff -u0 --label files-in-git <(git ls-files | sort) \ --label Filelist <(sort --unique Filelist-listed-files); \ RV=$$?; \ rm Filelist-listed-files; \ (($$RV != 0)) && echo "Add files to the right variable in Filelist."; \ exit $$RV