Mercurial > vim
view runtime/syntax/upstart.vim @ 34416:0a458b49e1e6 v9.1.0131
patch 9.1.0131: buffer-completion may not always find all matches
Commit: https://github.com/vim/vim/commit/0dc0bff000fd804c6b0778ccc4554a4e4c82c8c9
Author: Christian Brabandt <cb@256bit.org>
Date: Sat Feb 24 14:12:13 2024 +0100
patch 9.1.0131: buffer-completion may not always find all matches
Problem: buffer-completion code too complicated and does not always
find all matches (irisjae)
Solution: do not try to anchor pattern to beginning of line or
directory-separator, always return all matches
Note: we are considering the non-fuzzy buffer-matching here.
Currently, the buffer-completion code makes 2 attempts to match a
pattern against the list of available patterns. First try is to match
the pattern and anchor it to either the beginning of the file name or
at a directory-separator (// or \\).
When a match is found, Vim returns the matching buffers and does not try
to find a match anywhere within a buffer name. So if you have opened two
buffers like /tmp/Foobar.c and /tmp/MyFoobar.c using `:b Foo` will only
complete to the first filename, but not the second (the same happens
with `getcompletion('Foo', 'buffer')`).
It may make sense, that completion priorities buffer names at directory
boundaries, but it inconsistent, may cause confusion why a certain
buffer name is not completed when typing `:b Foo<C-D>` which returns
only a single file name and then pressing Enter (to switch to that
buffer), Vim will error with 'E93: More than one match for Foo').
Similar things may happen when wiping the /tmp/Foobar.c pattern and
afterwards the completion starts completing other buffers.
So let's simplify the code and always match the pattern anywhere in the
buffer name, do not try to favor matches at directory boundaries. This
is also simplifies the code a bit, we do not need to run over the list
of buffers several times, but only twice.
fixes #13894
closes: #14082
Signed-off-by: Christian Brabandt <cb@256bit.org>
| author | Christian Brabandt <cb@256bit.org> |
|---|---|
| date | Sat, 24 Feb 2024 14:30:03 +0100 |
| parents | 43efa4f5a8ea |
| children |
line wrap: on
line source
" Vim syntax file " Language: Upstart job files " Maintainer: Michael Biebl <biebl@debian.org> " James Hunt <james.hunt@ubuntu.com> " Last Change: 2012 Jan 16 " License: The Vim license " Version: 0.4 " Remark: Syntax highlighting for Upstart (init(8)) job files. " " It is inspired by the initng syntax file and includes sh.vim to do the " highlighting of script blocks. " quit when a syntax file was already loaded if exists("b:current_syntax") finish endif let is_bash = 1 syn include @Shell syntax/sh.vim syn case match " avoid need to use 'match' for most events setlocal iskeyword+=- syn match upstartComment /#.*$/ contains=upstartTodo syn keyword upstartTodo TODO FIXME contained syn region upstartString start=/"/ end=/"/ skip=/\\"/ syn region upstartScript matchgroup=upstartStatement start="script" end="end script" contains=@upstartShellCluster syn cluster upstartShellCluster contains=@Shell " one argument syn keyword upstartStatement description author version instance expect syn keyword upstartStatement pid kill normal console env exit export syn keyword upstartStatement umask nice oom chroot chdir exec " two arguments syn keyword upstartStatement limit " one or more arguments (events) syn keyword upstartStatement emits syn keyword upstartStatement on start stop " flag, no parameter syn keyword upstartStatement respawn service instance manual debug task " prefix for exec or script syn keyword upstartOption pre-start post-start pre-stop post-stop " option for kill syn keyword upstartOption timeout " option for oom syn keyword upstartOption never " options for console syn keyword upstartOption output owner " options for expect syn keyword upstartOption fork daemon " options for limit syn keyword upstartOption unlimited " 'options' for start/stop on syn keyword upstartOption and or " Upstart itself and associated utilities syn keyword upstartEvent runlevel syn keyword upstartEvent started syn keyword upstartEvent starting syn keyword upstartEvent startup syn keyword upstartEvent stopped syn keyword upstartEvent stopping syn keyword upstartEvent control-alt-delete syn keyword upstartEvent keyboard-request syn keyword upstartEvent power-status-changed " D-Bus syn keyword upstartEvent dbus-activation " Display Manager (ie gdm) syn keyword upstartEvent desktop-session-start syn keyword upstartEvent login-session-start " mountall syn keyword upstartEvent all-swaps syn keyword upstartEvent filesystem syn keyword upstartEvent mounted syn keyword upstartEvent mounting syn keyword upstartEvent local-filesystems syn keyword upstartEvent remote-filesystems syn keyword upstartEvent virtual-filesystems " SysV umountnfs.sh syn keyword upstartEvent mounted-remote-filesystems " upstart-udev-bridge and ifup/down syn match upstartEvent /\<\i\{-1,}-device-\(added\|removed\|up\|down\)/ " upstart-socket-bridge syn keyword upstartEvent socket hi def link upstartComment Comment hi def link upstartTodo Todo hi def link upstartString String hi def link upstartStatement Statement hi def link upstartOption Type hi def link upstartEvent Define let b:current_syntax = "upstart"