Mercurial > vim
view runtime/syntax/loginaccess.vim @ 34416:0a458b49e1e6 v9.1.0131
patch 9.1.0131: buffer-completion may not always find all matches
Commit: https://github.com/vim/vim/commit/0dc0bff000fd804c6b0778ccc4554a4e4c82c8c9
Author: Christian Brabandt <cb@256bit.org>
Date: Sat Feb 24 14:12:13 2024 +0100
patch 9.1.0131: buffer-completion may not always find all matches
Problem: buffer-completion code too complicated and does not always
find all matches (irisjae)
Solution: do not try to anchor pattern to beginning of line or
directory-separator, always return all matches
Note: we are considering the non-fuzzy buffer-matching here.
Currently, the buffer-completion code makes 2 attempts to match a
pattern against the list of available patterns. First try is to match
the pattern and anchor it to either the beginning of the file name or
at a directory-separator (// or \\).
When a match is found, Vim returns the matching buffers and does not try
to find a match anywhere within a buffer name. So if you have opened two
buffers like /tmp/Foobar.c and /tmp/MyFoobar.c using `:b Foo` will only
complete to the first filename, but not the second (the same happens
with `getcompletion('Foo', 'buffer')`).
It may make sense, that completion priorities buffer names at directory
boundaries, but it inconsistent, may cause confusion why a certain
buffer name is not completed when typing `:b Foo<C-D>` which returns
only a single file name and then pressing Enter (to switch to that
buffer), Vim will error with 'E93: More than one match for Foo').
Similar things may happen when wiping the /tmp/Foobar.c pattern and
afterwards the completion starts completing other buffers.
So let's simplify the code and always match the pattern anywhere in the
buffer name, do not try to favor matches at directory boundaries. This
is also simplifies the code a bit, we do not need to run over the list
of buffers several times, but only twice.
fixes #13894
closes: #14082
Signed-off-by: Christian Brabandt <cb@256bit.org>
| author | Christian Brabandt <cb@256bit.org> |
|---|---|
| date | Sat, 24 Feb 2024 14:30:03 +0100 |
| parents | 1218c5353e2b |
| children |
line wrap: on
line source
" Vim syntax file " Language: login.access(5) configuration file " Previous Maintainer: Nikolai Weibull <now@bitwi.se> " Latest Revision: 2006-04-19 if exists("b:current_syntax") finish endif let s:cpo_save = &cpo set cpo&vim syn keyword loginaccessTodo contained TODO FIXME XXX NOTE syn region loginaccessComment display oneline start='^#' end='$' \ contains=loginaccessTodo,@Spell syn match loginaccessBegin display '^' \ nextgroup=loginaccessPermission, \ loginaccessComment skipwhite syn match loginaccessPermission contained display '[^#]' \ contains=loginaccessPermError \ nextgroup=loginaccessUserSep syn match loginaccessPermError contained display '[^+-]' syn match loginaccessUserSep contained display ':' \ nextgroup=loginaccessUsers, \ loginaccessAllUsers, \ loginaccessExceptUsers syn match loginaccessUsers contained display '[^, \t:]\+' \ nextgroup=loginaccessUserIntSep, \ loginaccessOriginSep syn match loginaccessAllUsers contained display '\<ALL\>' \ nextgroup=loginaccessUserIntSep, \ loginaccessOriginSep syn match loginaccessLocalUsers contained display '\<LOCAL\>' \ nextgroup=loginaccessUserIntSep, \ loginaccessOriginSep syn match loginaccessExceptUsers contained display '\<EXCEPT\>' \ nextgroup=loginaccessUserIntSep, \ loginaccessOriginSep syn match loginaccessUserIntSep contained display '[, \t]' \ nextgroup=loginaccessUsers, \ loginaccessAllUsers, \ loginaccessExceptUsers syn match loginaccessOriginSep contained display ':' \ nextgroup=loginaccessOrigins, \ loginaccessAllOrigins, \ loginaccessExceptOrigins syn match loginaccessOrigins contained display '[^, \t]\+' \ nextgroup=loginaccessOriginIntSep syn match loginaccessAllOrigins contained display '\<ALL\>' \ nextgroup=loginaccessOriginIntSep syn match loginaccessLocalOrigins contained display '\<LOCAL\>' \ nextgroup=loginaccessOriginIntSep syn match loginaccessExceptOrigins contained display '\<EXCEPT\>' \ nextgroup=loginaccessOriginIntSep syn match loginaccessOriginIntSep contained display '[, \t]' \ nextgroup=loginaccessOrigins, \ loginaccessAllOrigins, \ loginaccessExceptOrigins hi def link loginaccessTodo Todo hi def link loginaccessComment Comment hi def link loginaccessPermission Type hi def link loginaccessPermError Error hi def link loginaccessUserSep Delimiter hi def link loginaccessUsers Identifier hi def link loginaccessAllUsers Macro hi def link loginaccessLocalUsers Macro hi def link loginaccessExceptUsers Operator hi def link loginaccessUserIntSep loginaccessUserSep hi def link loginaccessOriginSep loginaccessUserSep hi def link loginaccessOrigins Identifier hi def link loginaccessAllOrigins Macro hi def link loginaccessLocalOrigins Macro hi def link loginaccessExceptOrigins loginaccessExceptUsers hi def link loginaccessOriginIntSep loginaccessUserSep let b:current_syntax = "loginaccess" let &cpo = s:cpo_save unlet s:cpo_save