Mercurial > vim
view src/if_ole.h @ 34394:a400c8f9506f v9.1.0123
patch 9.1.0123: MS-Windows: system() may deadlock
Commit: https://github.com/vim/vim/commit/52ecc76c7fa1865603f27bc838efaeaa03cad77c
Author: GuyBrush <miguel.barro@live.com>
Date: Wed Feb 21 20:16:38 2024 +0100
patch 9.1.0123: MS-Windows: system() may deadlock
Problem: MS-Windows: system() may deadlock when calling binaries that
expect stdin
Solution: Ignore the SHELL_EXPAND flag
(GuyBrush)
This happens on binaries that expect stdin. For example:
:echo system("xxd")
will cause a deadlock.
SHELL_EXPAND is a flag devoted to support the linux implementation of
the backtick-expansion mechanism.
On linux backtic-expansion relies in the function mch_expand_wildchars()
(os_unix.c) that delegates on each specific shell (bash, sh, csh, zsh)
the expansion. Basically it composes a shell command that does the
expansion and redirects the output to a file and call_shell() it. On
windows backtick-expansion is performed by Vim itself.
On linux SHELL_EXPAND modifies how mch_call_shell_fork() (os_unix.c)
works. This function:
- relies on posix fork() to spawn a child process to execute a
external command.
- Child and parent process communicate using pipes (or pseudoterminal
if available).
User input (type ahead content) is processed in a loop only if
!(SHELL_EXPAND || SHELL_COOKED).
Though signals are used to detect Ctrl-C in all cases (the input
loop is not necessary to interrupt the function).
In the backtick-expansion the external command is the shell command
that provides the expansion. For the child redirection:
- SHELL_EXPAND replaces stdin, stdout & stderr to /dev/null. This is
why the shell command composed includes redirection (otherwise
output would be lost).
- !SHELL_EXPAND replaces stdin, stdout & stderr with the parent
created pipes (or pseudoterminal).
Note that the use of SIGINT signal prevents mch_call_shell_fork()
from hanging vim.
On Windows mch_system_piped() (os_win32.c) (which is only used when the
GUI is running) mimics mch_call_shell_fork() (os_unix.c).
Win32 lacks fork() and relies on CreateProcessW() and only has pipe
support (not pseudoterminal) which makes the implementation much
different.
But, the key idea is that windows lacks signals, the OS provides support
for console apps but gvim is not one. The only way of detecting a Ctrl-C
is actually processing user input (type ahead content). By ignoring the
user input under SHELL_EXPAND the function can hang gvim.
Ignoring SHELL_EXPAND flag has no consequence in Windows because as
mentioned above it is only meaningful in linux.
closes: #13988
Signed-off-by: GuyBrush <miguel.barro@live.com>
Signed-off-by: Christian Brabandt <cb@256bit.org>
author | Christian Brabandt <cb@256bit.org> |
---|---|
date | Wed, 21 Feb 2024 20:30:02 +0100 |
parents | 6e3dc2d630c2 |
children |
line wrap: on
line source
// this ALWAYS GENERATED file contains the definitions for the interfaces // File created by MIDL compiler version 3.01.75 // at Wed Jun 06 18:20:37 2001 // Compiler settings for .\if_ole.idl: // Os (OptLev=s), W1, Zp8, env=Win32, ms_ext, c_ext // error checks: none //@@MIDL_FILE_HEADING( ) #include "rpc.h" #include "rpcndr.h" #ifndef COM_NO_WINDOWS_H #include "windows.h" #include "ole2.h" #endif //COM_NO_WINDOWS_H #ifndef __if_ole_h__ #define __if_ole_h__ #ifdef __cplusplus extern "C"{ #endif // Forward Declarations #ifndef __IVim_FWD_DEFINED__ #define __IVim_FWD_DEFINED__ typedef interface IVim IVim; #endif // __IVim_FWD_DEFINED__ #ifndef __Vim_FWD_DEFINED__ #define __Vim_FWD_DEFINED__ #ifdef __cplusplus typedef class Vim Vim; #else typedef struct Vim Vim; #endif // __cplusplus #endif // __Vim_FWD_DEFINED__ // header files for imported files #include "oaidl.h" #ifndef __MIDL_user_allocate_free_DEFINED__ #define __MIDL_user_allocate_free_DEFINED__ void __RPC_FAR * __RPC_USER MIDL_user_allocate(size_t); void __RPC_USER MIDL_user_free( void __RPC_FAR * ); #endif #ifndef __IVim_INTERFACE_DEFINED__ #define __IVim_INTERFACE_DEFINED__ //*************************************** // Generated header for interface: IVim // at Wed Jun 06 18:20:37 2001 // using MIDL 3.01.75 //************************************** // [oleautomation][dual][unique][helpstring][uuid][object] EXTERN_C const IID IID_IVim; #if defined(__cplusplus) && !defined(CINTERFACE) interface DECLSPEC_UUID("0F0BFAE2-4C90-11d1-82D7-0004AC368519") IVim : public IDispatch { public: virtual HRESULT STDMETHODCALLTYPE SendKeys( /* [in] */ BSTR keys) = 0; virtual HRESULT STDMETHODCALLTYPE Eval( /* [in] */ BSTR expr, /* [retval][out] */ BSTR __RPC_FAR *result) = 0; virtual HRESULT STDMETHODCALLTYPE SetForeground( void) = 0; virtual HRESULT STDMETHODCALLTYPE GetHwnd( /* [retval][out] */ UINT_PTR __RPC_FAR *result) = 0; }; #else // C style interface typedef struct IVimVtbl { BEGIN_INTERFACE HRESULT ( STDMETHODCALLTYPE __RPC_FAR *QueryInterface )( IVim __RPC_FAR * This, /* [in] */ REFIID riid, /* [iid_is][out] */ void __RPC_FAR *__RPC_FAR *ppvObject); ULONG ( STDMETHODCALLTYPE __RPC_FAR *AddRef )( IVim __RPC_FAR * This); ULONG ( STDMETHODCALLTYPE __RPC_FAR *Release )( IVim __RPC_FAR * This); HRESULT ( STDMETHODCALLTYPE __RPC_FAR *GetTypeInfoCount )( IVim __RPC_FAR * This, /* [out] */ UINT __RPC_FAR *pctinfo); HRESULT ( STDMETHODCALLTYPE __RPC_FAR *GetTypeInfo )( IVim __RPC_FAR * This, /* [in] */ UINT iTInfo, /* [in] */ LCID lcid, /* [out] */ ITypeInfo __RPC_FAR *__RPC_FAR *ppTInfo); HRESULT ( STDMETHODCALLTYPE __RPC_FAR *GetIDsOfNames )( IVim __RPC_FAR * This, /* [in] */ REFIID riid, /* [size_is][in] */ LPOLESTR __RPC_FAR *rgszNames, /* [in] */ UINT cNames, /* [in] */ LCID lcid, /* [size_is][out] */ DISPID __RPC_FAR *rgDispId); /* [local] */ HRESULT ( STDMETHODCALLTYPE __RPC_FAR *Invoke )( IVim __RPC_FAR * This, /* [in] */ DISPID dispIdMember, /* [in] */ REFIID riid, /* [in] */ LCID lcid, /* [in] */ WORD wFlags, /* [out][in] */ DISPPARAMS __RPC_FAR *pDispParams, /* [out] */ VARIANT __RPC_FAR *pVarResult, /* [out] */ EXCEPINFO __RPC_FAR *pExcepInfo, /* [out] */ UINT __RPC_FAR *puArgErr); HRESULT ( STDMETHODCALLTYPE __RPC_FAR *SendKeys )( IVim __RPC_FAR * This, /* [in] */ BSTR keys); HRESULT ( STDMETHODCALLTYPE __RPC_FAR *Eval )( IVim __RPC_FAR * This, /* [in] */ BSTR expr, /* [retval][out] */ BSTR __RPC_FAR *result); HRESULT ( STDMETHODCALLTYPE __RPC_FAR *SetForeground )( IVim __RPC_FAR * This); HRESULT ( STDMETHODCALLTYPE __RPC_FAR *GetHwnd )( IVim __RPC_FAR * This, /* [retval][out] */ UINT_PTR __RPC_FAR *result); END_INTERFACE } IVimVtbl; interface IVim { CONST_VTBL struct IVimVtbl __RPC_FAR *lpVtbl; }; #ifdef COBJMACROS #define IVim_QueryInterface(This,riid,ppvObject) \ (This)->lpVtbl -> QueryInterface(This,riid,ppvObject) #define IVim_AddRef(This) \ (This)->lpVtbl -> AddRef(This) #define IVim_Release(This) \ (This)->lpVtbl -> Release(This) #define IVim_GetTypeInfoCount(This,pctinfo) \ (This)->lpVtbl -> GetTypeInfoCount(This,pctinfo) #define IVim_GetTypeInfo(This,iTInfo,lcid,ppTInfo) \ (This)->lpVtbl -> GetTypeInfo(This,iTInfo,lcid,ppTInfo) #define IVim_GetIDsOfNames(This,riid,rgszNames,cNames,lcid,rgDispId) \ (This)->lpVtbl -> GetIDsOfNames(This,riid,rgszNames,cNames,lcid,rgDispId) #define IVim_Invoke(This,dispIdMember,riid,lcid,wFlags,pDispParams,pVarResult,pExcepInfo,puArgErr) \ (This)->lpVtbl -> Invoke(This,dispIdMember,riid,lcid,wFlags,pDispParams,pVarResult,pExcepInfo,puArgErr) #define IVim_SendKeys(This,keys) \ (This)->lpVtbl -> SendKeys(This,keys) #define IVim_Eval(This,expr,result) \ (This)->lpVtbl -> Eval(This,expr,result) #define IVim_SetForeground(This) \ (This)->lpVtbl -> SetForeground(This) #define IVim_GetHwnd(This,result) \ (This)->lpVtbl -> GetHwnd(This,result) #endif // COBJMACROS #endif // C style interface HRESULT STDMETHODCALLTYPE IVim_SendKeys_Proxy( IVim __RPC_FAR * This, /* [in] */ BSTR keys); void __RPC_STUB IVim_SendKeys_Stub( IRpcStubBuffer *This, IRpcChannelBuffer *_pRpcChannelBuffer, PRPC_MESSAGE _pRpcMessage, DWORD *_pdwStubPhase); HRESULT STDMETHODCALLTYPE IVim_Eval_Proxy( IVim __RPC_FAR * This, /* [in] */ BSTR expr, /* [retval][out] */ BSTR __RPC_FAR *result); void __RPC_STUB IVim_Eval_Stub( IRpcStubBuffer *This, IRpcChannelBuffer *_pRpcChannelBuffer, PRPC_MESSAGE _pRpcMessage, DWORD *_pdwStubPhase); HRESULT STDMETHODCALLTYPE IVim_SetForeground_Proxy( IVim __RPC_FAR * This); void __RPC_STUB IVim_SetForeground_Stub( IRpcStubBuffer *This, IRpcChannelBuffer *_pRpcChannelBuffer, PRPC_MESSAGE _pRpcMessage, DWORD *_pdwStubPhase); HRESULT STDMETHODCALLTYPE IVim_GetHwnd_Proxy( IVim __RPC_FAR * This, /* [retval][out] */ UINT_PTR __RPC_FAR *result); void __RPC_STUB IVim_GetHwnd_Stub( IRpcStubBuffer *This, IRpcChannelBuffer *_pRpcChannelBuffer, PRPC_MESSAGE _pRpcMessage, DWORD *_pdwStubPhase); #endif // __IVim_INTERFACE_DEFINED__ #ifndef __Vim_LIBRARY_DEFINED__ #define __Vim_LIBRARY_DEFINED__ //*************************************** // Generated header for library: Vim // at Wed Jun 06 18:20:37 2001 // using MIDL 3.01.75 //************************************** // [version][helpstring][uuid] EXTERN_C const IID LIBID_Vim; #ifdef __cplusplus EXTERN_C const CLSID CLSID_Vim; class DECLSPEC_UUID("0F0BFAE1-4C90-11d1-82D7-0004AC368519") Vim; #endif #endif // __Vim_LIBRARY_DEFINED__ // Additional Prototypes for ALL interfaces unsigned long __RPC_USER BSTR_UserSize( unsigned long __RPC_FAR *, unsigned long , BSTR __RPC_FAR * ); unsigned char __RPC_FAR * __RPC_USER BSTR_UserMarshal( unsigned long __RPC_FAR *, unsigned char __RPC_FAR *, BSTR __RPC_FAR * ); unsigned char __RPC_FAR * __RPC_USER BSTR_UserUnmarshal(unsigned long __RPC_FAR *, unsigned char __RPC_FAR *, BSTR __RPC_FAR * ); void __RPC_USER BSTR_UserFree( unsigned long __RPC_FAR *, BSTR __RPC_FAR * ); // end of Additional Prototypes #ifdef __cplusplus } #endif #endif