patch 9.1.0123: MS-Windows: system() may deadlock Commit: https://github.com/vim/vim/commit/52ecc76c7fa1865603f27bc838efaeaa03cad77c Author: GuyBrush <miguel.barro@live.com> Date: Wed Feb 21 20:16:38 2024 +0100 patch 9.1.0123: MS-Windows: system() may deadlock Problem: MS-Windows: system() may deadlock when calling binaries that expect stdin Solution: Ignore the SHELL_EXPAND flag (GuyBrush) This happens on binaries that expect stdin. For example: :echo system("xxd") will cause a deadlock. SHELL_EXPAND is a flag devoted to support the linux implementation of the backtick-expansion mechanism. On linux backtic-expansion relies in the function mch_expand_wildchars() (os_unix.c) that delegates on each specific shell (bash, sh, csh, zsh) the expansion. Basically it composes a shell command that does the expansion and redirects the output to a file and call_shell() it. On windows backtick-expansion is performed by Vim itself. On linux SHELL_EXPAND modifies how mch_call_shell_fork() (os_unix.c) works. This function: - relies on posix fork() to spawn a child process to execute a external command. - Child and parent process communicate using pipes (or pseudoterminal if available). User input (type ahead content) is processed in a loop only if !(SHELL_EXPAND || SHELL_COOKED). Though signals are used to detect Ctrl-C in all cases (the input loop is not necessary to interrupt the function). In the backtick-expansion the external command is the shell command that provides the expansion. For the child redirection: - SHELL_EXPAND replaces stdin, stdout & stderr to /dev/null. This is why the shell command composed includes redirection (otherwise output would be lost). - !SHELL_EXPAND replaces stdin, stdout & stderr with the parent created pipes (or pseudoterminal). Note that the use of SIGINT signal prevents mch_call_shell_fork() from hanging vim. On Windows mch_system_piped() (os_win32.c) (which is only used when the GUI is running) mimics mch_call_shell_fork() (os_unix.c). Win32 lacks fork() and relies on CreateProcessW() and only has pipe support (not pseudoterminal) which makes the implementation much different. But, the key idea is that windows lacks signals, the OS provides support for console apps but gvim is not one. The only way of detecting a Ctrl-C is actually processing user input (type ahead content). By ignoring the user input under SHELL_EXPAND the function can hang gvim. Ignoring SHELL_EXPAND flag has no consequence in Windows because as mentioned above it is only meaningful in linux. closes: #13988 Signed-off-by: GuyBrush <miguel.barro@live.com> Signed-off-by: Christian Brabandt <cb@256bit.org>

INSTALLmac.txt - Installation of Vim on Apple MacOS

This file contains instructions for compiling Vim. If you already have an
executable version of Vim, you don't need this.

MacOS Classic is no longer supported.  If you really want it use Vim 6.4.
Only '/' is supported as path separator.


----------------------------------------------------------------------------
Prerequisites
----------------------------------------------------------------------------

Make sure you've installed Xcode and CommandLineTools.  You can download Xcode
from the Mac App Store, for free.

To check for CommandLineTools open a terminal and do:

	$ make --version

If not installed yet a window pops up instructing you to install the developer
tools.

If you don't have the source yet, best is to use git (which you need to
install first), see http://www.vim.org/git.php
Or you can download and unpack the Unix tar archive, see
   http://www.vim.org/download.php


----------------------------------------------------------------------------
Build and install the terminal version.
----------------------------------------------------------------------------

You can compile vim with the standard Unix routine:
   cd vim/src
   make
   make test
   sudo make install

If you get an error "glibtool: command not found" search on stackoverflow for
mac-osx-where-can-i-download-glibtool.

With Homebrew, run:

      brew install libtool

To build libtool from source:

    1. Download the source code from https://www.gnu.org/software/libtool/.

    2. Run these commands from the root of the source code directory:

           ./configure --program-prefix=g
           make
           sudo make install


----------------------------------------------------------------------------
Build and install the GUI version with X-Windows
----------------------------------------------------------------------------

NOTE: this probably no longer works, since Athena support has been removed.

First, install XQuartz, which you can download from https://www.xquartz.org.

To tell configure to use a GUI you can edit the Makefile and uncomment these
two lines (remove the # at the start of the line):

    CONF_OPT_GUI = --enable-gui=athena
    CONF_OPT_DARWIN = --disable-darwin

Do "make distclean" to start with a clean slate.
Then build as with the terminal version above.
Instead of "athena" you can try "gtk2" but you probably need to install GTK
first.


----------------------------------------------------------------------------
Notes
----------------------------------------------------------------------------

Mac-specific configure options are explained in the Makefile:
	--disable-darwin
	--with-mac-arch