Mercurial > vim
view runtime/gvim.desktop @ 34394:a400c8f9506f v9.1.0123
patch 9.1.0123: MS-Windows: system() may deadlock
Commit: https://github.com/vim/vim/commit/52ecc76c7fa1865603f27bc838efaeaa03cad77c
Author: GuyBrush <miguel.barro@live.com>
Date: Wed Feb 21 20:16:38 2024 +0100
patch 9.1.0123: MS-Windows: system() may deadlock
Problem: MS-Windows: system() may deadlock when calling binaries that
expect stdin
Solution: Ignore the SHELL_EXPAND flag
(GuyBrush)
This happens on binaries that expect stdin. For example:
:echo system("xxd")
will cause a deadlock.
SHELL_EXPAND is a flag devoted to support the linux implementation of
the backtick-expansion mechanism.
On linux backtic-expansion relies in the function mch_expand_wildchars()
(os_unix.c) that delegates on each specific shell (bash, sh, csh, zsh)
the expansion. Basically it composes a shell command that does the
expansion and redirects the output to a file and call_shell() it. On
windows backtick-expansion is performed by Vim itself.
On linux SHELL_EXPAND modifies how mch_call_shell_fork() (os_unix.c)
works. This function:
- relies on posix fork() to spawn a child process to execute a
external command.
- Child and parent process communicate using pipes (or pseudoterminal
if available).
User input (type ahead content) is processed in a loop only if
!(SHELL_EXPAND || SHELL_COOKED).
Though signals are used to detect Ctrl-C in all cases (the input
loop is not necessary to interrupt the function).
In the backtick-expansion the external command is the shell command
that provides the expansion. For the child redirection:
- SHELL_EXPAND replaces stdin, stdout & stderr to /dev/null. This is
why the shell command composed includes redirection (otherwise
output would be lost).
- !SHELL_EXPAND replaces stdin, stdout & stderr with the parent
created pipes (or pseudoterminal).
Note that the use of SIGINT signal prevents mch_call_shell_fork()
from hanging vim.
On Windows mch_system_piped() (os_win32.c) (which is only used when the
GUI is running) mimics mch_call_shell_fork() (os_unix.c).
Win32 lacks fork() and relies on CreateProcessW() and only has pipe
support (not pseudoterminal) which makes the implementation much
different.
But, the key idea is that windows lacks signals, the OS provides support
for console apps but gvim is not one. The only way of detecting a Ctrl-C
is actually processing user input (type ahead content). By ignoring the
user input under SHELL_EXPAND the function can hang gvim.
Ignoring SHELL_EXPAND flag has no consequence in Windows because as
mentioned above it is only meaningful in linux.
closes: #13988
Signed-off-by: GuyBrush <miguel.barro@live.com>
Signed-off-by: Christian Brabandt <cb@256bit.org>
author | Christian Brabandt <cb@256bit.org> |
---|---|
date | Wed, 21 Feb 2024 20:30:02 +0100 |
parents | 729a7c00fabc |
children |
line wrap: on
line source
# The gvim.desktop file is generated by src/po/Makefile, do NOT edit. # Edit the src/po/gvim.desktop.in file instead. [Desktop Entry] # Translators: This is the Application Name used in the GVim desktop file Name[ca]=GVim Name[de]=GVim Name[eo]=GVim Name[es]=GVim Name[fi]=GVim Name[fr]=GVim Name[ga]=GVim Name[it]=GVim Name[ru]=GVim Name[sr]=GVim Name[tr]=GVim Name[uk]=GVim Name[zh_CN]=GVim Name=GVim # Translators: This is the Generic Application Name used in the Vim desktop file GenericName[ca]=Editor de text GenericName[de]=Texteditor GenericName[eo]=Tekstoredaktilo GenericName[es]=Editor de texto GenericName[fi]=Tekstinmuokkain GenericName[fr]=Éditeur de texte GenericName[ga]=Eagarthóir Téacs GenericName[it]=Editor di testi GenericName[ja]=テキストエディタ GenericName[ru]=Текстовый редактор GenericName[sr]=Едитор текст GenericName[tr]=Metin Düzenleyici GenericName[uk]=Редактор Тексту GenericName[zh_CN]=文本编辑器 GenericName=Text Editor # Translators: This is the comment used in the Vim desktop file Comment[ca]=Edita fitxers de text Comment[de]=Textdateien bearbeiten Comment[eo]=Redakti tekstajn dosierojn Comment[es]=Editar archivos de texto Comment[fi]=Muokkaa tekstitiedostoja Comment[fr]=Éditer des fichiers texte Comment[ga]=Cuir comhaid téacs in eagar Comment[it]=Edita file di testo Comment[ja]=テキストファイルを編集します Comment[ru]=Редактирование текстовых файлов Comment[sr]=Уређујте текст фајлове Comment[tr]=Metin dosyaları düzenleyin Comment[uk]=Редагувати текстові файли Comment[zh_CN]=编辑文本文件 Comment=Edit text files # The translations should come from the po file. Leave them here for now, they will # be overwritten by the po file when generating the desktop.file! GenericName[da]=Teksteditor GenericName[pl]=Edytor tekstu GenericName[is]=Ritvinnsluforrit Comment[af]=Redigeer tekslêers Comment[am]=የጽሑፍ ፋይሎች ያስተካክሉ Comment[ar]=حرّر ملفات نصية Comment[az]=Mətn fayllarını redaktə edin Comment[be]=Рэдагаваньне тэкставых файлаў Comment[bg]=Редактиране на текстови файлове Comment[bn]=টেক্স্ট ফাইল এডিট করুন Comment[bs]=Izmijeni tekstualne datoteke Comment[cs]=Úprava textových souborů Comment[cy]=Golygu ffeiliau testun Comment[da]=Rediger tekstfiler Comment[el]=Επεξεργασία αρχείων κειμένου Comment[en_CA]=Edit text files Comment[en_GB]=Edit text files Comment[et]=Redigeeri tekstifaile Comment[eu]=Editatu testu-fitxategiak Comment[fa]=ویرایش پروندههای متنی Comment[gu]=લખાણ ફાઇલોમાં ફેરફાર કરો Comment[he]=ערוך קבצי טקסט Comment[hi]=पाठ फ़ाइलें संपादित करें Comment[hr]=Uređivanje tekstualne datoteke Comment[hu]=Szövegfájlok szerkesztése Comment[id]=Edit file teks Comment[is]=Vinna með textaskrár Comment[kn]=ಪಠ್ಯ ಕಡತಗಳನ್ನು ಸಂಪಾದಿಸು Comment[ko]=텍스트 파일을 편집합니다 Comment[lt]=Redaguoti tekstines bylas Comment[lv]=Rediģēt teksta failus Comment[mk]=Уреди текстуални фајлови Comment[ml]=വാചക രചനകള് തിരുത്തുക Comment[mn]=Текст файл боловсруулах Comment[mr]=गद्य फाइल संपादित करा Comment[ms]=Edit fail teks Comment[nb]=Rediger tekstfiler Comment[ne]=पाठ फाइललाई संशोधन गर्नुहोस् Comment[nl]=Tekstbestanden bewerken Comment[nn]=Rediger tekstfiler Comment[no]=Rediger tekstfiler Comment[or]=ପାଠ୍ଯ ଫାଇଲଗୁଡ଼ିକୁ ସମ୍ପାଦନ କରନ୍ତୁ Comment[pa]=ਪਾਠ ਫਾਇਲਾਂ ਸੰਪਾਦਨ Comment[pl]=Edytuj pliki tekstowe Comment[pt]=Editar ficheiros de texto Comment[pt_BR]=Edite arquivos de texto Comment[ro]=Editare fişiere text Comment[sk]=Úprava textových súborov Comment[sl]=Urejanje datotek z besedili Comment[sq]=Përpuno files teksti Comment[sr@Latn]=Izmeni tekstualne datoteke Comment[sv]=Redigera textfiler Comment[ta]=உரை கோப்புகளை தொகுக்கவும் Comment[th]=แก้ไขแฟ้มข้อความ Comment[tk]=Metin faýllary editle Comment[vi]=Soạn thảo tập tin văn bản Comment[wa]=Asspougnî des fitcs tecses Comment[zh_TW]=編輯文字檔 TryExec=gvim Exec=gvim -f %F Terminal=false Type=Application # Translators: Search terms to find this application. Do NOT change the semicolons! The list MUST also end with a semicolon! Keywords[ca]=Text;editor; Keywords[de]=Text;Editor; Keywords[eo]=Teksto;redaktilo; Keywords[es]=Texto;editor; Keywords[fi]=Teksti;muokkain;editori; Keywords[fr]=Texte;éditeur; Keywords[ga]=Téacs;eagarthóir; Keywords[it]=Testo;editor; Keywords[ja]=テキスト;エディタ; Keywords[ru]=текст;текстовый редактор; Keywords[sr]=Текст;едитор; Keywords[tr]=Metin;düzenleyici; Keywords[uk]=текст;редактор; Keywords[zh_CN]=Text;editor;文本;编辑器; Keywords=Text;editor; # Translators: This is the Icon file name. Do NOT translate Icon=gvim Categories=Utility;TextEditor; StartupNotify=true MimeType=text/english;text/plain;text/x-makefile;text/x-c++hdr;text/x-c++src;text/x-chdr;text/x-csrc;text/x-java;text/x-moc;text/x-pascal;text/x-tcl;text/x-tex;application/x-shellscript;text/x-c;text/x-c++;