Mercurial > vim
view nsis/README.txt @ 34379:37b4c89ba420 v9.1.0116
patch 9.1.0116: win_split_ins may not check available room
Commit: https://github.com/vim/vim/commit/0fd44a5ad81ade342cb54d8984965bdedd2272c8
Author: Sean Dewar <6256228+seandewar@users.noreply.github.com>
Date: Tue Feb 20 20:28:15 2024 +0100
patch 9.1.0116: win_split_ins may not check available room
Problem: win_split_ins has no check for E36 when moving an existing
window
Solution: check for room and fix the issues in f_win_splitmove()
(Sean Dewar)
win_split_ins has no check for E36 when moving an existing window,
allowing for layouts with many overlapping zero-sized windows to be
created (which may also cause drawing issues with tablines and such).
f_win_splitmove also has some bugs.
So check for room and fix the issues in f_win_splitmove. Handle failure
in the two relevant win_split_ins callers by restoring the original
layout, and factor the common logic into win_splitmove.
Don't check for room when opening an autocommand window, as it's a
temporary window that's rarely interacted with or drawn anyhow, and is
rather important for some autocommands.
Issues fixed in f_win_splitmove:
- Error if splitting is disallowed.
- Fix heap-use-after-frees if autocommands fired from switching to "targetwin"
close "wp" or "oldwin".
- Fix splitting the wrong window if autocommands fired from switching to
"targetwin" switch to a different window.
- Ensure -1 is returned for all errors.
Also handle allocation failure a bit earlier in make_snapshot (callers,
except win_splitmove, don't really care if a snapshot can't be made, so
just ignore the return value).
Note: Test_smoothscroll_in_zero_width_window failed after these changes with
E36, as it was using the previous behaviour to create a zero-width window.
I've fixed the test such that it fails with UBSAN as expected when v9.0.1367 is
reverted (and simplified it too).
related: #14042
Signed-off-by: Sean Dewar <6256228+seandewar@users.noreply.github.com>
Signed-off-by: Christian Brabandt <cb@256bit.org>
author | Christian Brabandt <cb@256bit.org> |
---|---|
date | Tue, 20 Feb 2024 22:30:04 +0100 |
parents | 238f424acc6c |
children | d91ac228d7df |
line wrap: on
line source
This builds a one-click install for Vim for Win32 using the Nullsoft Installation System (NSIS), available at http://nsis.sourceforge.net/ To build the installable .exe: 1. Unpack three archives: PC sources PC runtime PC language files You can generate these from the Unix sources and runtime plus the extra archive (see the Makefile in the top directory). 2. Go to the src directory and build: gvim.exe (the OLE version), vimrun.exe, install.exe, uninstall.exe, tee/tee.exe, xxd/xxd.exe, Then execute tools/rename.bat to rename the executables. (mv command is required.) 3. Go to the GvimExt directory and build gvimext.dll (or get it from a binary archive). Both 64- and 32-bit versions are needed and should be placed as follows: 64-bit: src/GvimExt/gvimext64.dll 32-bit: src/GvimExt/gvimext.dll 4. Get a "diff.exe" program. If you skip this the built-in diff will always be used (which is fine for most users). If you do have your own "diff.exe" put it in the "../.." directory (above the "vim90" directory, it's the same for all Vim versions). You can find one in previous Vim versions or in this archive: http://www.mossbayeng.com/~ron/vim/diffutils.tar.gz 5 Also put winpty32.dll and winpty-agent.exe in "../.." (above the "vim90" directory). This is required for the terminal window. 6. Do "make uganda.nsis.txt" in runtime/doc. This requires sed, you may have to do this on Unix. Make sure the file is in DOS file format! 7. Get gettext and iconv DLLs from the following site: https://github.com/mlocati/gettext-iconv-windows/releases Both 64- and 32-bit versions are needed. Download the files gettextX.X.X.X-iconvX.XX-shared-{32,64}.zip, extract DLLs and place them as follows: <GETTEXT directory> | + gettext32/ | libintl-8.dll | libiconv-2.dll | libgcc_s_sjlj-1.dll | ` gettext64/ libintl-8.dll libiconv-2.dll The default <GETTEXT directory> is "..", however, you can change it by passing /DGETTEXT=... option to the makensis command. Install NSIS if you didn't do that already. Also install UPX, if you want a compressed file. Download and include the ShellExecAsUser.dll Unicode version which can be sourced from: https://nsis.sourceforge.io/ShellExecAsUser_plug-in Unpack the images: cd nsis unzip icons.zip Then build gvim.exe: cd nsis makensis gvim.nsi