Mercurial > vim
view .github/labeler.yml @ 34379:37b4c89ba420 v9.1.0116
patch 9.1.0116: win_split_ins may not check available room
Commit: https://github.com/vim/vim/commit/0fd44a5ad81ade342cb54d8984965bdedd2272c8
Author: Sean Dewar <6256228+seandewar@users.noreply.github.com>
Date: Tue Feb 20 20:28:15 2024 +0100
patch 9.1.0116: win_split_ins may not check available room
Problem: win_split_ins has no check for E36 when moving an existing
window
Solution: check for room and fix the issues in f_win_splitmove()
(Sean Dewar)
win_split_ins has no check for E36 when moving an existing window,
allowing for layouts with many overlapping zero-sized windows to be
created (which may also cause drawing issues with tablines and such).
f_win_splitmove also has some bugs.
So check for room and fix the issues in f_win_splitmove. Handle failure
in the two relevant win_split_ins callers by restoring the original
layout, and factor the common logic into win_splitmove.
Don't check for room when opening an autocommand window, as it's a
temporary window that's rarely interacted with or drawn anyhow, and is
rather important for some autocommands.
Issues fixed in f_win_splitmove:
- Error if splitting is disallowed.
- Fix heap-use-after-frees if autocommands fired from switching to "targetwin"
close "wp" or "oldwin".
- Fix splitting the wrong window if autocommands fired from switching to
"targetwin" switch to a different window.
- Ensure -1 is returned for all errors.
Also handle allocation failure a bit earlier in make_snapshot (callers,
except win_splitmove, don't really care if a snapshot can't be made, so
just ignore the return value).
Note: Test_smoothscroll_in_zero_width_window failed after these changes with
E36, as it was using the previous behaviour to create a zero-width window.
I've fixed the test such that it fails with UBSAN as expected when v9.0.1367 is
reverted (and simplified it too).
related: #14042
Signed-off-by: Sean Dewar <6256228+seandewar@users.noreply.github.com>
Signed-off-by: Christian Brabandt <cb@256bit.org>
author | Christian Brabandt <cb@256bit.org> |
---|---|
date | Tue, 20 Feb 2024 22:30:04 +0100 |
parents | 93a5438726a2 |
children |
line wrap: on
line source
# list of labels and minimatch globs to match to apply the label. CI: - all: - changed-files: - any-glob-to-any-file: - '.cirrus.yml' - '.github/dependabot.yml' - '.github/labeler.yml' - '.github/workflows/*' - '.appveyor.yml' - '.codecov.yml' documentation: - all: - changed-files: - any-glob-to-all-files: - '*/doc/*' translation: - all: - changed-files: - any-glob-to-any-file: - 'src/po/*.po' if_lua: - all: - changed-files: - any-glob-to-any-file: - 'src/if_lua.c' - 'src/proto/if_lua.pro' - 'runtime/doc/if_lua.txt' if_mzscheme: - all: - changed-files: - any-glob-to-any-file: - 'src/if_mzsch.c' - 'src/if_mzsch.h' - 'src/proto/if_mzsch.pro' - 'runtime/doc/if_mzsch.txt' if_perl: - all: - changed-files: - any-glob-to-any-file: - 'src/if_perl.xs' - 'src/if_perlsfio.c' - 'src/proto/if_perl.pro' - 'src/proto/if_perlsfio.pro' - 'runtime/doc/if_perl.txt' if_python: - all: - changed-files: - any-glob-to-any-file: - 'src/if_py_both.h' - 'runtime/doc/if_pyth.txt' - 'src/if_python.c' - 'src/if_python3.c' - 'src/proto/if_python.pro' - 'src/proto/if_python3.pro' if_ruby: - all: - changed-files: - any-glob-to-any-file: - 'src/if_ruby.c' - 'src/proto/if_ruby.pro' - 'runtime/doc/if_ruby.txt' if_tcl: - all: - changed-files: - any-glob-to-any-file: - 'src/if_tcl.c' - 'src/proto/if_tcl.pro' - 'runtime/doc/if_tcl.txt' installer: - all: - changed-files: - any-glob-to-any-file: - 'nsis/**' - 'src/dosinst.*' - 'src/uninstall.c' platform-mac: - all: - changed-files: - any-glob-to-any-file: - 'src/INSTALLmac.txt' - 'src/os_mac*' - 'src/proto/os_mac*' platform-windows: - all: - changed-files: - any-glob-to-any-file: - 'nsis/**' - 'src/*.bat' - 'src/*.bmp' - 'src/*.ico' - 'src/GvimExt/*' - 'src/INSTALLpc.txt' - 'src/Make_cyg*.mak' - 'src/Make_ming.mak' - 'src/Make_mvc.mak' - 'src/dosinst.*' - 'src/gui_dwrite.*' - 'src/gui_w32*' - 'src/if_ole.*' - 'src/iid_ole.c' - 'src/os_mswin*' - 'src/os_w32*' - 'src/os_win32.*' - 'src/proto/gui_w32.pro' - 'src/proto/os_mswin.pro' - 'src/proto/os_win32.pro' - 'src/proto/winclip.pro' - 'src/uninstall.c' - 'src/vim.manifest' - 'src/vim.rc' - 'src/vimrun.c' - 'src/winclip.c' - 'src/xpm/**' - 'src/xpm_w32.*' runtime: - all: - changed-files: - any-glob-to-any-file: - 'runtime/ftplugin' - 'runtime/syntax' - 'runtime/indent' - 'runtime/pack/dist/opt/termdebug/plugin/termdebug.vim' termdebug: - all: - changed-files: - any-glob-to-any-file: - 'runtime/pack/dist/opt/termdebug/plugin/termdebug.vim' plugin-netrw: - all: - changed-files: - any-glob-to-any-file: - 'runtime/plugin/netrwPlugin.vim' - 'runtime/autoload/netrw*' xxd: - all: - changed-files: - any-glob-to-any-file: - 'src/xxd/*'