Mercurial > vim
view nsis/README.txt @ 34309:d7cfd8fb1d75 v9.1.0089
patch 9.1.0089: qsort() comparison functions should be transitive
Commit: https://github.com/vim/vim/commit/e06e43766500ecb4cd1031fa16cf9cbebdb222c1
Author: Christian Brabandt <cb@256bit.org>
Date: Fri Feb 9 19:39:14 2024 +0100
patch 9.1.0089: qsort() comparison functions should be transitive
Problem: qsort() comparison functions should be transitive
Solution: Do not subtract values, but rather use explicit comparisons
Improve qsort() comparison functions
There has been a recent report on qsort() causing out-of-bounds read &
write in glibc for non transitive comparison functions
https://www.qualys.com/2024/01/30/qsort.txt
Even so the bug is in glibc's implementation of the qsort() algorithm,
it's bad style to just use substraction for the comparison functions,
which may cause overflow issues and as hinted at in OpenBSD's manual
page for qsort(): "It is almost always an error to use subtraction to
compute the return value of the comparison function."
So check the qsort() comparison functions and change them to be safe.
closes: #13980
Signed-off-by: Christian Brabandt <cb@256bit.org>
author | Christian Brabandt <cb@256bit.org> |
---|---|
date | Fri, 09 Feb 2024 19:45:06 +0100 |
parents | 238f424acc6c |
children | d91ac228d7df |
line wrap: on
line source
This builds a one-click install for Vim for Win32 using the Nullsoft Installation System (NSIS), available at http://nsis.sourceforge.net/ To build the installable .exe: 1. Unpack three archives: PC sources PC runtime PC language files You can generate these from the Unix sources and runtime plus the extra archive (see the Makefile in the top directory). 2. Go to the src directory and build: gvim.exe (the OLE version), vimrun.exe, install.exe, uninstall.exe, tee/tee.exe, xxd/xxd.exe, Then execute tools/rename.bat to rename the executables. (mv command is required.) 3. Go to the GvimExt directory and build gvimext.dll (or get it from a binary archive). Both 64- and 32-bit versions are needed and should be placed as follows: 64-bit: src/GvimExt/gvimext64.dll 32-bit: src/GvimExt/gvimext.dll 4. Get a "diff.exe" program. If you skip this the built-in diff will always be used (which is fine for most users). If you do have your own "diff.exe" put it in the "../.." directory (above the "vim90" directory, it's the same for all Vim versions). You can find one in previous Vim versions or in this archive: http://www.mossbayeng.com/~ron/vim/diffutils.tar.gz 5 Also put winpty32.dll and winpty-agent.exe in "../.." (above the "vim90" directory). This is required for the terminal window. 6. Do "make uganda.nsis.txt" in runtime/doc. This requires sed, you may have to do this on Unix. Make sure the file is in DOS file format! 7. Get gettext and iconv DLLs from the following site: https://github.com/mlocati/gettext-iconv-windows/releases Both 64- and 32-bit versions are needed. Download the files gettextX.X.X.X-iconvX.XX-shared-{32,64}.zip, extract DLLs and place them as follows: <GETTEXT directory> | + gettext32/ | libintl-8.dll | libiconv-2.dll | libgcc_s_sjlj-1.dll | ` gettext64/ libintl-8.dll libiconv-2.dll The default <GETTEXT directory> is "..", however, you can change it by passing /DGETTEXT=... option to the makensis command. Install NSIS if you didn't do that already. Also install UPX, if you want a compressed file. Download and include the ShellExecAsUser.dll Unicode version which can be sourced from: https://nsis.sourceforge.io/ShellExecAsUser_plug-in Unpack the images: cd nsis unzip icons.zip Then build gvim.exe: cd nsis makensis gvim.nsi