patch 9.1.0061: UX of visual highlighting can be improved Commit: https://github.com/vim/vim/commit/e6d8b4662ddf9356da53f56e363b67b524fd8825 Author: Christian Brabandt <cb@256bit.org> Date: Sun Jan 28 23:33:29 2024 +0100 patch 9.1.0061: UX of visual highlighting can be improved Problem: UX of visual highlighting can be improved Solution: Improve readibility of visual highlighting, by setting better foreground and background colors The default visual highlighting currently is nice in that it overlays the actual syntax highlighting by using a separate distinct background color. However, this can cause hard to read text, because the contrast between the actual syntax element and the background color is way too low. That is an issue, that has been bothering colorschemes authors for quite some time so much, that they are defining the Visual highlighting group to use a separate foreground and background color, so that the syntax highlighting vanishes, but the text remains readable (ref: vim/colorschemes#250) So this is an attempt to perform the same fix for the default Visual highlighting and just use a default foreground and background color instead of using reverse. I also removed the hard-coded changes to the Visual highlighting in init_highlight. It's not quite clear to me, why those were there and not added directly to the highlighting_init_<dark|light> struct. closes: #13663 related: vim/colorschemes#250 Signed-off-by: Christian Brabandt <cb@256bit.org>

" Vim syntax file
" Language:             protocols(5) - Internet protocols definition file
" Previous Maintainer:  Nikolai Weibull <now@bitwi.se>
" Latest Revision:      2006-04-19

if exists("b:current_syntax")
  finish
endif

let s:cpo_save = &cpo
set cpo&vim

syn match   protocolsBegin    display '^'
                              \ nextgroup=protocolsName,protocolsComment

syn match   protocolsName     contained display '[[:graph:]]\+'
                              \ nextgroup=protocolsPort skipwhite

syn match   protocolsPort     contained display '\d\+'
                              \ nextgroup=protocolsAliases,protocolsComment
                              \ skipwhite

syn match   protocolsAliases  contained display '\S\+'
                              \ nextgroup=protocolsAliases,protocolsComment
                              \ skipwhite

syn keyword protocolsTodo     contained TODO FIXME XXX NOTE

syn region  protocolsComment  display oneline start='#' end='$'
                              \ contains=protocolsTodo,@Spell

hi def link protocolsTodo      Todo
hi def link protocolsComment   Comment
hi def link protocolsName      Identifier
hi def link protocolsPort      Number
hi def link protocolsPPDiv     Delimiter
hi def link protocolsPPDivDepr Error
hi def link protocolsProtocol  Type
hi def link protocolsAliases   Macro

let b:current_syntax = "protocols"

let &cpo = s:cpo_save
unlet s:cpo_save