Mercurial > vim
view runtime/bugreport.vim @ 33865:8cdb69ea3711 v9.0.2143
patch 9.0.2143: [security]: buffer-overflow in ex_substitute
Commit: https://github.com/vim/vim/commit/abfa13ebe92d81aaf66669c428d767847b577453
Author: Christian Brabandt <cb@256bit.org>
Date: Thu Nov 30 11:32:18 2023 +0100
patch 9.0.2143: [security]: buffer-overflow in ex_substitute
Problem: [security]: buffer-overflow in ex_substitute
Solution: clear memory after allocating
When allocating the new_start pointer in ex_substitute() the memory
pointer points to some garbage that the following for loop in
ex_cmds.c:4743 confuses and causes it to accessing the new_start pointer
beyond it's size, leading to a buffer-overlow.
So fix this by using alloc_clear() instead of alloc(), which will
clear the memory by NUL and therefore cause the loop to terminate
correctly.
Reported by @henices, thanks!
closes: #13596
Signed-off-by: Christian Brabandt <cb@256bit.org>
author | Christian Brabandt <cb@256bit.org> |
---|---|
date | Sun, 10 Dec 2023 15:16:05 +0100 |
parents | 4027cefc2aab |
children |
line wrap: on
line source
:" Use this script to create the file "bugreport.txt", which contains :" information about the environment of a possible bug in Vim. :" :" Maintainer: The Vim Project <https://github.com/vim/vim> :" Last change: 2023 Aug 10 :" Former Maintainer: Bram Moolenaar <Bram@vim.org> :" :" To use inside Vim: :" :so $VIMRUNTIME/bugreport.vim :" Or, from the command line: :" vim -s $VIMRUNTIME/bugreport.vim :" :" The "if 1" lines are to avoid error messages when expression evaluation is :" not compiled in. :" :if 1 : let more_save = &more :endif :set nomore :if has("unix") : !echo "uname -a" >bugreport.txt : !uname -a >>bugreport.txt :endif :redir >>bugreport.txt :version :if 1 : func <SID>CheckDir(n) : if isdirectory(a:n) : echo 'directory "' . a:n . '" exists' : else : echo 'directory "' . a:n . '" does NOT exist' : endif : endfun : func <SID>CheckFile(n) : if filereadable(a:n) : echo '"' . a:n . '" is readable' : else : echo '"' . a:n . '" is NOT readable' : endif : endfun : echo "--- Directories and Files ---" : echo '$VIM = "' . $VIM . '"' : call <SID>CheckDir($VIM) : echo '$VIMRUNTIME = "' . $VIMRUNTIME . '"' : call <SID>CheckDir($VIMRUNTIME) : call <SID>CheckFile(&helpfile) : call <SID>CheckFile(fnamemodify(&helpfile, ":h") . "/tags") : call <SID>CheckFile($VIMRUNTIME . "/menu.vim") : call <SID>CheckFile($VIMRUNTIME . "/filetype.vim") : call <SID>CheckFile($VIMRUNTIME . "/syntax/synload.vim") : delfun <SID>CheckDir : delfun <SID>CheckFile : echo "--- Scripts sourced ---" : scriptnames :endif :set all :set termcap :au :if 1 : echo "--- Normal/Visual mode mappings ---" :endif :map :if 1 : echo "--- Insert/Command-line mode mappings ---" :endif :map! :if 1 : echo "--- Abbreviations ---" :endif :ab :if 1 : echo "--- Highlighting ---" :endif :highlight :if 1 : echo "--- Variables ---" :endif :if 1 : let :endif :redir END :set more& :if 1 : let &more = more_save : unlet more_save :endif :e bugreport.txt