Mercurial > vim
view src/os_amiga.h @ 33811:06219b3bdaf3 v9.0.2121
patch 9.0.2121: [security]: use-after-free in ex_substitute
Commit: https://github.com/vim/vim/commit/26c11c56888d01e298cd8044caf860f3c26f57bb
Author: Christian Brabandt <cb@256bit.org>
Date: Wed Nov 22 21:26:41 2023 +0100
patch 9.0.2121: [security]: use-after-free in ex_substitute
Problem: [security]: use-after-free in ex_substitute
Solution: always allocate memory
closes: #13552
A recursive :substitute command could cause a heap-use-after free in Vim
(CVE-2023-48706).
The whole reproducible test is a bit tricky, I can only reproduce this
reliably when no previous substitution command has been used yet
(which is the reason, the test needs to run as first one in the
test_substitute.vim file) and as a combination of the `:~` command
together with a :s command that contains the special substitution atom `~\=`
which will make use of a sub-replace special atom and calls a vim script
function.
There was a comment in the existing :s code, that already makes the
`sub` variable allocate memory so that a recursive :s call won't be able
to cause any issues here, so this was known as a potential problem
already. But for the current test-case that one does not work, because
the substitution does not start with `\=` but with `~\=` (and since
there does not yet exist a previous substitution atom, Vim will simply
increment the `sub` pointer (which then was not allocated dynamically)
and later one happily use a sub-replace special expression (which could
then free the `sub` var).
The following commit fixes this, by making the sub var always using
allocated memory, which also means we need to free the pointer whenever
we leave the function. Since sub is now always an allocated variable,
we also do no longer need the sub_copy variable anymore, since this one
was used to indicated when sub pointed to allocated memory (and had
therefore to be freed on exit) and when not.
Github Security Advisory:
https://github.com/vim/vim/security/advisories/GHSA-c8qm-x72m-q53q
Signed-off-by: Christian Brabandt <cb@256bit.org>
author | Christian Brabandt <cb@256bit.org> |
---|---|
date | Wed, 22 Nov 2023 22:15:05 +0100 |
parents | 695b50472e85 |
children |
line wrap: on
line source
/* vi:set ts=8 sts=4 sw=4 noet: * * VIM - Vi IMproved by Bram Moolenaar * * Do ":help uganda" in Vim to read copying and usage conditions. * Do ":help credits" in Vim to see a list of people who contributed. */ /* * Amiga Machine-dependent things */ #define CASE_INSENSITIVE_FILENAME // ignore case when comparing file names #define SPACE_IN_FILENAME #define USE_FNAME_CASE // adjust case of file names #define USE_TERM_CONSOLE #define HAVE_AVAIL_MEM #ifndef HAVE_CONFIG_H # if defined(AZTEC_C) || defined(__amigaos4__) # define HAVE_STAT_H # endif # define HAVE_STDLIB_H # define HAVE_STRING_H # define HAVE_FCNTL_H # define HAVE_STRCSPN # define HAVE_STRICMP # define HAVE_STRNICMP # define HAVE_STRFTIME // guessed # define HAVE_SETENV # define HAVE_MEMSET # define HAVE_QSORT # if defined(__DATE__) && defined(__TIME__) # define HAVE_DATE_TIME # endif #endif // HAVE_CONFIG_H #ifndef DFLT_ERRORFILE # define DFLT_ERRORFILE "AztecC.Err" // Should this change? #endif #ifndef DFLT_RUNTIMEPATH # define DFLT_RUNTIMEPATH "home:vimfiles,$VIM/vimfiles,$VIMRUNTIME,$VIM/vimfiles/after,home:vimfiles/after" #endif #ifndef CLEAN_RUNTIMEPATH # define CLEAN_RUNTIMEPATH "$VIM/vimfiles,$VIMRUNTIME,$VIM/vimfiles/after" #endif #ifndef BASENAMELEN # define BASENAMELEN 26 // Amiga #endif #ifndef TEMPNAME # define TEMPNAME "t:v?XXXXXX" # define TEMPNAMELEN 12 #endif // cproto fails on missing include files #ifndef PROTO #include <exec/types.h> #include <libraries/dos.h> #include <libraries/dosextens.h> // Currently, all Amiga compilers except AZTEC C have these... #ifndef AZTEC_C # include <proto/exec.h> # include <proto/dos.h> # include <proto/intuition.h> #endif #endif // PROTO #define FNAME_ILLEGAL ";*?`#%" // illegal characters in a file name /* * Manx doesn't have off_t, define it here. */ #ifdef AZTEC_C typedef long off_t; #endif #ifdef LATTICE # define USE_TMPNAM // use tmpnam() instead of mktemp() #endif #ifdef __GNUC__ # include <sys/stat.h> # include <unistd.h> # include <limits.h> # include <errno.h> # include <pwd.h> # include <grp.h> # include <dirent.h> #endif #include <time.h> // for strftime() and others #ifndef PROTO /* * arpbase.h must be included before functions.h */ #ifdef FEAT_ARP # include <libraries/arpbase.h> #endif #endif // PROTO /* * This won't be needed if you have a version of Lattice 4.01 without broken * break signal handling. */ #include <signal.h> /* * Names for the EXRC, HELP and temporary files. * Some of these may have been defined in the makefile. */ #ifndef SYS_VIMRC_FILE # define SYS_VIMRC_FILE "$VIM/vimrc" #endif #ifndef SYS_GVIMRC_FILE # define SYS_GVIMRC_FILE "$VIM/gvimrc" #endif #ifndef SYS_MENU_FILE # define SYS_MENU_FILE "$VIMRUNTIME/menu.vim" #endif #ifndef DFLT_HELPFILE # define DFLT_HELPFILE "$VIMRUNTIME/doc/help.txt" #endif #ifndef SYNTAX_FNAME # define SYNTAX_FNAME "$VIMRUNTIME/syntax/%s.vim" #endif #ifndef USR_EXRC_FILE # define USR_EXRC_FILE "s:.exrc" #endif #ifndef USR_EXRC_FILE2 # define USR_EXRC_FILE2 "home:.exrc" #endif #ifndef USR_VIMRC_FILE # define USR_VIMRC_FILE "s:.vimrc" #endif #ifndef USR_VIMRC_FILE2 # define USR_VIMRC_FILE2 "home:.vimrc" #endif #ifndef USR_VIMRC_FILE3 # define USR_VIMRC_FILE3 "home:vimfiles:vimrc" #endif #ifndef USR_VIMRC_FILE4 # define USR_VIMRC_FILE4 "$VIM/.vimrc" #endif #ifndef VIM_DEFAULTS_FILE # define VIM_DEFAULTS_FILE "$VIMRUNTIME/defaults.vim" #endif #ifndef EVIM_FILE # define EVIM_FILE "$VIMRUNTIME/evim.vim" #endif #ifndef USR_GVIMRC_FILE # define USR_GVIMRC_FILE "s:.gvimrc" #endif #ifndef USR_GVIMRC_FILE2 # define USR_GVIMRC_FILE2 "home:.gvimrc" #endif #ifndef USR_GVIMRC_FILE3 # define USR_GVIMRC_FILE3 "home:vimfiles:gvimrc" #endif #ifndef USR_GVIMRC_FILE4 # define USR_GVIMRC_FILE4 "$VIM/.gvimrc" #endif #ifdef FEAT_VIMINFO # ifndef VIMINFO_FILE # define VIMINFO_FILE "s:.viminfo" # endif #endif #ifndef EXRC_FILE # define EXRC_FILE ".exrc" #endif #ifndef VIMRC_FILE # define VIMRC_FILE ".vimrc" #endif #ifndef GVIMRC_FILE # define GVIMRC_FILE ".gvimrc" #endif #ifndef DFLT_BDIR # define DFLT_BDIR ".,t:" // default for 'backupdir' #endif #ifndef DFLT_DIR # define DFLT_DIR ".,t:" // default for 'directory' #endif #ifndef DFLT_VDIR # define DFLT_VDIR "home:vimfiles/view" // default for 'viewdir' #endif #ifndef DFLT_MAXMEM # define DFLT_MAXMEM 256 // use up to 256Kbyte for buffer #endif #ifndef DFLT_MAXMEMTOT # define DFLT_MAXMEMTOT 0 // decide in set_init #endif #if defined(SASC) int setenv(const char *, const char *); #endif #define mch_remove(x) remove((char *)(x)) #define mch_rename(src, dst) rename(src, dst) #define mch_chdir(s) chdir(s) #define vim_mkdir(x, y) mch_mkdir(x)