Mercurial > vim
view src/if_perlsfio.c @ 33802:b857615e5d42 v9.0.2117
patch 9.0.2117: [security] use-after-free in qf_free_items
Commit: https://github.com/vim/vim/commit/567cae2630a51efddc07eacff3b38a295e1f5671
Author: Christian Brabandt <cb@256bit.org>
Date: Sun Nov 19 16:19:27 2023 +0100
patch 9.0.2117: [security] use-after-free in qf_free_items
Problem: [security] use-after-free in qf_free_items
Solution: only access qfpnext, if it hasn't been freed
Coverity discovered a possible use-after-free in qf_free_items. When
freeing the qfline items, we may access freed memory, when qfp ==
qfpnext.
So only access qfpnext, when it hasn't been freed.
Signed-off-by: Christian Brabandt <cb@256bit.org>
author | Christian Brabandt <cb@256bit.org> |
---|---|
date | Tue, 21 Nov 2023 20:15:05 +0100 |
parents | f0f9692d4487 |
children |
line wrap: on
line source
/* vi:set ts=8 sts=4 sw=4 noet: * * VIM - Vi IMproved by Bram Moolenaar * * Do ":help uganda" in Vim to read copying and usage conditions. * Do ":help credits" in Vim to see a list of people who contributed. * See README.txt for an overview of the Vim source code. */ /* * if_perlsfio.c: Special I/O functions for Perl interface. */ #define _memory_h // avoid memset redeclaration #define IN_PERL_FILE // don't include if_perl.pro from prot.h #include "vim.h" #if defined(USE_SFIO) || defined(PROTO) #ifndef USE_SFIO // just generating prototypes # define Sfio_t int # define Sfdisc_t int #endif #define NIL(type) ((type)0) static int sfvimwrite( Sfio_t *f, // stream involved char *buf, // buffer to read from int n, // number of bytes to write Sfdisc_t *disc) // discipline { char_u *str; str = vim_strnsave((char_u *)buf, n); if (str == NULL) return 0; msg_split((char *)str); vim_free(str); return n; } /* * sfdcnewnvi -- * Create Vim discipline */ Sfdisc_t * sfdcnewvim(void) { Sfdisc_t *disc; disc = ALLOC_ONE(Sfdisc_t); if (disc == NULL) return NULL; disc->readf = (Sfread_f)NULL; disc->writef = sfvimwrite; disc->seekf = (Sfseek_f)NULL; disc->exceptf = (Sfexcept_f)NULL; return disc; } #endif // USE_SFIO