Mercurial > vim
view vimtutor.com @ 33581:403d57b06231 v9.0.2035
patch 9.0.2035: [security] use-after-free with wildmenu
Commit: https://github.com/vim/vim/commit/8f4fb007e4d472b09ff6bed9ffa485e0c3093699
Author: Yee Cheng Chin <ychin.git@gmail.com>
Date: Tue Oct 17 10:06:56 2023 +0200
patch 9.0.2035: [security] use-after-free with wildmenu
Problem: [security] use-after-free with wildmenu
Solution: properly clean up the wildmenu when exiting
Fix wildchar/wildmenu/pum memory corruption with special wildchar's
Currently, using `wildchar=<Esc>` or `wildchar=<C-\>` can lead to a
memory corruption if using wildmenu+pum, or wrong states if only using
wildmenu. This is due to the code only using one single place inside the
cmdline process loop to perform wild menu clean up (by checking
`end_wildmenu`) but there are other odd situations where the loop could
have exited and we need a post-loop clean up just to be sure. If the
clean up was not done you would have a stale popup menu referring to
invalid memory, or if not using popup menu, incorrect status line (if
`laststatus=0`).
For example, if you hit `<Esc>` two times when it's wildchar, there's a
hard-coded behavior to exit command-line as a failsafe for user, and if
you hit `<C-\><C-\><C-N>` it will also exit command-line, but the clean
up code would not have hit because of specialized `<C-\>` handling.
Fix Ctrl-E / Ctrl-Y to not cancel/accept wildmenu if they are also
used for 'wildchar'/'wildcharm'. Currently they don't behave properly,
and also have potentially memory unsafe behavior as the logic is
currently not accounting for this situation and try to do both.
(Previous patch that addressed this: #11677)
Also, correctly document Escape key behavior (double-hit it to escape)
in wildchar docs as it's previously undocumented.
In addition, block known invalid chars to be set in `wildchar` option,
such as Ctrl-C and `<CR>`. This is just to make it clear to the user
they shouldn't be set, and is not required for this bug fix.
closes: #13361
Signed-off-by: Christian Brabandt <cb@256bit.org>
Co-authored-by: Yee Cheng Chin <ychin.git@gmail.com>
author | Christian Brabandt <cb@256bit.org> |
---|---|
date | Tue, 17 Oct 2023 10:15:08 +0200 |
parents | 6f55637de261 |
children |
line wrap: on
line source
$ ! $ !===================================================================== $ ! $ ! VimTutor.com version 29-Aug-2002 $ ! $ ! Author: Tom Wyant <Thomas.R.Wyant-III@usa.dupont.com> $ ! $ ! This DCL command procedure executes the vimtutor command $ ! (surprise, surprise!) which gives you a brief tutorial on the $ ! VIM editor. Languages other than the default are supported in $ ! the usual way, as are at least some of the command qualifiers, $ ! though you'll need to play some fairly serious games with DCL $ ! to specify ones that need quoting. $ ! $ ! Copyright (c) 2002 E. I. DuPont de Nemours and Company, Inc $ ! $ ! This program is free software; you can redistribute it and/or $ ! modify it under the terms of the VIM license as available from $ ! the vim 6.1 ":help license" command or (at your option) the $ ! license from any later version of vim. $ ! $ ! This program is distributed in the hope that it will be useful, $ ! but WITHOUT ANY WARRANTY; without even the implied warranty of $ ! MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. $ ! $ !===================================================================== $ ! $ ! $ ! Check for the existence of VIM, and die if it isn't there. $ ! $ if f$search ("vim:vim.exe") .eqs. "" $ then $ write sys$error "Error - Can't run tutorial. VIM not found." $ exit $ endif $ ! $ ! $ ! Pick up the argument, if any. $ ! $ inx = 0 $ arg_loop: $ inx = inx + 1 $ if f$type (p'inx') .nes. "" $ then $ if p'inx' .nes. "" .and. f$locate ("-", p'inx') .ne. 0 $ then $ xx = p'inx' $ assign/nolog "''xx'" xx $ p'inx' = "" $ endif $ goto arg_loop $ endif $ ! $ ! $ ! Make sure we clean up our toys when we're through playing. $ ! $ on error then goto exit $ ! $ ! $ ! Create the VIM foreign command if needed $ ! $ if f$type (vim) .eqs. "" then vim := $vim:vim $ ! $ ! $ ! Build the name for our temp file. $ ! $ tutfil = "sys$login:vimtutor_" + - f$edit (f$getjpi (0, "pid"), "trim") + "." $ assign/nolog 'tutfil' TUTORCOPY $ ! $ ! $ ! Copy the selected file to the temp file $ ! $ assign/nolog/user nla0: sys$error $ assign/nolog/user nla0: sys$output $ vim -u "NONE" -c "so $VIMRUNTIME/tutor/tutor.vim" $ ! $ ! $ ! Run the tutorial $ ! $ assign/nolog/user sys$command sys$input $ vim -u "NONE" -c "set nocp" 'p1' 'p2' 'p3' 'p4' 'p5' 'p6' 'p7' 'p8' 'tutfil' $ ! $ ! $ ! Ditch the copy. $ ! $ exit: $ if f$type (tutfil) .nes. "" .and. f$search (tutfil) .nes. "" then - $ delete 'tutfil';* $ if f$type (xx) .nes. "" then deassign xx $ deassign TUTORCOPY $ exit $ ! $ !===================================================================== $ ! $ ! Modification history $ ! $ ! 29-Aug-2002 T. R. Wyant $ ! Changed license to vim. $ ! Fix error "input is not from a terminal" $ ! Juggle documentation (copyright and contact to front, $ ! modification history to end). $ ! 25-Jul-2002 T. R. Wyant $ ! Initial version