Mercurial > vim
view READMEdir/README_os390.txt @ 33581:403d57b06231 v9.0.2035
patch 9.0.2035: [security] use-after-free with wildmenu
Commit: https://github.com/vim/vim/commit/8f4fb007e4d472b09ff6bed9ffa485e0c3093699
Author: Yee Cheng Chin <ychin.git@gmail.com>
Date: Tue Oct 17 10:06:56 2023 +0200
patch 9.0.2035: [security] use-after-free with wildmenu
Problem: [security] use-after-free with wildmenu
Solution: properly clean up the wildmenu when exiting
Fix wildchar/wildmenu/pum memory corruption with special wildchar's
Currently, using `wildchar=<Esc>` or `wildchar=<C-\>` can lead to a
memory corruption if using wildmenu+pum, or wrong states if only using
wildmenu. This is due to the code only using one single place inside the
cmdline process loop to perform wild menu clean up (by checking
`end_wildmenu`) but there are other odd situations where the loop could
have exited and we need a post-loop clean up just to be sure. If the
clean up was not done you would have a stale popup menu referring to
invalid memory, or if not using popup menu, incorrect status line (if
`laststatus=0`).
For example, if you hit `<Esc>` two times when it's wildchar, there's a
hard-coded behavior to exit command-line as a failsafe for user, and if
you hit `<C-\><C-\><C-N>` it will also exit command-line, but the clean
up code would not have hit because of specialized `<C-\>` handling.
Fix Ctrl-E / Ctrl-Y to not cancel/accept wildmenu if they are also
used for 'wildchar'/'wildcharm'. Currently they don't behave properly,
and also have potentially memory unsafe behavior as the logic is
currently not accounting for this situation and try to do both.
(Previous patch that addressed this: #11677)
Also, correctly document Escape key behavior (double-hit it to escape)
in wildchar docs as it's previously undocumented.
In addition, block known invalid chars to be set in `wildchar` option,
such as Ctrl-C and `<CR>`. This is just to make it clear to the user
they shouldn't be set, and is not required for this bug fix.
closes: #13361
Signed-off-by: Christian Brabandt <cb@256bit.org>
Co-authored-by: Yee Cheng Chin <ychin.git@gmail.com>
author | Christian Brabandt <cb@256bit.org> |
---|---|
date | Tue, 17 Oct 2023 10:15:08 +0200 |
parents | 93c715c63a4a |
children | 4635e43f2c6f |
line wrap: on
line source
README_os390.txt for version 9.0 of Vim: Vi IMproved. This readme explains how to build Vim on z/OS. Formerly called OS/390. See "README.txt" for general information about Vim. Most likely there are not many users out there using Vim on z/OS. So chances are good, that some bugs are still undiscovered. Getting the source to z/OS: ========================== First get the source code in one big tar file and ftp it a binary to z/OS. If the tar file is initially compressed with gzip (tar.gz) or bzip2 (tar.bz2) uncompress it on your PC, as these tools are (most likely) not available on the mainframe. To reduce the size of the tar file you might compress it into a zip file. On z/OS Unix you might have the command "jar" from java to uncompress a zip. Use: jar xvf <zip file name> Unpack the tar file on z/OS with pax -o from=ISO8859-1,to=IBM-1047 -rf vim.tar Note: The Vim source contains a few bitmaps etc which will be destroyed by this command, but these files are not needed on zOS (at least not for the console version). Compiling: ========== Vim can be compiled with or without GUI support. For 7.4 only the compilation without GUI was tested. Below is a section about compiling with X11 but this is from an earlier version of Vim. Console only: ------------- If you build VIM without X11 support, compiling and building is nearly straightforward. Change to the vim directory and do: # Don't use c89! # Allow intermixing of compiler options and files. $ export CC=cc $ export _CC_CCMODE=1 $./configure --with-features=normal --without-x --enable-gui=no $ cd src $ make There may be warnings: - include files not found (libc, sys/param.h, ...) - Redeclaration of ... differs from ... -- just ignore them. $ make test This will produce lots of garbage on your screen (including error messages). Don't worry. If the test stops at one point in vim (might happen in test 11), just press :q! Expected test failures: 11: If you don't have gzip installed 24: test of backslash sequences in regexp are ASCII dependent 42: Multibyte is not supported on z/OS 55: ASCII<->EBCDIC sorting 57: ASCII<->EBCDIC sorting 58: Spell checking is not supported with EBCDIC 71: Blowfish encryption doesn't work $ make install With X11: --------- WARNING: This instruction was not tested with Vim 7.4 or later. There are two ways for building VIM with X11 support. The first way is simple and results in a big executable (~13 Mb), the second needs a few additional steps and results in a much smaller executable (~4.5 Mb). These examples assume you want Motif. The easy way: $ export CC=cc $ export _CC_CCMODE=1 $ ./configure --enable-max-features --enable-gui=motif $ cd src $ make With this VIM is linked statically with the X11 libraries. The smarter way: Make VIM as described above. Then create a file named 'link.sed' with the following content (see src/link.390): s/-lXext *//g s/-lXmu *//g s/-lXm */\/usr\/lib\/Xm.x /g s/-lX11 */\/usr\/lib\/X11.x /g s/-lXt *//g s/-lSM */\/usr\/lib\/SM.x /g s/-lICE */\/usr\/lib\/ICE.x /g Then do: $ rm vim $ make Now Vim is linked with the X11-DLLs. See the Makefile and the file link.sh on how link.sed is used.