Mercurial > vim
view nsis/README.txt @ 33262:6eac4f616293 v9.0.1899
patch 9.0.1899: potential buffer overflow in PBYTE macro
Commit: https://github.com/vim/vim/commit/ffb13674d1af1c90beb229867ec989e4fb232df3
Author: Christian Brabandt <cb@256bit.org>
Date: Fri Sep 15 20:22:02 2023 +0200
patch 9.0.1899: potential buffer overflow in PBYTE macro
Problem: potential buffer overflow in PBYTE macro
Solution: Check returned memline length
closes: #13083
the PBYTE macro is used to put byte c at a position lp of the returned
memline. However, in case of unexpected errors ml_get_buf() may return
either "???" or an empty line in which case it is quite likely that we
are causing a buffer overrun.
Therefore, switch the macro PBYTE (which is only used in ops.c anyhow)
to a function, that verifies that we will only try to access within the
given length of the buffer.
Also, since the macro is only used in ops.c, move the definition from
macros.h to ops.c
Signed-off-by: Christian Brabandt <cb@256bit.org>
author | Christian Brabandt <cb@256bit.org> |
---|---|
date | Fri, 15 Sep 2023 20:30:07 +0200 |
parents | 238f424acc6c |
children | d91ac228d7df |
line wrap: on
line source
This builds a one-click install for Vim for Win32 using the Nullsoft Installation System (NSIS), available at http://nsis.sourceforge.net/ To build the installable .exe: 1. Unpack three archives: PC sources PC runtime PC language files You can generate these from the Unix sources and runtime plus the extra archive (see the Makefile in the top directory). 2. Go to the src directory and build: gvim.exe (the OLE version), vimrun.exe, install.exe, uninstall.exe, tee/tee.exe, xxd/xxd.exe, Then execute tools/rename.bat to rename the executables. (mv command is required.) 3. Go to the GvimExt directory and build gvimext.dll (or get it from a binary archive). Both 64- and 32-bit versions are needed and should be placed as follows: 64-bit: src/GvimExt/gvimext64.dll 32-bit: src/GvimExt/gvimext.dll 4. Get a "diff.exe" program. If you skip this the built-in diff will always be used (which is fine for most users). If you do have your own "diff.exe" put it in the "../.." directory (above the "vim90" directory, it's the same for all Vim versions). You can find one in previous Vim versions or in this archive: http://www.mossbayeng.com/~ron/vim/diffutils.tar.gz 5 Also put winpty32.dll and winpty-agent.exe in "../.." (above the "vim90" directory). This is required for the terminal window. 6. Do "make uganda.nsis.txt" in runtime/doc. This requires sed, you may have to do this on Unix. Make sure the file is in DOS file format! 7. Get gettext and iconv DLLs from the following site: https://github.com/mlocati/gettext-iconv-windows/releases Both 64- and 32-bit versions are needed. Download the files gettextX.X.X.X-iconvX.XX-shared-{32,64}.zip, extract DLLs and place them as follows: <GETTEXT directory> | + gettext32/ | libintl-8.dll | libiconv-2.dll | libgcc_s_sjlj-1.dll | ` gettext64/ libintl-8.dll libiconv-2.dll The default <GETTEXT directory> is "..", however, you can change it by passing /DGETTEXT=... option to the makensis command. Install NSIS if you didn't do that already. Also install UPX, if you want a compressed file. Download and include the ShellExecAsUser.dll Unicode version which can be sourced from: https://nsis.sourceforge.io/ShellExecAsUser_plug-in Unpack the images: cd nsis unzip icons.zip Then build gvim.exe: cd nsis makensis gvim.nsi