Mercurial > vim
view .cirrus.yml @ 33262:6eac4f616293 v9.0.1899
patch 9.0.1899: potential buffer overflow in PBYTE macro
Commit: https://github.com/vim/vim/commit/ffb13674d1af1c90beb229867ec989e4fb232df3
Author: Christian Brabandt <cb@256bit.org>
Date: Fri Sep 15 20:22:02 2023 +0200
patch 9.0.1899: potential buffer overflow in PBYTE macro
Problem: potential buffer overflow in PBYTE macro
Solution: Check returned memline length
closes: #13083
the PBYTE macro is used to put byte c at a position lp of the returned
memline. However, in case of unexpected errors ml_get_buf() may return
either "???" or an empty line in which case it is quite likely that we
are causing a buffer overrun.
Therefore, switch the macro PBYTE (which is only used in ops.c anyhow)
to a function, that verifies that we will only try to access within the
given length of the buffer.
Also, since the macro is only used in ops.c, move the definition from
macros.h to ops.c
Signed-off-by: Christian Brabandt <cb@256bit.org>
author | Christian Brabandt <cb@256bit.org> |
---|---|
date | Fri, 15 Sep 2023 20:30:07 +0200 |
parents | 6c1d29d45734 |
children | 267308bfae50 |
line wrap: on
line source
env: CIRRUS_CLONE_DEPTH: 3 FEATURES: huge freebsd_task: name: FreeBSD matrix: - name: FreeBSD 14.0 freebsd_instance: image_family: freebsd-14-0 - name: FreeBSD 13.1 freebsd_instance: image_family: freebsd-13-1 timeout_in: 20m install_script: - pkg install -y gettext build_script: - NPROC=$(getconf _NPROCESSORS_ONLN) - ./configure --with-features=${FEATURES} - make -j${NPROC} test_script: - src/vim --version # run tests as user "cirrus" instead of root - pw useradd cirrus -m - chown -R cirrus:cirrus . - sudo -u cirrus make test macos_task: name: macOS m1 macos_instance: image: ghcr.io/cirruslabs/macos-ventura-xcode:latest env: # only run with clang, gcc is not real, it is a link to clang CC: clang timeout_in: 20m install_script: - brew update - brew install gettext libtool diffutils build_script: - NPROC=$(getconf _NPROCESSORS_ONLN) - ./configure --with-features=${FEATURES} - make -j${NPROC} test_script: - src/vim --version - make test