Mercurial > vim
view runtime/autoload/bitbake.vim @ 33947:f4d88db48a63 v9.0.2168
patch 9.0.2168: Moving tabpages on :drop may cause an endless loop
Commit: https://github.com/vim/vim/commit/df12e39b8b9dd39056e22b452276622cb7b617fd
Author: Christian Brabandt <cb@256bit.org>
Date: Sat Dec 16 13:55:32 2023 +0100
patch 9.0.2168: Moving tabpages on :drop may cause an endless loop
Problem: Moving tabpages on :drop may cause an endless loop
Solution: Disallow moving tabpages on :drop when cleaning up the arglist
first
Moving tabpages during drop command may cause an endless loop
When executing a :tab drop command, Vim will close all windows not in
the argument list. This triggers various autocommands. If a user has
created an 'au Tabenter * :tabmove -' autocommand, this can cause Vim to
end up in an endless loop, when trying to iterate over all tabs (which
would trigger the tabmove autocommand, which will change the tpnext
pointer, etc).
So instead of blocking all autocommands before we actually try to edit
the given file, lets simply disallow to move tabpages around. Otherwise,
we may change the expected number of events triggered during a :drop
command, which users may rely on (there is actually a test, that expects
various TabLeave/TabEnter autocommands) and would therefore be a
backwards incompatible change.
Don't make this an error, as this could trigger several times during the
drop command, but silently ignore the :tabmove command in this case (and
it should in fact finally trigger successfully when loading the given
file in a new tab). So let's just be quiet here instead.
fixes: #13676
closes: #13686
Signed-off-by: Christian Brabandt <cb@256bit.org>
author | Christian Brabandt <cb@256bit.org> |
---|---|
date | Sat, 16 Dec 2023 14:00:05 +0100 |
parents | 67f31c24291b |
children |
line wrap: on
line source
" Support for bitbake indenting, see runtime/indent/bitbake.vim function s:is_bb_python_func_def(lnum) let stack = synstack(a:lnum, 1) if len(stack) == 0 return 0 endif return synIDattr(stack[0], "name") == "bbPyFuncDef" endfunction function bitbake#Indent(lnum) if !has('syntax_items') return -1 endif let stack = synstack(a:lnum, 1) if len(stack) == 0 return -1 endif let name = synIDattr(stack[0], "name") " TODO: support different styles of indentation for assignments. For now, " we only support like this: " VAR = " \ " value1 \ " value2 \ " " " " i.e. each value indented by shiftwidth(), with the final quote " completely unindented. if name == "bbVarValue" " Quote handling is tricky. kernel.bbclass has this line for instance: " EXTRA_OEMAKE = " HOSTCC="${BUILD_CC} ${BUILD_CFLAGS} ${BUILD_LDFLAGS}" " HOSTCPP="${BUILD_CPP}"" " Instead of trying to handle crazy cases like that, just assume that a " double-quote on a line by itself (following an assignment) means the " user is closing the assignment, and de-dent. if getline(a:lnum) =~ '^\s*"$' return 0 endif let prevstack = synstack(a:lnum - 1, 1) if len(prevstack) == 0 return -1 endif let prevname = synIDattr(prevstack[0], "name") " Only indent if there was actually a continuation character on " the previous line, to avoid misleading indentation. let prevlinelastchar = synIDattr(synID(a:lnum - 1, col([a:lnum - 1, "$"]) - 1, 1), "name") let prev_continued = prevlinelastchar == "bbContinue" " Did the previous line introduce an assignment? if index(["bbVarDef", "bbVarFlagDef"], prevname) != -1 if prev_continued return shiftwidth() endif endif if !prev_continued return 0 endif " Autoindent can take it from here return -1 endif if index(["bbPyDefRegion", "bbPyFuncRegion"], name) != -1 let ret = python#GetIndent(a:lnum, function('s:is_bb_python_func_def')) " Should normally always be indented by at least one shiftwidth; but allow " return of -1 (defer to autoindent) or -2 (force indent to 0) if ret == 0 return shiftwidth() elseif ret == -2 return 0 endif return ret endif " TODO: GetShIndent doesn't detect tasks prepended with 'fakeroot' " Need to submit a patch upstream to Vim to provide an extension point. " Unlike the Python indenter, the Sh indenter is way too large to copy and " modify here. if name == "bbShFuncRegion" return GetShIndent() endif " TODO: " + heuristics for de-denting out of a bbPyDefRegion? e.g. when the user " types an obvious BB keyword like addhandler or addtask, or starts " writing a shell task. Maybe too hard to implement... return -1 endfunction