Mercurial > vim
view runtime/doc/doctags.c @ 34548:db67c09ccd53 v9.1.0175
patch 9.1.0175: wrong window positions with 'winfix{width,height}'
Commit: https://github.com/vim/vim/commit/5866bc3a0f54115d5982fdc09bdbe4c45069265a
Author: Sean Dewar <6256228+seandewar@users.noreply.github.com>
Date: Wed Mar 13 20:17:24 2024 +0100
patch 9.1.0175: wrong window positions with 'winfix{width,height}'
Problem: winframe functions incorrectly recompute window positions if
the altframe wasn't adjacent to the closed frame, which is
possible if adjacent windows had 'winfix{width,height}' set.
Solution: recompute for windows within the parent of the altframe and
closed frame. Skip this (as before) if the altframe was
top/left, but only if adjacent to the closed frame, as
positions won't change in that case. Also correct the return
value documentation for win_screenpos. (Sean Dewar)
The issue revealed itself after removing the win_comp_pos call below
winframe_restore in win_splitmove. Similarly, wrong positions could result from
windows closed in other tabpages, as win_free_mem uses winframe_remove (at least
until it is entered later, where enter_tabpage calls win_comp_pos).
NOTE: As win_comp_pos handles only curtab, it's possible via other means for
positions in non-current tabpages to be wrong (e.g: after changing 'laststatus',
'showtabline', etc.). Given enter_tabpage recomputes it, maybe it's intentional
as an optimization? Should probably be documented in win_screenpos then, but I
won't address that here.
closes: #14191
Signed-off-by: Sean Dewar <6256228+seandewar@users.noreply.github.com>
Signed-off-by: Christian Brabandt <cb@256bit.org>
author | Christian Brabandt <cb@256bit.org> |
---|---|
date | Wed, 13 Mar 2024 20:30:03 +0100 |
parents | af4ffc4b2a26 |
children |
line wrap: on
line source
/* vim:set ts=4 sw=4: * * This program makes a tags file for help text. * * Usage: doctags *.txt ... >tags * * A tag in this context is an identifier between stars, e.g. *c_files* */ #include <stdio.h> #include <string.h> #include <ctype.h> #include <stdlib.h> #define LINELEN 200 int main(int argc, char **argv) { char line[LINELEN]; char *p1, *p2; char *p; FILE *fd; int len; int in_example; if (argc <= 1) { fprintf(stderr, "Usage: doctags docfile ... >tags\n"); exit(1); } printf("help-tags\ttags\t1\n"); while (--argc > 0) { ++argv; fd = fopen(argv[0], "r"); if (fd == NULL) { fprintf(stderr, "Unable to open %s for reading\n", argv[0]); continue; } in_example = 0; while (fgets(line, LINELEN, fd) != NULL) { if (in_example) { // skip over example; non-blank in first column ends example if (strchr(" \t\n\r", line[0]) != NULL) continue; in_example = 0; } p1 = strchr(line, '*'); // find first '*' while (p1 != NULL) { p2 = strchr(p1 + 1, '*'); // find second '*' if (p2 != NULL && p2 > p1 + 1) // skip "*" and "**" { for (p = p1 + 1; p < p2; ++p) if (*p == ' ' || *p == '\t' || *p == '|') break; // Only accept a *tag* when it consists of valid // characters, there is white space before it and is // followed by a white character or end-of-line. if (p == p2 && (p1 == line || p1[-1] == ' ' || p1[-1] == '\t') && (strchr(" \t\n\r", p[1]) != NULL || p[1] == '\0')) { *p2 = '\0'; ++p1; printf("%s\t%s\t/*", p1, argv[0]); while (*p1) { // insert backslash before '\\' and '/' if (*p1 == '\\' || *p1 == '/') putchar('\\'); putchar(*p1); ++p1; } printf("*\n"); p2 = strchr(p2 + 1, '*'); // find next '*' } } p1 = p2; } len = strlen(line); if ((len == 2 && strcmp(&line[len - 2], ">\n") == 0) || (len >= 3 && strcmp(&line[len - 3], " >\n") == 0)) in_example = 1; } fclose(fd); } return 0; }