Mercurial > vim
view runtime/indent/testdir/vim.in @ 32936:c517845bd10e v9.0.1776
patch 9.0.1776: No support for stable Python 3 ABI
Commit: https://github.com/vim/vim/commit/c13b3d1350b60b94fe87f0761ea31c0e7fb6ebf3
Author: Yee Cheng Chin <ychin.git@gmail.com>
Date: Sun Aug 20 21:18:38 2023 +0200
patch 9.0.1776: No support for stable Python 3 ABI
Problem: No support for stable Python 3 ABI
Solution: Support Python 3 stable ABI
Commits:
1) Support Python 3 stable ABI to allow mixed version interoperatbility
Vim currently supports embedding Python for use with plugins, and the
"dynamic" linking option allows the user to specify a locally installed
version of Python by setting `pythonthreedll`. However, one caveat is
that the Python 3 libs are not binary compatible across minor versions,
and mixing versions can potentially be dangerous (e.g. let's say Vim was
linked against the Python 3.10 SDK, but the user sets `pythonthreedll`
to a 3.11 lib). Usually, nothing bad happens, but in theory this could
lead to crashes, memory corruption, and other unpredictable behaviors.
It's also difficult for the user to tell something is wrong because Vim
has no way of reporting what Python 3 version Vim was linked with.
For Vim installed via a package manager, this usually isn't an issue
because all the dependencies would already be figured out. For prebuilt
Vim binaries like MacVim (my motivation for working on this), AppImage,
and Win32 installer this could potentially be an issue as usually a
single binary is distributed. This is more tricky when a new Python
version is released, as there's a chicken-and-egg issue with deciding
what Python version to build against and hard to keep in sync when a new
Python version just drops and we have a mix of users of different Python
versions, and a user just blindly upgrading to a new Python could lead to
bad interactions with Vim.
Python 3 does have a solution for this problem: stable ABI / limited API
(see https://docs.python.org/3/c-api/stable.html). The C SDK limits the
API to a set of functions that are promised to be stable across
versions. This pull request adds an ifdef config that allows us to turn
it on when building Vim. Vim binaries built with this option should be
safe to freely link with any Python 3 libraies without having the
constraint of having to use the same minor version.
Note: Python 2 has no such concept and this doesn't change how Python 2
integration works (not that there is going to be a new version of Python
2 that would cause compatibility issues in the future anyway).
---
Technical details:
======
The stable ABI can be accessed when we compile with the Python 3 limited
API (by defining `Py_LIMITED_API`). The Python 3 code (in `if_python3.c`
and `if_py_both.h`) would now handle this and switch to limited API
mode. Without it set, Vim will still use the full API as before so this
is an opt-in change.
The main difference is that `PyType_Object` is now an opaque struct that
we can't directly create "static types" out of, and we have to create
type objects as "heap types" instead. This is because the struct is not
stable and changes from version to version (e.g. 3.8 added a
`tp_vectorcall` field to it). I had to change all the types to be
allocated on the heap instead with just a pointer to them.
Other functions are also simply missing in limited API, or they are
introduced too late (e.g. `PyUnicode_AsUTF8AndSize` in 3.10) to it that
we need some other ways to do the same thing, so I had to abstract a few
things into macros, and sometimes re-implement functions like
`PyObject_NEW`.
One caveat is that in limited API, `OutputType` (used for replacing
`sys.stdout`) no longer inherits from `PyStdPrinter_Type` which I don't
think has any real issue other than minor differences in how they
convert to a string and missing a couple functions like `mode()` and
`fileno()`.
Also fixed an existing bug where `tp_basicsize` was set incorrectly for
`BufferObject`, `TabListObject, `WinListObject`.
Technically, there could be a small performance drop, there is a little
more indirection with accessing type objects, and some APIs like
`PyUnicode_AsUTF8AndSize` are missing, but in practice I didn't see any
difference, and any well-written Python plugin should try to avoid
excessing callbacks to the `vim` module in Python anyway.
I only tested limited API mode down to Python 3.7, which seemes to
compile and work fine. I haven't tried earlier Python versions.
2) Fix PyIter_Check on older Python vers / type##Ptr unused warning
For PyIter_Check, older versions exposed them as either macros (used in
full API), or a function (for use in limited API). A previous change
exposed PyIter_Check to the dynamic build because Python just moved it
to function-only in 3.10 anyway. Because of that, just make sure we
always grab the function in dynamic builds in earlier versions since
that's what Python eventually did anyway.
3) Move Py_LIMITED_API define to configure script
Can now use --with-python-stable-abi flag to customize what stable ABI
version to target. Can also use an env var to do so as well.
4) Show +python/dyn-stable in :version, and allow has() feature query
Not sure if the "/dyn-stable" suffix would break things, or whether we
should do it another way. Or just don't show it in version and rely on
has() feature checking.
5) Documentation first draft. Still need to implement v:python3_version
6) Fix PyIter_Check build breaks when compiling against Python 3.8
7) Add CI coverage stable ABI on Linux/Windows / make configurable on Windows
This adds configurable options for Windows make files (both MinGW and
MSVC). CI will also now exercise both traditional full API and stable
ABI for Linux and Windows in the matrix for coverage.
Also added a "dynamic" option to Linux matrix as a drive-by change to
make other scripting languages like Ruby / Perl testable under both
static and dynamic builds.
8) Fix inaccuracy in Windows docs
Python's own docs are confusing but you don't actually want to use
`python3.dll` for the dynamic linkage.
9) Add generated autoconf file
10) Add v:python3_version support
This variable indicates the version of Python3 that Vim was built
against (PY_VERSION_HEX), and will be useful to check whether the Python
library you are loading in dynamically actually fits it. When built with
stable ABI, it will be the limited ABI version instead
(`Py_LIMITED_API`), which indicates the minimum version of Python 3 the
user should have, rather than the exact match. When stable ABI is used,
we won't be exposing PY_VERSION_HEX in this var because it just doesn't
seem necessary to do so (the whole point of stable ABI is the promise
that it will work across versions), and I don't want to confuse the user
with too many variables.
Also, cleaned up some documentation, and added help tags.
11) Fix Python 3.7 compat issues
Fix a couple issues when using limited API < 3.8
- Crash on exit: In Python 3.7, if a heap-allocated type is destroyed
before all instances are, it would cause a crash later. This happens
when we destroyed `OptionsType` before calling `Py_Finalize` when
using the limited API. To make it worse, later versions changed the
semantics and now each instance has a strong reference to its own type
and the recommendation has changed to have each instance de-ref its
own type and have its type in GC traversal. To avoid dealing with
these cross-version variations, we just don't free the heap type. They
are static types in non-limited-API anyway and are designed to last
through the entirety of the app, and we also don't restart the Python
runtime and therefore do not need it to have absolutely 0 leaks.
See:
- https://docs.python.org/3/whatsnew/3.8.html#changes-in-the-c-api
- https://docs.python.org/3/whatsnew/3.9.html#changes-in-the-c-api
- PyIter_Check: This function is not provided in limited APIs older than
3.8. Previously I was trying to mock it out using manual
PyType_GetSlot() but it was brittle and also does not actually work
properly for static types (it will generate a Python error). Just
return false. It does mean using limited API < 3.8 is not recommended
as you lose the functionality to handle iterators, but from playing
with plugins I couldn't find it to be an issue.
- Fix loading of PyIter_Check so it will be done when limited API < 3.8.
Otherwise loading a 3.7 Python lib will fail even if limited API was
specified to use it.
12) Make sure to only load `PyUnicode_AsUTF8AndSize` in needed in limited API
We don't use this function unless limited API >= 3.10, but we were
loading it regardless. Usually it's ok in Unix-like systems where Python
just has a single lib that we load from, but in Windows where there is a
separate python3.dll this would not work as the symbol would not have
been exposed in this more limited DLL file. This makes it much clearer
under what condition is this function needed.
closes: #12032
Signed-off-by: Christian Brabandt <cb@256bit.org>
Co-authored-by: Yee Cheng Chin <ychin.git@gmail.com>
author | Christian Brabandt <cb@256bit.org> |
---|---|
date | Sun, 20 Aug 2023 21:30:04 +0200 |
parents | 94f4a488412e |
children | 5b46a975e48a |
line wrap: on
line source
" vim: set ft=vim sw=4 : " START_INDENT func Some() let x = 1 endfunc let cmd = \ 'some ' \ 'string' if 1 let x = [ \ ] endif for x in [ {key: 'value'}, ] eval 0 endfor let t = [ \ { \ 'k': 'val', \ }, \ ] def Func() var d = dd ->extend({ }) eval 0 enddef " END_INDENT " START_INDENT " INDENT_EXE let g:vim_indent_cont = 6 let cmd = \ 'some ' \ 'string' " END_INDENT " START_INDENT " INDENT_EXE let g:vim_indent_cont = 5 let list = [ \ 'one', \ 'two'] " END_INDENT " START_INDENT " INDENT_EXE unlet g:vim_indent_cont let list = [ 'one', 'two', ] echo " END_INDENT " START_INDENT " INDENT_AT this-line func Some() let f = x " this-line endfunc " END_INDENT " START_INDENT " INDENT_NEXT next-line func Some() " next-line let f = x endfunc " END_INDENT " START_INDENT " INDENT_PREV prev-line func Some() let f = x " prev-line endfunc " END_INDENT " START_INDENT let a =<< END nothing END " END_INDENT " START_INDENT let a =<< trim END nothing END " END_INDENT " START_INDENT " INDENT_AT this-line let a=<< trim END blah blah blah this-line END " END_INDENT " START_INDENT if v:true echo 0 end " END_INDENT " START_INDENT var result = Func( arg1, arg2 ) " END_INDENT " START_INDENT var result = Func(arg1, arg2) " END_INDENT " START_INDENT filter(list, (k, v) => v > 0) " END_INDENT " START_INDENT filter(list, (k, v) => { const x = get(list, k, 0) return x > 0 }) " END_INDENT " START_INDENT if x > 0 filter(list, (k, v) => { const x = get(list, k, 1) return x > 0 }) endif " END_INDENT " START_INDENT { var temp = 'temp' } " END_INDENT " START_INDENT var text = lead .. middle .. end " END_INDENT " START_INDENT var text = lead .. middle .. end " END_INDENT " START_INDENT var total = start + end - correction " END_INDENT " START_INDENT var result = start :+ print " END_INDENT " START_INDENT var result = positive ? PosFunc(arg) : NegFunc(arg) " END_INDENT " START_INDENT var result = GetBuilder() ->BuilderSetWidth(333) ->BuilderSetHeight(777) ->BuilderBuild() " END_INDENT " START_INDENT var result = MyDict .member " END_INDENT " START_INDENT autocmd BufNewFile *.match if condition | echo 'match' | endif " END_INDENT " START_INDENT set cpo+=C var lines =<< trim END | this works END set cpo-=C " END_INDENT " START_INDENT syn region Text \ start='foo' #\ comment \ end='bar' " END_INDENT " START_INDENT au CursorHold * echom 'BEFORE bar' #\ some comment | echom 'AFTER bar' " END_INDENT " START_INDENT def MyFunc(text: string, separator = '-' ): string enddef " END_INDENT " START_INDENT def MyFunc( text: string, separator = '-' ): string enddef " END_INDENT " START_INDENT [var1, var2] = Func() " END_INDENT " START_INDENT const list = ['one', 'two'] " END_INDENT " START_INDENT const list = [ 'one', 'two', ] " END_INDENT " START_INDENT const dict = {one: 1, two: 2 } " END_INDENT " START_INDENT const dict = { one: 1, two: 2 } " END_INDENT " START_INDENT if true const dict = { one: 1, two: 2 } endif " END_INDENT " START_INDENT def Func() return { one: 1 } enddef " END_INDENT " START_INDENT echo { a: 0, # b # c } " END_INDENT " START_INDENT echo search( # comment '1' .. '2' ) " END_INDENT " START_INDENT if true var v = ( # trailing "(" starts line continuation 3 + 4 # nothing special ) # end of expression indicates continued line var x: number # needs to align with previous "var" endif " END_INDENT " START_INDENT def Func() # {{{ # comment if true return endif enddef " END_INDENT " START_INDENT echo { key: 'value', } " END_INDENT " START_INDENT var id = time ->timer_start((_) => { n = 0 }) " END_INDENT " START_INDENT augroup Name autocmd! augroup END " END_INDENT " START_INDENT var n = # comment 1 + 2 var s = '' " END_INDENT " START_INDENT var keys = { J: 'j', "\<Home>": '1G', "\<End>": 'G', z: 'zz' } " END_INDENT " START_INDENT export def Func( n: number, s: string, ...l: list<bool> ) enddef " END_INDENT " START_INDENT var heredoc =<< trim ENDD var nested_heredoc =<< trim END END ENDD " END_INDENT " START_INDENT if true else " comment endif " END_INDENT " START_INDENT if true | echo 'one' | endif if true | echo 'two' | endif if true | echo 'three' | endif " END_INDENT " START_INDENT if true :'<-1 mark < else echo '' endif " END_INDENT " START_INDENT substitute/pat /rep / echo " END_INDENT " START_INDENT try echo 1 catch /pat / # comment echo 2 endtry " END_INDENT " START_INDENT def Func() Cmd % enddef " END_INDENT " START_INDENT if end == 'xxx' || end == 'yyy' echo endif " END_INDENT " START_INDENT if true popup_move(id, {col: 1, line: 2}) endif setwinvar(id, 'name', 3) " END_INDENT " START_INDENT var d = [ {a: 'x', b: 'y'}, FuncA(), FuncB(), ] " END_INDENT " START_INDENT var ll = [[ 1, 2, 3], [ 4, 5, 6], [ 7, 8, 9]] " END_INDENT " START_INDENT var ld = [{ a: 'xxx', b: 'yyy'}, { c: 'xxx', d: 'yyy'}, { e: 'xxx', f: 'yyy'}, { }] " END_INDENT " START_INDENT var d = { a: { b: { c: [{ d: 'e', f: 'g', h: 'i' }], j: 'k', }, }, } " END_INDENT " START_INDENT if true var end: any if true end = 0 elseif true echo endif endif " END_INDENT " START_INDENT if true var d = { end: 0} endif " END_INDENT " START_INDENT nunmap <buffer> ( nunmap <buffer> ) inoremap [ { inoremap ] } silent! xunmap i{ silent! xunmap a{ " END_INDENT " START_INDENT def Func( s: string, n = 1, m = 2 ) enddef " END_INDENT " START_INDENT var h =<< END text END def Func() echo enddef " END_INDENT " START_INDENT def Func() var h =<< END text END echo 'test' enddef " END_INDENT " START_INDENT def Foo() lcd - enddef def Bar() echo enddef " END_INDENT " START_INDENT if true n = Func(1, 2, 3) endif " END_INDENT " START_INDENT def Func(s: string, n: number): bool if true return false endif enddef " END_INDENT " START_INDENT def Func( n: number) # echo enddef " END_INDENT " START_INDENT " INDENT_AT this-line def Func( n: number) # echo # this-line enddef " END_INDENT " START_INDENT if true if true normal! == endif endif " END_INDENT " START_INDENT var d = { a: () => true, b: () => true && true && Foo(), c: () => Bar(), e: () => Baz(), } " END_INDENT " START_INDENT def Select(Cont: func(func(any)), Pred: func(any): bool): func(func(any)) return (Emit: func(any)) => { Cont((t: any) => { if Pred(t) Emit(t) endif }) } enddef " END_INDENT " START_INDENT " INDENT_EXE let g:vim_indent = {'more_in_bracket_block': v:true} def Select(Cont: func(func(any)), Pred: func(any): bool): func(func(any)) return (Emit: func(any)) => { Cont((t: any) => { if Pred(t) Emit(t) endif }) } enddef " END_INDENT " START_INDENT " INDENT_EXE unlet! g:vim_indent " END_INDENT " START_INDENT g:lightline = { 'active': { 'left': [ [ 'mode', 'paste' ], [ 'readonly', 'relativepath', 'modified' ] ], }, 'inactive': { 'left': [ [ 'readonly', 'relativepath', 'modified' ] ], } } " END_INDENT " START_INDENT if getline(1, 10) ->map((_, v: string): number => strcharlen(v)) ->max() > 1'000 &l:breakindent = false &l:linebreak = false else &l:breakindent = true &l:linebreak = true endif " END_INDENT " START_INDENT var ext2cmd: dict<string> = { doc: $'antiword {fname}', docx: $'pandoc --from=docx --to=markdown {fname}', epub: $'pandoc --from=epub --to=markdown {fname}', odp: $'odt2txt {fname}', odt: $'odt2txt {fname}', pdf: $'pdftotext -nopgbrk -layout -q -eol unix {fname} -', rtf: 'unrtf --text', } " END_INDENT " START_INDENT const ptybuf: number = term_start(&shell, { hidden: true, exit_cb: (_, _) => { if true close else help endif } }) " END_INDENT " START_INDENT var d = { a: 0, # a ' quote {{{ #}}} b: 0, } " END_INDENT " START_INDENT echo printf('%s () %s', 1, 2 ) " END_INDENT " START_INDENT prop_add(1, col('.'), { length: 2, type: 'test' }) " END_INDENT " START_INDENT echo (() => " string starting with space")() echo " END_INDENT " START_INDENT var variables = deepcopy(g:) ->filter((k: string, _): bool => k =~ '\c\V' .. keyword->escape('\') && k !~ '\%(loaded\|did_plugin_\)') ->items() ->map((_, v): string => v[0] .. ' = ' .. string(v[1])) new " END_INDENT " START_INDENT var d = freq ->map((_, v) => v * ( 1 + 2 )) for item in d ->items() ->sort((a, b) => b[1] - a[1]) echo endfor " END_INDENT " START_INDENT make_job = job_start([&shell, &shellcmdflag, make_cmd], { callback: function(MakeProcessOutput, [qfid]), close_cb: function(MakeCloseCb, [qfid]), exit_cb: MakeCompleted, in_io: 'null' }) " END_INDENT " START_INDENT var matching_abbrev: list<dict<string>> = copy(ABBREV) ->filter((_, v: dict<string>): bool => stridx(v.lhs, word_to_complete) == 0) ->map((_, v: dict<string>) => ({ word: v.lhs, menu: AbbrevRhs(v.rhs)->stridx('expand_') >= 0 ? AbbrevRhs(v.rhs)->matchstr('.*,\s*''\zs.*\ze'')') : AbbrevRhs(v.rhs) })) " END_INDENT " START_INDENT def Func() if true vimgrep /^\C\s*\%(fu\%[nction]\|def\)\s\+/ file endif enddef " END_INDENT " START_INDENT setlocal iskeyword+=[ cword = expand('<cword>') " END_INDENT " START_INDENT silent if true echo endif " END_INDENT " START_INDENT def Func() sort :^.*[\/]: enddef " END_INDENT " START_INDENT def Func() d = { } hd =<< trim END [' ]' END enddef " END_INDENT " START_INDENT def Func() if true var hd =<< trim END if get(b:, 'current_syntax', '') endif END elseif true echo endif enddef " END_INDENT " START_INDENT # test for control-flow keyword followed by commented fold marker {{{ if true echo endif #}}} " END_INDENT " START_INDENT if winsz == 0|let winsz= ""|endif exe "noswapfile ".winsz."wincmd s" " END_INDENT " START_INDENT if true if true windo if true | echo | endif augroup Name autocmd WinLeave * if true | eval 1 + 2 | endif augroup END endif endif " END_INDENT " START_INDENT if true echo ' =<< trim END' ->len() endif " END_INDENT " START_INDENT function Func() if true if true if true | echo com | endif if true | echo com | endif endif else endif endfunction " END_INDENT " START_INDENT function Func() if v:true + echo - endif endfunction " END_INDENT " START_INDENT var matchpairs: string = &matchpairs var pairs: dict<list<string>> for [opening: string, closing: string] in matchpairs ->split(',') ->map((_, v: string): list<string> => split(v, ':')) pairs[opening] = [escape(opening, '[]'), escape(closing, '[]'), 'nW', 'w$'] pairs[closing] = [escape(opening, '[]'), escape(closing, '[]'), 'bnW', 'w0'] endfor " END_INDENT " START_INDENT { echo [] + [] + [{a: 1, b: 2}] } " END_INDENT " START_INDENT silent! argdel * edit file " END_INDENT " START_INDENT def Foo() Bar(1, []->filter((_, v) => { return true }), () => { echo }) enddef " END_INDENT " START_INDENT echo { k: () => { if true echo popup_setoptions(id, {title: 'title'}) endif } } " END_INDENT " START_INDENT if true elseif endif " END_INDENT " START_INDENT if ( true) && true echo endif " END_INDENT " START_INDENT abstract class Shape this.color = Color.Black this.thickness = 10 endclass " END_INDENT " START_INDENT class OtherThing this.size: number static totalSize: number static def ClearTotalSize(): number var prev = totalSize totalSize = 0 return prev enddef endclass " END_INDENT " START_INDENT interface HasSurface this.size: number def Surface(): number endinterface " END_INDENT " START_INDENT interface EnterExit def Enter(): void def Exit(): void endinterface " END_INDENT " START_INDENT enum Color White Red Green Blue Black endenum " END_INDENT