Mercurial > vim
view src/testdir/test_windows_home.vim @ 34194:a522c6c0127b v9.1.0047
patch 9.1.0047: issues with temp curwin/buf while cmdwin is open
Commit: https://github.com/vim/vim/commit/988f74311c26ea9917e84fbae608de226dba7e5f
Author: Sean Dewar <seandewar@users.noreply.github.com>
Date: Wed Aug 16 14:17:36 2023 +0100
patch 9.1.0047: issues with temp curwin/buf while cmdwin is open
Problem: Things that temporarily change/restore curwin/buf (e.g:
win_execute, some autocmds) may break assumptions that
curwin/buf is the cmdwin when "cmdwin_type != 0", causing
issues.
Solution: Expose the cmdwin's real win/buf and check that instead. Also
try to ensure these variables are NULL if "cmdwin_type == 0",
allowing them to be used directly in most cases without
checking cmdwin_type. (Sean Dewar)
Alternatively, we could ban win_execute in the cmdwin and audit all places that
temporarily change/restore curwin/buf, but I didn't notice any problems arising
from allowing this (standard cmdwin restrictions still apply, so things that may
actually break the cmdwin are still forbidden).
closes: #12819
Signed-off-by: Sean Dewar <seandewar@users.noreply.github.com>
Signed-off-by: Christian Brabandt <cb@256bit.org>
author | Christian Brabandt <cb@256bit.org> |
---|---|
date | Tue, 23 Jan 2024 23:00:04 +0100 |
parents | 08940efa6b4e |
children | 1ee567e88a22 |
line wrap: on
line source
" Test for $HOME on Windows. source check.vim CheckMSWindows let s:env = {} func s:restore_env() for i in keys(s:env) exe 'let ' . i . '=s:env["' . i . '"]' endfor endfunc func s:save_env(...) for i in a:000 exe 'let s:env["' . i . '"]=' . i endfor endfunc func s:unlet_env(...) for i in a:000 exe 'let ' . i . '=""' endfor endfunc func CheckHomeIsMissingFromSubprocessEnvironment() silent! let out = system('set') let env = filter(split(out, "\n"), 'v:val=~"^HOME="') call assert_equal(0, len(env)) endfunc func CheckHomeIsInSubprocessEnvironment(exp) silent! let out = system('set') let env = filter(split(out, "\n"), 'v:val=~"^HOME="') let home = len(env) == 0 ? "" : substitute(env[0], '[^=]\+=', '', '') call assert_equal(a:exp, home) endfunc func CheckHome(exp, ...) call assert_equal(a:exp, $HOME) call assert_equal(a:exp, expand('~', ':p')) if !a:0 call CheckHomeIsMissingFromSubprocessEnvironment() else call CheckHomeIsInSubprocessEnvironment(a:1) endif endfunc func Test_WindowsHome() command! -nargs=* SaveEnv call <SID>save_env(<f-args>) command! -nargs=* RestoreEnv call <SID>restore_env() command! -nargs=* UnletEnv call <SID>unlet_env(<f-args>) set noshellslash let save_home = $HOME SaveEnv $USERPROFILE $HOMEDRIVE $HOMEPATH try " Normal behavior: use $HOMEDRIVE and $HOMEPATH, ignore $USERPROFILE let $USERPROFILE = 'unused' let $HOMEDRIVE = 'C:' let $HOMEPATH = '\foobar' let $HOME = '' " Force recomputing "homedir" call CheckHome('C:\foobar') " Same, but with $HOMEPATH not set UnletEnv $HOMEPATH let $HOME = '' " Force recomputing "homedir" call CheckHome('C:\') " Use $USERPROFILE if $HOMEPATH and $HOMEDRIVE are empty UnletEnv $HOMEDRIVE $HOMEPATH let $USERPROFILE = 'C:\foo' let $HOME = '' " Force recomputing "homedir" call CheckHome('C:\foo') " If $HOME is set the others don't matter let $HOME = 'C:\bar' let $USERPROFILE = 'unused' let $HOMEDRIVE = 'unused' let $HOMEPATH = 'unused' call CheckHome('C:\bar', 'C:\bar') " If $HOME contains %USERPROFILE% it is expanded let $USERPROFILE = 'C:\foo' let $HOME = '%USERPROFILE%\bar' let $HOMEDRIVE = 'unused' let $HOMEPATH = 'unused' call CheckHome('C:\foo\bar', '%USERPROFILE%\bar') " Invalid $HOME is kept let $USERPROFILE = 'C:\foo' let $HOME = '%USERPROFILE' let $HOMEDRIVE = 'unused' let $HOMEPATH = 'unused' call CheckHome('%USERPROFILE', '%USERPROFILE') " %USERPROFILE% not at start of $HOME is not expanded let $USERPROFILE = 'unused' let $HOME = 'C:\%USERPROFILE%' let $HOMEDRIVE = 'unused' let $HOMEPATH = 'unused' call CheckHome('C:\%USERPROFILE%', 'C:\%USERPROFILE%') if has('channel') RestoreEnv let $HOME = save_home let env = '' let job = job_start('cmd /c set', {'out_cb': {ch,x->[env,execute('let env=x')]}}) sleep 1 let env = filter(split(env, "\n"), 'v:val=="HOME"') let home = len(env) == 0 ? "" : env[0] call assert_equal('', home) endif finally RestoreEnv delcommand SaveEnv delcommand RestoreEnv delcommand UnletEnv endtry endfunc " vim: shiftwidth=2 sts=2 expandtab