Mercurial > vim
view src/testdir/test_preview.vim @ 34194:a522c6c0127b v9.1.0047
patch 9.1.0047: issues with temp curwin/buf while cmdwin is open
Commit: https://github.com/vim/vim/commit/988f74311c26ea9917e84fbae608de226dba7e5f
Author: Sean Dewar <seandewar@users.noreply.github.com>
Date: Wed Aug 16 14:17:36 2023 +0100
patch 9.1.0047: issues with temp curwin/buf while cmdwin is open
Problem: Things that temporarily change/restore curwin/buf (e.g:
win_execute, some autocmds) may break assumptions that
curwin/buf is the cmdwin when "cmdwin_type != 0", causing
issues.
Solution: Expose the cmdwin's real win/buf and check that instead. Also
try to ensure these variables are NULL if "cmdwin_type == 0",
allowing them to be used directly in most cases without
checking cmdwin_type. (Sean Dewar)
Alternatively, we could ban win_execute in the cmdwin and audit all places that
temporarily change/restore curwin/buf, but I didn't notice any problems arising
from allowing this (standard cmdwin restrictions still apply, so things that may
actually break the cmdwin are still forbidden).
closes: #12819
Signed-off-by: Sean Dewar <seandewar@users.noreply.github.com>
Signed-off-by: Christian Brabandt <cb@256bit.org>
author | Christian Brabandt <cb@256bit.org> |
---|---|
date | Tue, 23 Jan 2024 23:00:04 +0100 |
parents | 457ea0570b6f |
children |
line wrap: on
line source
" Tests for the preview window source check.vim CheckFeature quickfix func Test_Psearch() " this used to cause ml_get errors help let wincount = winnr('$') 0f ps. call assert_equal(wincount + 1, winnr('$')) pclose call assert_equal(wincount, winnr('$')) bwipe endfunc func Test_window_preview() CheckFeature quickfix " Open a preview window pedit Xa call assert_equal(2, winnr('$')) call assert_equal(0, &previewwindow) " Go to the preview window wincmd P call assert_equal(1, &previewwindow) call assert_equal('preview', win_gettype()) " Close preview window wincmd z call assert_equal(1, winnr('$')) call assert_equal(0, &previewwindow) call assert_fails('wincmd P', 'E441:') endfunc func Test_window_preview_from_help() CheckFeature quickfix filetype on call writefile(['/* some C code */'], 'Xpreview.c', 'D') help pedit Xpreview.c wincmd P call assert_equal(1, &previewwindow) call assert_equal('c', &filetype) wincmd z filetype off close endfunc func Test_multiple_preview_windows() new set previewwindow new call assert_fails('set previewwindow', 'E590:') %bw! endfunc " vim: shiftwidth=2 sts=2 expandtab