Mercurial > vim
view src/testdir/test_exec_while_if.vim @ 34194:a522c6c0127b v9.1.0047
patch 9.1.0047: issues with temp curwin/buf while cmdwin is open
Commit: https://github.com/vim/vim/commit/988f74311c26ea9917e84fbae608de226dba7e5f
Author: Sean Dewar <seandewar@users.noreply.github.com>
Date: Wed Aug 16 14:17:36 2023 +0100
patch 9.1.0047: issues with temp curwin/buf while cmdwin is open
Problem: Things that temporarily change/restore curwin/buf (e.g:
win_execute, some autocmds) may break assumptions that
curwin/buf is the cmdwin when "cmdwin_type != 0", causing
issues.
Solution: Expose the cmdwin's real win/buf and check that instead. Also
try to ensure these variables are NULL if "cmdwin_type == 0",
allowing them to be used directly in most cases without
checking cmdwin_type. (Sean Dewar)
Alternatively, we could ban win_execute in the cmdwin and audit all places that
temporarily change/restore curwin/buf, but I didn't notice any problems arising
from allowing this (standard cmdwin restrictions still apply, so things that may
actually break the cmdwin are still forbidden).
closes: #12819
Signed-off-by: Sean Dewar <seandewar@users.noreply.github.com>
Signed-off-by: Christian Brabandt <cb@256bit.org>
author | Christian Brabandt <cb@256bit.org> |
---|---|
date | Tue, 23 Jan 2024 23:00:04 +0100 |
parents | fb4c30606b4a |
children |
line wrap: on
line source
" Test for :execute, :while, :for and :if func Test_exec_while_if() new let i = 0 while i < 12 let i = i + 1 execute "normal o" . i . "\033" if i % 2 normal Ax if i == 9 break endif if i == 5 continue else let j = 9 while j > 0 execute "normal" j . "a" . j . "\x1b" let j = j - 1 endwhile endif endif if i == 9 execute "normal Az\033" endif endwhile unlet i j call assert_equal(["", \ "1x999999999888888887777777666666555554444333221", \ "2", \ "3x999999999888888887777777666666555554444333221", \ "4", \ "5x", \ "6", \ "7x999999999888888887777777666666555554444333221", \ "8", \ "9x"], getline(1, 10)) endfunc " vim: shiftwidth=2 sts=2 expandtab