Mercurial > vim
view src/proto/match.pro @ 34194:a522c6c0127b v9.1.0047
patch 9.1.0047: issues with temp curwin/buf while cmdwin is open
Commit: https://github.com/vim/vim/commit/988f74311c26ea9917e84fbae608de226dba7e5f
Author: Sean Dewar <seandewar@users.noreply.github.com>
Date: Wed Aug 16 14:17:36 2023 +0100
patch 9.1.0047: issues with temp curwin/buf while cmdwin is open
Problem: Things that temporarily change/restore curwin/buf (e.g:
win_execute, some autocmds) may break assumptions that
curwin/buf is the cmdwin when "cmdwin_type != 0", causing
issues.
Solution: Expose the cmdwin's real win/buf and check that instead. Also
try to ensure these variables are NULL if "cmdwin_type == 0",
allowing them to be used directly in most cases without
checking cmdwin_type. (Sean Dewar)
Alternatively, we could ban win_execute in the cmdwin and audit all places that
temporarily change/restore curwin/buf, but I didn't notice any problems arising
from allowing this (standard cmdwin restrictions still apply, so things that may
actually break the cmdwin are still forbidden).
closes: #12819
Signed-off-by: Sean Dewar <seandewar@users.noreply.github.com>
Signed-off-by: Christian Brabandt <cb@256bit.org>
author | Christian Brabandt <cb@256bit.org> |
---|---|
date | Tue, 23 Jan 2024 23:00:04 +0100 |
parents | baec4e1cee43 |
children |
line wrap: on
line source
/* match.c */ void clear_matches(win_T *wp); void init_search_hl(win_T *wp, match_T *search_hl); void prepare_search_hl(win_T *wp, match_T *search_hl, linenr_T lnum); int prepare_search_hl_line(win_T *wp, linenr_T lnum, colnr_T mincol, char_u **line, match_T *search_hl, int *search_attr); int update_search_hl(win_T *wp, linenr_T lnum, colnr_T col, char_u **line, match_T *search_hl, int *has_match_conc, int *match_conc, int did_line_attr, int lcs_eol_one, int *on_last_col); int get_prevcol_hl_flag(win_T *wp, match_T *search_hl, long curcol); void get_search_match_hl(win_T *wp, match_T *search_hl, long col, int *char_attr); void f_clearmatches(typval_T *argvars, typval_T *rettv); void f_getmatches(typval_T *argvars, typval_T *rettv); void f_setmatches(typval_T *argvars, typval_T *rettv); void f_matchadd(typval_T *argvars, typval_T *rettv); void f_matchaddpos(typval_T *argvars, typval_T *rettv); void f_matcharg(typval_T *argvars, typval_T *rettv); void f_matchdelete(typval_T *argvars, typval_T *rettv); void ex_match(exarg_T *eap); /* vim: set ft=c : */