Mercurial > vim
view src/proto/float.pro @ 34194:a522c6c0127b v9.1.0047
patch 9.1.0047: issues with temp curwin/buf while cmdwin is open
Commit: https://github.com/vim/vim/commit/988f74311c26ea9917e84fbae608de226dba7e5f
Author: Sean Dewar <seandewar@users.noreply.github.com>
Date: Wed Aug 16 14:17:36 2023 +0100
patch 9.1.0047: issues with temp curwin/buf while cmdwin is open
Problem: Things that temporarily change/restore curwin/buf (e.g:
win_execute, some autocmds) may break assumptions that
curwin/buf is the cmdwin when "cmdwin_type != 0", causing
issues.
Solution: Expose the cmdwin's real win/buf and check that instead. Also
try to ensure these variables are NULL if "cmdwin_type == 0",
allowing them to be used directly in most cases without
checking cmdwin_type. (Sean Dewar)
Alternatively, we could ban win_execute in the cmdwin and audit all places that
temporarily change/restore curwin/buf, but I didn't notice any problems arising
from allowing this (standard cmdwin restrictions still apply, so things that may
actually break the cmdwin are still forbidden).
closes: #12819
Signed-off-by: Sean Dewar <seandewar@users.noreply.github.com>
Signed-off-by: Christian Brabandt <cb@256bit.org>
| author | Christian Brabandt <cb@256bit.org> |
|---|---|
| date | Tue, 23 Jan 2024 23:00:04 +0100 |
| parents | 763ea8f075db |
| children |
line wrap: on
line source
/* float.c */ int string2float(char_u *text, float_T *value, int skip_quotes); void f_abs(typval_T *argvars, typval_T *rettv); void f_acos(typval_T *argvars, typval_T *rettv); void f_asin(typval_T *argvars, typval_T *rettv); void f_atan(typval_T *argvars, typval_T *rettv); void f_atan2(typval_T *argvars, typval_T *rettv); void f_ceil(typval_T *argvars, typval_T *rettv); void f_cos(typval_T *argvars, typval_T *rettv); void f_cosh(typval_T *argvars, typval_T *rettv); void f_exp(typval_T *argvars, typval_T *rettv); void f_float2nr(typval_T *argvars, typval_T *rettv); void f_floor(typval_T *argvars, typval_T *rettv); void f_fmod(typval_T *argvars, typval_T *rettv); void f_isinf(typval_T *argvars, typval_T *rettv); void f_isnan(typval_T *argvars, typval_T *rettv); void f_log(typval_T *argvars, typval_T *rettv); void f_log10(typval_T *argvars, typval_T *rettv); void f_pow(typval_T *argvars, typval_T *rettv); float_T vim_round(float_T f); void f_round(typval_T *argvars, typval_T *rettv); void f_sin(typval_T *argvars, typval_T *rettv); void f_sinh(typval_T *argvars, typval_T *rettv); void f_sqrt(typval_T *argvars, typval_T *rettv); void f_str2float(typval_T *argvars, typval_T *rettv); void f_tan(typval_T *argvars, typval_T *rettv); void f_tanh(typval_T *argvars, typval_T *rettv); void f_trunc(typval_T *argvars, typval_T *rettv); /* vim: set ft=c : */