Mercurial > vim
view src/os_vms_mms.c @ 34194:a522c6c0127b v9.1.0047
patch 9.1.0047: issues with temp curwin/buf while cmdwin is open
Commit: https://github.com/vim/vim/commit/988f74311c26ea9917e84fbae608de226dba7e5f
Author: Sean Dewar <seandewar@users.noreply.github.com>
Date: Wed Aug 16 14:17:36 2023 +0100
patch 9.1.0047: issues with temp curwin/buf while cmdwin is open
Problem: Things that temporarily change/restore curwin/buf (e.g:
win_execute, some autocmds) may break assumptions that
curwin/buf is the cmdwin when "cmdwin_type != 0", causing
issues.
Solution: Expose the cmdwin's real win/buf and check that instead. Also
try to ensure these variables are NULL if "cmdwin_type == 0",
allowing them to be used directly in most cases without
checking cmdwin_type. (Sean Dewar)
Alternatively, we could ban win_execute in the cmdwin and audit all places that
temporarily change/restore curwin/buf, but I didn't notice any problems arising
from allowing this (standard cmdwin restrictions still apply, so things that may
actually break the cmdwin are still forbidden).
closes: #12819
Signed-off-by: Sean Dewar <seandewar@users.noreply.github.com>
Signed-off-by: Christian Brabandt <cb@256bit.org>
author | Christian Brabandt <cb@256bit.org> |
---|---|
date | Tue, 23 Jan 2024 23:00:04 +0100 |
parents | 2463194c8cdd |
children |
line wrap: on
line source
#include <stdio.h> #include <stdlib.h> #include <string.h> #include <unixio.h> #include "vim.h" int main(int argc, char *argv[]) { FILE *fpi, *fpo; char cmd[132], buf[BUFSIZ], *argp, *error_file, target[132], *mms; int err = 0, err_line = 0; mms = "mms"; argc--; argv++; while (argc-- > 0) { argp = *argv++; if (*argp == '-') { switch (*++argp) { case 'm': mms = ++argp; break; case 'e': if (!*(error_file = ++argp)) { error_file = *argv++; argc--; } break; default: break; } } else { if (*target) strcat(target, " "); strcat(target, argp); } } vim_snprintf(cmd, sizeof(cmd), "%s/output=tmp:errors.vim_tmp %s", mms, target); system(cmd); fpi = fopen("tmp:errors.vim_tmp", "r"); fpo = fopen(error_file, "w"); while (fgets(buf, BUFSIZ, fpi)) { if (!memcmp(buf, "%CC-", 4)) { err_line++; buf[strlen(buf)-1] = '\0'; err++; } else { if (err_line) { if (strstr(buf, _("At line"))) { err_line = 0; fprintf(fpo, "@"); } else buf[strlen(buf)-1] = '\0'; } } fprintf(fpo, "%s", buf); } fclose(fpi); fclose(fpo); while (!delete("tmp:errors.vim_tmp")) /*nop*/; exit(err ? 44 : 1); return(0); }