Mercurial > vim
view src/if_perlsfio.c @ 34194:a522c6c0127b v9.1.0047
patch 9.1.0047: issues with temp curwin/buf while cmdwin is open
Commit: https://github.com/vim/vim/commit/988f74311c26ea9917e84fbae608de226dba7e5f
Author: Sean Dewar <seandewar@users.noreply.github.com>
Date: Wed Aug 16 14:17:36 2023 +0100
patch 9.1.0047: issues with temp curwin/buf while cmdwin is open
Problem: Things that temporarily change/restore curwin/buf (e.g:
win_execute, some autocmds) may break assumptions that
curwin/buf is the cmdwin when "cmdwin_type != 0", causing
issues.
Solution: Expose the cmdwin's real win/buf and check that instead. Also
try to ensure these variables are NULL if "cmdwin_type == 0",
allowing them to be used directly in most cases without
checking cmdwin_type. (Sean Dewar)
Alternatively, we could ban win_execute in the cmdwin and audit all places that
temporarily change/restore curwin/buf, but I didn't notice any problems arising
from allowing this (standard cmdwin restrictions still apply, so things that may
actually break the cmdwin are still forbidden).
closes: #12819
Signed-off-by: Sean Dewar <seandewar@users.noreply.github.com>
Signed-off-by: Christian Brabandt <cb@256bit.org>
author | Christian Brabandt <cb@256bit.org> |
---|---|
date | Tue, 23 Jan 2024 23:00:04 +0100 |
parents | f0f9692d4487 |
children |
line wrap: on
line source
/* vi:set ts=8 sts=4 sw=4 noet: * * VIM - Vi IMproved by Bram Moolenaar * * Do ":help uganda" in Vim to read copying and usage conditions. * Do ":help credits" in Vim to see a list of people who contributed. * See README.txt for an overview of the Vim source code. */ /* * if_perlsfio.c: Special I/O functions for Perl interface. */ #define _memory_h // avoid memset redeclaration #define IN_PERL_FILE // don't include if_perl.pro from prot.h #include "vim.h" #if defined(USE_SFIO) || defined(PROTO) #ifndef USE_SFIO // just generating prototypes # define Sfio_t int # define Sfdisc_t int #endif #define NIL(type) ((type)0) static int sfvimwrite( Sfio_t *f, // stream involved char *buf, // buffer to read from int n, // number of bytes to write Sfdisc_t *disc) // discipline { char_u *str; str = vim_strnsave((char_u *)buf, n); if (str == NULL) return 0; msg_split((char *)str); vim_free(str); return n; } /* * sfdcnewnvi -- * Create Vim discipline */ Sfdisc_t * sfdcnewvim(void) { Sfdisc_t *disc; disc = ALLOC_ONE(Sfdisc_t); if (disc == NULL) return NULL; disc->readf = (Sfread_f)NULL; disc->writef = sfvimwrite; disc->seekf = (Sfseek_f)NULL; disc->exceptf = (Sfexcept_f)NULL; return disc; } #endif // USE_SFIO