Mercurial > vim
view src/create_nvcmdidxs.vim @ 34194:a522c6c0127b v9.1.0047
patch 9.1.0047: issues with temp curwin/buf while cmdwin is open
Commit: https://github.com/vim/vim/commit/988f74311c26ea9917e84fbae608de226dba7e5f
Author: Sean Dewar <seandewar@users.noreply.github.com>
Date: Wed Aug 16 14:17:36 2023 +0100
patch 9.1.0047: issues with temp curwin/buf while cmdwin is open
Problem: Things that temporarily change/restore curwin/buf (e.g:
win_execute, some autocmds) may break assumptions that
curwin/buf is the cmdwin when "cmdwin_type != 0", causing
issues.
Solution: Expose the cmdwin's real win/buf and check that instead. Also
try to ensure these variables are NULL if "cmdwin_type == 0",
allowing them to be used directly in most cases without
checking cmdwin_type. (Sean Dewar)
Alternatively, we could ban win_execute in the cmdwin and audit all places that
temporarily change/restore curwin/buf, but I didn't notice any problems arising
from allowing this (standard cmdwin restrictions still apply, so things that may
actually break the cmdwin are still forbidden).
closes: #12819
Signed-off-by: Sean Dewar <seandewar@users.noreply.github.com>
Signed-off-by: Christian Brabandt <cb@256bit.org>
author | Christian Brabandt <cb@256bit.org> |
---|---|
date | Tue, 23 Jan 2024 23:00:04 +0100 |
parents | ee1019e59bef |
children |
line wrap: on
line source
" This script generates the table nv_cmd_idx[] which contains the index in " nv_cmds[] table (normal.c) for each of the command character supported in " normal/visual mode. " This is used to speed up the command lookup in nv_cmds[]. " " Script should be run using "make nvcmdidxs", every time the nv_cmds[] table " in src/nv_cmds.h changes. " " This is written in legacy Vim script so that it can be run by a slightly " older Vim version. " Generate the table of normal/visual mode command characters and their " corresponding index. let cmd = 'create_nvcmdidxs' if has('unix') let cmd = './' .. cmd endif let nv_cmdtbl = systemlist(cmd)->map({i, ch -> {'idx': i, 'cmdchar': ch}}) " sort the table by the command character call sort(nv_cmdtbl, {a, b -> a.cmdchar - b.cmdchar}) " Compute the highest index upto which the command character can be directly " used as an index. let nv_max_linear = 0 for i in range(nv_cmdtbl->len()) if i != nv_cmdtbl[i].cmdchar let nv_max_linear = i - 1 break endif endfor " Generate a header file with the table let output =<< trim END /* * Automatically generated code by the create_nvcmdidxs.vim script. * * Table giving the index in nv_cmds[] to lookup based on * the command character. */ // nv_cmd_idx[<normal mode command character>] => nv_cmds[] index static const unsigned short nv_cmd_idx[] = { END " Add each command character in comment and the corresponding index let output += nv_cmdtbl->map({_, v -> \ printf(' /* %5d */ %3d,', v.cmdchar, v.idx)}) let output += ['};', '', \ '// The highest index for which', \ '// nv_cmds[idx].cmd_char == nv_cmd_idx[nv_cmds[idx].cmd_char]'] let output += ['static const int nv_max_linear = ' .. nv_max_linear .. ';'] call writefile(output, "nv_cmdidxs.h") quit " vim: shiftwidth=2 sts=2 expandtab