Mercurial > vim
view src/alloc.h @ 34194:a522c6c0127b v9.1.0047
patch 9.1.0047: issues with temp curwin/buf while cmdwin is open
Commit: https://github.com/vim/vim/commit/988f74311c26ea9917e84fbae608de226dba7e5f
Author: Sean Dewar <seandewar@users.noreply.github.com>
Date: Wed Aug 16 14:17:36 2023 +0100
patch 9.1.0047: issues with temp curwin/buf while cmdwin is open
Problem: Things that temporarily change/restore curwin/buf (e.g:
win_execute, some autocmds) may break assumptions that
curwin/buf is the cmdwin when "cmdwin_type != 0", causing
issues.
Solution: Expose the cmdwin's real win/buf and check that instead. Also
try to ensure these variables are NULL if "cmdwin_type == 0",
allowing them to be used directly in most cases without
checking cmdwin_type. (Sean Dewar)
Alternatively, we could ban win_execute in the cmdwin and audit all places that
temporarily change/restore curwin/buf, but I didn't notice any problems arising
from allowing this (standard cmdwin restrictions still apply, so things that may
actually break the cmdwin are still forbidden).
closes: #12819
Signed-off-by: Sean Dewar <seandewar@users.noreply.github.com>
Signed-off-by: Christian Brabandt <cb@256bit.org>
author | Christian Brabandt <cb@256bit.org> |
---|---|
date | Tue, 23 Jan 2024 23:00:04 +0100 |
parents | f24d4826e6bf |
children |
line wrap: on
line source
/* vi:set ts=8 sts=4 sw=4 noet: * * VIM - Vi IMproved by Bram Moolenaar * * Do ":help uganda" in Vim to read copying and usage conditions. * Do ":help credits" in Vim to see a list of people who contributed. */ /* * alloc.h: enumeration of alloc IDs. * Used by test_alloc_fail() to test memory allocation failures. * Each entry must be on exactly one line, GetAllocId() depends on that. */ typedef enum { aid_none = 0, aid_qf_dirname_start, aid_qf_dirname_now, aid_qf_namebuf, aid_qf_module, aid_qf_errmsg, aid_qf_pattern, aid_qf_efm_fmtstr, aid_qf_efm_fmtpart, aid_qf_title, aid_qf_mef_name, aid_qf_qfline, aid_qf_qfinfo, aid_qf_dirstack, aid_qf_multiline_pfx, aid_qf_makecmd, aid_qf_linebuf, aid_tagstack_items, aid_tagstack_from, aid_tagstack_details, aid_sign_getdefined, aid_sign_getplaced, aid_sign_define_by_name, aid_sign_getlist, aid_sign_getplaced_dict, aid_sign_getplaced_list, aid_insert_sign, aid_sign_getinfo, aid_newbuf_bvars, aid_newwin_wvars, aid_newtabpage_tvars, aid_blob_alloc, aid_get_func, aid_last } alloc_id_T;