Mercurial > vim
view ci/unlisted.make @ 34194:a522c6c0127b v9.1.0047
patch 9.1.0047: issues with temp curwin/buf while cmdwin is open
Commit: https://github.com/vim/vim/commit/988f74311c26ea9917e84fbae608de226dba7e5f
Author: Sean Dewar <seandewar@users.noreply.github.com>
Date: Wed Aug 16 14:17:36 2023 +0100
patch 9.1.0047: issues with temp curwin/buf while cmdwin is open
Problem: Things that temporarily change/restore curwin/buf (e.g:
win_execute, some autocmds) may break assumptions that
curwin/buf is the cmdwin when "cmdwin_type != 0", causing
issues.
Solution: Expose the cmdwin's real win/buf and check that instead. Also
try to ensure these variables are NULL if "cmdwin_type == 0",
allowing them to be used directly in most cases without
checking cmdwin_type. (Sean Dewar)
Alternatively, we could ban win_execute in the cmdwin and audit all places that
temporarily change/restore curwin/buf, but I didn't notice any problems arising
from allowing this (standard cmdwin restrictions still apply, so things that may
actually break the cmdwin are still forbidden).
closes: #12819
Signed-off-by: Sean Dewar <seandewar@users.noreply.github.com>
Signed-off-by: Christian Brabandt <cb@256bit.org>
author | Christian Brabandt <cb@256bit.org> |
---|---|
date | Tue, 23 Jan 2024 23:00:04 +0100 |
parents | e6c291944e18 |
children |
line wrap: on
line source
# vim: ft=make SHELL = /bin/bash # List all files that are tracked in git but not listed in Filelist. # Exit code is 2 ("Make encountered an error") if any such files exist. # Filelist is a Makefile that defines many variables, so we use Make itself to # query which variables it defines, then expand them all by wrapping each name # in $(...), importing Filelist and using $(eval). include Filelist $(eval all_patterns := $(shell \ make -f Filelist --question --print-data-base --no-builtin-rules \ --no-builtin-variables 2>/dev/null \ | sed -nre \ '/^# makefile .from \x27Filelist\x27,/ { \ n; \ s/ = .*//; \ T; \ s/.*/$$(\0)/; \ p; \ }')) # In Makefile's `prepeare` target, all the IN_README_DIR files are moved from # READMEdir to the root, so add those files in their Git-tracked location: all_patterns := $(all_patterns) \ $(foreach readme, $(IN_README_DIR), READMEdir/$(readme)) # The result 'all_patterns' is a list of patterns (globs), which we expand with # wildcard to get actual filenames. Note this means Filelist can list a file # that does not exist, and it will be omitted at this step. listed_files := $(wildcard $(all_patterns)) # Default target to actually run the comparison: .PHONY: check check: @# There are too many files to list on the command line, so we write @# that to a temporary file, one per line. $(file > Filelist-listed-files) $(foreach filename, $(listed_files),\ $(file >> Filelist-listed-files,$(filename))) @# Compare the sorted lists. Delete that temporary file on both @# success and failure, but exit with diff's exit code. diff -u0 --label files-in-git <(git ls-files | sort) \ --label Filelist <(sort --unique Filelist-listed-files); \ RV=$$?; \ rm Filelist-listed-files; \ (($$RV != 0)) && echo "Add files to the right variable in Filelist."; \ exit $$RV