Mercurial > vim
view src/testdir/test_nested_function.vim @ 33915:a49ae967e9ed v9.0.2158
patch 9.0.2158: [security]: use-after-free in check_argument_type
Commit: https://github.com/vim/vim/commit/0f28791b215bd4c22ed580839409c2f7d39d8140
Author: Christian Brabandt <cb@256bit.org>
Date: Mon Dec 11 17:53:25 2023 +0100
patch 9.0.2158: [security]: use-after-free in check_argument_type
Problem: [security]: use-after-free in check_argument_type
Solution: Reset function type pointer when freeing the function type
list
function pointer fp->uf_func_type may point to the same memory, that was
allocated for fp->uf_type_list. However, when cleaning up a function
definition (e.g. because it was invalid), fp->uf_type_list will be
freed, but fp->uf_func_type may still point to the same (now) invalid
memory address.
So when freeing the fp->uf_type_list, check if fp->func_type points to
any of those types and if it does, reset the fp->uf_func_type pointer to
the t_func_any (default) type pointer
closes: #13652
Signed-off-by: Christian Brabandt <cb@256bit.org>
| author | Christian Brabandt <cb@256bit.org> |
|---|---|
| date | Mon, 11 Dec 2023 18:00:03 +0100 |
| parents | 08940efa6b4e |
| children |
line wrap: on
line source
" Tests for nested functions source check.vim func NestedFunc() func! Func1() let g:text .= 'Func1 ' endfunc call Func1() func! s:func2() let g:text .= 's:func2 ' endfunc call s:func2() func! s:_func3() let g:text .= 's:_func3 ' endfunc call s:_func3() let fn = 'Func4' func! {fn}() let g:text .= 'Func4 ' endfunc call {fn}() let fn = 'func5' func! s:{fn}() let g:text .= 's:func5' endfunc call s:{fn}() endfunc func Test_nested_functions() let g:text = '' call NestedFunc() call assert_equal('Func1 s:func2 s:_func3 Func4 s:func5', g:text) endfunction func Test_nested_argument() func g:X() let g:Y = function('sort') endfunc let g:Y = function('sort') echo g:Y([], g:X()) delfunc g:X unlet g:Y endfunc func Recurse(count) if a:count > 0 call Recurse(a:count - 1) endif endfunc func Test_max_nesting() " TODO: why does this fail on Windows? Runs out of stack perhaps? CheckNotMSWindows let call_depth_here = 2 let ex_depth_here = 5 set mfd& call Recurse(99 - call_depth_here) call assert_fails('call Recurse(' . (100 - call_depth_here) . ')', 'E132:') set mfd=210 call Recurse(209 - ex_depth_here) call assert_fails('call Recurse(' . (210 - ex_depth_here) . ')', 'E169:') set mfd& endfunc " vim: shiftwidth=2 sts=2 expandtab