Mercurial > vim
view src/kword_test.c @ 33404:9b35b4c6df4c v9.0.1960
patch 9.0.1960: Make CI checks more strict
Commit: https://github.com/vim/vim/commit/f7f746b1672909ae57d2eec97253d6627f6c0887
Author: Yee Cheng Chin <ychin.git@gmail.com>
Date: Sat Sep 30 12:28:50 2023 +0200
patch 9.0.1960: Make CI checks more strict
Problem: Make CI checks more strict
Solution: Add -Wstrict-prototypes -Wmissing-prototypes to CI,
fix uncovered problems
Add -Wstrict-prototypes -Wmissing-prototypes warnings check to CI
Add two new warnings to CI, silence some Perl related build-warnings:
- `strict-prototypes` helps prevent declaring a function with an empty
argument list, e.g. `int func()`. In C++, that's equivalent to `int
func(void)`, but in C, that means a function that can take any number
of arguments which is rarely what we want.
- `missing-prototypes` makes sure we use `static` for file-only internal
functions. Non-static functions should have been declared on a
prototype file.
- Add `no-compound-token-split-by-macro` to the perl cflags, since it
throws out a bunch of perl-related warnings that make the CI log
unnecessary verbose and hard to read. This seems to happen only with
clang 12 and above.
When applying those changes, it already uncovered a few warnings, so fix
up the code as well (fix prototypes, make the code static, remove
shadowed var declaration)
GTK header needs to have #pragma warning suppressiong because GTK2
headers will warn on `-Wstrict-prototypes`, and it's included by gui.h
and so we can't just turn off the warning in a couple files.
closes: #13223
closes: #13226
Signed-off-by: Christian Brabandt <cb@256bit.org>
Co-authored-by: Yee Cheng Chin <ychin.git@gmail.com>
author | Christian Brabandt <cb@256bit.org> |
---|---|
date | Sat, 30 Sep 2023 12:45:05 +0200 |
parents | aadd1cae2ff5 |
children |
line wrap: on
line source
/* vi:set ts=8 sts=4 sw=4 noet: * * VIM - Vi IMproved by Bram Moolenaar * * Do ":help uganda" in Vim to read copying and usage conditions. * Do ":help credits" in Vim to see a list of people who contributed. * See README.txt for an overview of the Vim source code. */ /* * kword_test.c: Unittests for vim_iswordc() and vim_iswordp(). */ #undef NDEBUG #include <assert.h> // Must include main.c because it contains much more than just main() #define NO_VIM_MAIN #include "main.c" // This file has to be included because the tested functions are static #include "charset.c" /* * Test the results of vim_iswordc() and vim_iswordp() are matched. */ static void test_isword_funcs_utf8(void) { buf_T buf; int c; CLEAR_FIELD(buf); p_enc = (char_u *)"utf-8"; p_isi = (char_u *)""; p_isp = (char_u *)""; p_isf = (char_u *)""; buf.b_p_isk = (char_u *)"@,48-57,_,128-167,224-235"; curbuf = &buf; mb_init(); // calls init_chartab() for (c = 0; c < 0x10000; ++c) { char_u p[4] = {0}; int c1; int retc; int retp; utf_char2bytes(c, p); c1 = utf_ptr2char(p); if (c != c1) { fprintf(stderr, "Failed: "); fprintf(stderr, "[c = %#04x, p = {%#02x, %#02x, %#02x}] ", c, p[0], p[1], p[2]); fprintf(stderr, "c != utf_ptr2char(p) (=%#04x)\n", c1); abort(); } retc = vim_iswordc_buf(c, &buf); retp = vim_iswordp_buf(p, &buf); if (retc != retp) { fprintf(stderr, "Failed: "); fprintf(stderr, "[c = %#04x, p = {%#02x, %#02x, %#02x}] ", c, p[0], p[1], p[2]); fprintf(stderr, "vim_iswordc(c) (=%d) != vim_iswordp(p) (=%d)\n", retc, retp); abort(); } } } int main(void) { estack_init(); test_isword_funcs_utf8(); return 0; }