patch 9.0.1960: Make CI checks more strict Commit: https://github.com/vim/vim/commit/f7f746b1672909ae57d2eec97253d6627f6c0887 Author: Yee Cheng Chin <ychin.git@gmail.com> Date: Sat Sep 30 12:28:50 2023 +0200 patch 9.0.1960: Make CI checks more strict Problem: Make CI checks more strict Solution: Add -Wstrict-prototypes -Wmissing-prototypes to CI, fix uncovered problems Add -Wstrict-prototypes -Wmissing-prototypes warnings check to CI Add two new warnings to CI, silence some Perl related build-warnings: - `strict-prototypes` helps prevent declaring a function with an empty argument list, e.g. `int func()`. In C++, that's equivalent to `int func(void)`, but in C, that means a function that can take any number of arguments which is rarely what we want. - `missing-prototypes` makes sure we use `static` for file-only internal functions. Non-static functions should have been declared on a prototype file. - Add `no-compound-token-split-by-macro` to the perl cflags, since it throws out a bunch of perl-related warnings that make the CI log unnecessary verbose and hard to read. This seems to happen only with clang 12 and above. When applying those changes, it already uncovered a few warnings, so fix up the code as well (fix prototypes, make the code static, remove shadowed var declaration) GTK header needs to have #pragma warning suppressiong because GTK2 headers will warn on `-Wstrict-prototypes`, and it's included by gui.h and so we can't just turn off the warning in a couple files. closes: #13223 closes: #13226 Signed-off-by: Christian Brabandt <cb@256bit.org> Co-authored-by: Yee Cheng Chin <ychin.git@gmail.com>

#env:
#  CIRRUS_CLONE_DEPTH: 3
#  FEATURES: huge
#
#freebsd_task:
#  name: FreeBSD
#  matrix:
#    - name: FreeBSD 14.0
#      freebsd_instance:
#        image_family: freebsd-14-0
#  timeout_in: 20m
#  install_script:
#    - pkg install -y gettext
#  build_script:
#    - NPROC=$(getconf _NPROCESSORS_ONLN)
#    - ./configure --with-features=${FEATURES}
#    - make -j${NPROC}
#  test_script:
#    - src/vim --version
#      # run tests as user "cirrus" instead of root
#    - pw useradd cirrus -m
#    - chown -R cirrus:cirrus .
#    - sudo -u cirrus make test