Mercurial > vim
view src/testdir/test_findfile.vim @ 33776:9503dc55b5ed v9.0.2108
patch 9.0.2108: [security]: overflow with count for :s command
Commit: https://github.com/vim/vim/commit/ac63787734fda2e294e477af52b3bd601517fa78
Author: Christian Brabandt <cb@256bit.org>
Date: Tue Nov 14 20:45:48 2023 +0100
patch 9.0.2108: [security]: overflow with count for :s command
Problem: [security]: overflow with count for :s command
Solution: Abort the :s command if the count is too large
If the count after the :s command is larger than what fits into a
(signed) long variable, abort with e_value_too_large.
Adds a test with INT_MAX as count and verify it correctly fails.
It seems the return value on Windows using mingw compiler wraps around,
so the initial test using :s/./b/9999999999999999999999999990 doesn't
fail there, since the count is wrapping around several times and finally
is no longer larger than 2147483647. So let's just use 2147483647 in the
test, which hopefully will always cause a failure
Signed-off-by: Christian Brabandt <cb@256bit.org>
author | Christian Brabandt <cb@256bit.org> |
---|---|
date | Thu, 16 Nov 2023 22:15:10 +0100 |
parents | a7a9e8b9af89 |
children | f55b953f59bd |
line wrap: on
line source
" Test findfile() and finddir() let s:files = [ 'Xfinddir1/foo', \ 'Xfinddir1/bar', \ 'Xfinddir1/Xdir2/foo', \ 'Xfinddir1/Xdir2/foobar', \ 'Xfinddir1/Xdir2/Xdir3/bar', \ 'Xfinddir1/Xdir2/Xdir3/barfoo' ] func CreateFiles() call mkdir('Xfinddir1/Xdir2/Xdir3/Xdir2', 'p') for f in s:files call writefile([], f) endfor endfunc func CleanFiles() " Safer to delete each file even if it's more verbose " than doing a recursive delete('Xfinddir1', 'rf'). for f in s:files call delete(f) endfor call delete('Xfinddir1/Xdir2/Xdir3/Xdir2', 'd') call delete('Xfinddir1/Xdir2/Xdir3', 'd') call delete('Xfinddir1/Xdir2', 'd') call delete('Xfinddir1', 'd') endfunc " Test findfile({name} [, {path} [, {count}]]) func Test_findfile() let save_path = &path let save_shellslash = &shellslash let save_dir = getcwd() set shellslash call CreateFiles() cd Xfinddir1 e Xdir2/foo " With ,, in path, findfile() searches in current directory. set path=,, call assert_equal('foo', findfile('foo')) call assert_equal('bar', findfile('bar')) call assert_equal('', findfile('foobar')) " Directories should not be found (finddir() finds them). call assert_equal('', findfile('Xdir2')) " With . in 'path', findfile() searches relatively to current file. set path=. call assert_equal('Xdir2/foo', findfile('foo')) call assert_equal('', findfile('bar')) call assert_equal('Xdir2/foobar', 'foobar'->findfile()) " Empty {path} 2nd argument is the same as no 2nd argument. call assert_equal('Xdir2/foo', findfile('foo', '')) call assert_equal('', findfile('bar', '')) " Test with * call assert_equal('Xdir2/foo', findfile('foo', '*')) call assert_equal('', findfile('bar', '*')) call assert_equal('Xdir2/Xdir3/bar', findfile('bar', '*/*')) call assert_equal('Xdir2/Xdir3/bar', findfile('bar', 'Xdir2/*')) call assert_equal('Xdir2/Xdir3/bar', findfile('bar', 'Xdir*/Xdir3')) call assert_equal('Xdir2/Xdir3/bar', findfile('bar', '*2/*3')) " Test with ** call assert_equal('bar', findfile('bar', '**')) call assert_equal('Xdir2/Xdir3/bar', findfile('bar', '**/Xdir3')) call assert_equal('Xdir2/Xdir3/bar', findfile('bar', 'Xdir2/**')) call assert_equal('Xdir2/Xdir3/barfoo', findfile('barfoo', '**2')) call assert_equal('', findfile('barfoo', '**1')) call assert_equal('Xdir2/foobar', findfile('foobar', '**1')) " Test with {count} 3rd argument. call assert_equal('bar', findfile('bar', '**', 0)) call assert_equal('bar', findfile('bar', '**', 1)) call assert_equal('Xdir2/Xdir3/bar', findfile('bar', '**', 2)) call assert_equal('', findfile('bar', '**', 3)) call assert_equal(['bar', 'Xdir2/Xdir3/bar'], findfile('bar', '**', -1)) " Test upwards search. cd Xdir2/Xdir3 call assert_equal('bar', findfile('bar', ';')) call assert_match('.*/Xfinddir1/Xdir2/foo', findfile('foo', ';')) call assert_match('.*/Xfinddir1/Xdir2/foo', findfile('foo', ';', 1)) call assert_match('.*/Xfinddir1/foo', findfile('foo', ';', 2)) call assert_match('.*/Xfinddir1/foo', findfile('foo', ';', 2)) call assert_match('.*/Xfinddir1/Xdir2/foo', findfile('foo', 'Xdir2;', 1)) call assert_equal('', findfile('foo', 'Xdir2;', 2)) " List l should have at least 2 values (possibly more if foo file " happens to be found upwards above Xfinddir1). let l = findfile('foo', ';', -1) call assert_match('.*/Xfinddir1/Xdir2/foo', l[0]) call assert_match('.*/Xfinddir1/foo', l[1]) " Test upwards search with stop-directory. cd Xdir2 let l = findfile('bar', ';' . save_dir . '/Xfinddir1/Xdir2/', -1) call assert_equal(1, len(l)) call assert_match('.*/Xfinddir1/Xdir2/Xdir3/bar', l[0]) let l = findfile('bar', ';' . save_dir . '/Xfinddir1/', -1) call assert_equal(2, len(l)) call assert_match('.*/Xfinddir1/Xdir2/Xdir3/bar', l[0]) call assert_match('.*/Xfinddir1/bar', l[1]) " Test combined downwards and upwards search from Xdir2/. cd ../.. call assert_equal('Xdir3/bar', findfile('bar', '**;', 1)) call assert_match('.*/Xfinddir1/bar', findfile('bar', '**;', 2)) bwipe! call chdir(save_dir) call CleanFiles() let &path = save_path let &shellslash = save_shellslash endfunc func Test_findfile_error() call assert_fails('call findfile([])', 'E730:') call assert_fails('call findfile("x", [])', 'E730:') call assert_fails('call findfile("x", "", [])', 'E745:') call assert_fails('call findfile("x", "**x")', 'E343:') call assert_fails('call findfile("x", repeat("x", 5000))', 'E854:') endfunc " Test finddir({name} [, {path} [, {count}]]) func Test_finddir() let save_path = &path let save_shellslash = &shellslash let save_dir = getcwd() set path=,, call CreateFiles() cd Xfinddir1 call assert_equal('Xdir2', finddir('Xdir2')) call assert_equal('', 'Xdir3'->finddir()) " Files should not be found (findfile() finds them). call assert_equal('', finddir('foo')) call assert_equal('Xdir2', finddir('Xdir2', '**')) call assert_equal('Xdir2/Xdir3', finddir('Xdir3', '**')) call assert_equal('Xdir2', finddir('Xdir2', '**', 1)) call assert_equal('Xdir2/Xdir3/Xdir2', finddir('Xdir2', '**', 2)) call assert_equal(['Xdir2', \ 'Xdir2/Xdir3/Xdir2'], finddir('Xdir2', '**', -1)) call assert_equal('Xdir2', finddir('Xdir2', '**1')) call assert_equal('Xdir2', finddir('Xdir2', '**0')) call assert_equal('Xdir2/Xdir3', finddir('Xdir3', '**1')) call assert_equal('', finddir('Xdir3', '**0')) " Test upwards dir search. cd Xdir2/Xdir3 call assert_match('.*/Xfinddir1', finddir('Xfinddir1', ';')) " Test upwards search with stop-directory. call assert_match('.*/Xfinddir1', finddir('Xfinddir1', ';' . save_dir . '/')) call assert_equal('', finddir('Xfinddir1', ';' . save_dir . '/Xfinddir1/')) " Test combined downwards and upwards dir search from Xdir2/. cd .. call assert_match('.*/Xfinddir1', finddir('Xfinddir1', '**;', 1)) call assert_equal('Xdir3/Xdir2', finddir('Xdir2', '**;', 1)) call assert_match('.*/Xfinddir1/Xdir2', finddir('Xdir2', '**;', 2)) call assert_equal('Xdir3', finddir('Xdir3', '**;', 1)) call chdir(save_dir) call CleanFiles() let &path = save_path let &shellslash = save_shellslash endfunc func Test_finddir_error() call assert_fails('call finddir([])', 'E730:') call assert_fails('call finddir("x", [])', 'E730:') call assert_fails('call finddir("x", "", [])', 'E745:') call assert_fails('call finddir("x", "**x")', 'E343:') call assert_fails('call finddir("x", repeat("x", 5000))', 'E854:') endfunc " Test for the :find, :sfind and :tabfind commands func Test_find_cmd() new let save_path = &path let save_dir = getcwd() set path=.,./**/* call CreateFiles() cd Xfinddir1 " Test for :find find foo call assert_equal('foo', expand('%:.')) 2find foo call assert_equal('Xdir2/foo', expand('%:.')) call assert_fails('3find foo', 'E347:') " Test for :sfind enew sfind barfoo call assert_equal('Xdir2/Xdir3/barfoo', expand('%:.')) call assert_equal(3, winnr('$')) close call assert_fails('sfind baz', 'E345:') call assert_equal(2, winnr('$')) " Test for :tabfind enew tabfind foobar call assert_equal('Xdir2/foobar', expand('%:.')) call assert_equal(2, tabpagenr('$')) tabclose call assert_fails('tabfind baz', 'E345:') call assert_equal(1, tabpagenr('$')) call chdir(save_dir) call CleanFiles() let &path = save_path close call assert_fails('find', 'E471:') call assert_fails('sfind', 'E471:') call assert_fails('tabfind', 'E471:') endfunc func Test_find_non_existing_path() new let save_path = &path let save_dir = getcwd() call mkdir('dir1/dir2', 'pR') call writefile([], 'dir1/file.txt') call writefile([], 'dir1/dir2/base.txt') call chdir('dir1/dir2') e base.txt set path=../include call assert_fails(':find file.txt', 'E345:') call chdir(save_dir) bw! let &path = save_path endfunc " vim: shiftwidth=2 sts=2 expandtab