Mercurial > vim
view runtime/compiler/splint.vim @ 33776:9503dc55b5ed v9.0.2108
patch 9.0.2108: [security]: overflow with count for :s command
Commit: https://github.com/vim/vim/commit/ac63787734fda2e294e477af52b3bd601517fa78
Author: Christian Brabandt <cb@256bit.org>
Date: Tue Nov 14 20:45:48 2023 +0100
patch 9.0.2108: [security]: overflow with count for :s command
Problem: [security]: overflow with count for :s command
Solution: Abort the :s command if the count is too large
If the count after the :s command is larger than what fits into a
(signed) long variable, abort with e_value_too_large.
Adds a test with INT_MAX as count and verify it correctly fails.
It seems the return value on Windows using mingw compiler wraps around,
so the initial test using :s/./b/9999999999999999999999999990 doesn't
fail there, since the count is wrapping around several times and finally
is no longer larger than 2147483647. So let's just use 2147483647 in the
test, which hopefully will always cause a failure
Signed-off-by: Christian Brabandt <cb@256bit.org>
author | Christian Brabandt <cb@256bit.org> |
---|---|
date | Thu, 16 Nov 2023 22:15:10 +0100 |
parents | 2704c4e3e20a |
children | e1df51f68736 |
line wrap: on
line source
" Vim compiler file " Compiler: splint/lclint (C source code checker) " Maintainer: Ralf Wildenhues <Ralf.Wildenhues@gmx.de> " Splint Home: http://www.splint.org/ " Last Change: 2019 Jul 23 " $Revision: 1.3 $ if exists("current_compiler") finish endif let current_compiler = "splint" if exists(":CompilerSet") != 2 " older Vim always used :setlocal command -nargs=* CompilerSet setlocal <args> endif let s:cpo_save = &cpo set cpo-=C " adapt this if you want to check more than one file at a time. " put command line options in .splintrc or ~/.splintrc CompilerSet makeprg=splint\ %:S " Note: when using the new array bounds checking flags: Each warning " usually has several lines and several references to source code mostly " within one or two lines (see sample warning below). The easiest way " not to mess up file name detection and not to jump to all positions is " to add something like " -linelen 500 +boundscompacterrormessages " to your .splintrc and 'set cmdheight=4' or more. " TODO: reliable way to distinguish file names and constraints. " " sample warning (generic): " "foo.c:1006:12: Clauses exit with var referencing local storage in one " case, fresh storage in other case " foo.c:1003:2: Fresh storage var allocated " " sample warning (bounds checking): " "bounds.c: (in function updateEnv) "bounds.c:10:5: Possible out-of-bounds store: " strcpy(str, tmp) " Unable to resolve constraint: " requires maxSet(str @ bounds.c:10:13) >= maxRead(getenv("MYENV") @ " bounds.c:6:9) " needed to satisfy precondition: " requires maxSet(str @ bounds.c:10:13) >= maxRead(tmp @ bounds.c:10:18) " derived from strcpy precondition: requires maxSet(<parameter 1>) >= " maxRead(<parameter 2>) " A memory write may write to an address beyond the allocated buffer. (Use " -boundswrite to inhibit warning) CompilerSet errorformat=%OLCLint*m, \%OSplint*m, \%f(%l\\,%c):\ %m, \%*[\ ]%f:%l:%c:\ %m, \%*[\ ]%f:%l:\ %m, \%*[^\"]\"%f\"%*\\D%l:\ %m, \\"%f\"%*\\D%l:\ %m, \%A%f:%l:%c:\ %m, \%A%f:%l:%m, \\"%f\"\\, \\ line\ %l%*\\D%c%*[^\ ]\ %m, \%D%*\\a[%*\\d]:\ Entering\ directory\ `%f', \%X%*\\a[%*\\d]:\ Leaving\ directory\ `%f', \%DMaking\ %*\\a\ in\ %f, \%C\ %#%m let &cpo = s:cpo_save unlet s:cpo_save