Mercurial > vim
view runtime/compiler/perl.vim @ 33865:8cdb69ea3711 v9.0.2143
patch 9.0.2143: [security]: buffer-overflow in ex_substitute
Commit: https://github.com/vim/vim/commit/abfa13ebe92d81aaf66669c428d767847b577453
Author: Christian Brabandt <cb@256bit.org>
Date: Thu Nov 30 11:32:18 2023 +0100
patch 9.0.2143: [security]: buffer-overflow in ex_substitute
Problem: [security]: buffer-overflow in ex_substitute
Solution: clear memory after allocating
When allocating the new_start pointer in ex_substitute() the memory
pointer points to some garbage that the following for loop in
ex_cmds.c:4743 confuses and causes it to accessing the new_start pointer
beyond it's size, leading to a buffer-overlow.
So fix this by using alloc_clear() instead of alloc(), which will
clear the memory by NUL and therefore cause the loop to terminate
correctly.
Reported by @henices, thanks!
closes: #13596
Signed-off-by: Christian Brabandt <cb@256bit.org>
author | Christian Brabandt <cb@256bit.org> |
---|---|
date | Sun, 10 Dec 2023 15:16:05 +0100 |
parents | d1fe80fb35e6 |
children | e1df51f68736 |
line wrap: on
line source
" Vim compiler file " Compiler: Perl syntax checks (perl -Wc) " Maintainer: vim-perl <vim-perl@googlegroups.com> " Author: Christian J. Robinson <heptite@gmail.com> " Homepage: https://github.com/vim-perl/vim-perl " Bugs/requests: https://github.com/vim-perl/vim-perl/issues " License: Vim License (see :help license) " Last Change: 2021 Nov 2 if exists("current_compiler") finish endif let current_compiler = "perl" if exists(":CompilerSet") != 2 " older Vim always used :setlocal command -nargs=* CompilerSet setlocal <args> endif let s:savecpo = &cpo set cpo&vim if get(g:, 'perl_compiler_force_warnings', 1) let s:warnopt = 'W' else let s:warnopt = 'w' endif if getline(1) =~# '-[^ ]*T' let s:taintopt = 'T' else let s:taintopt = '' endif exe 'CompilerSet makeprg=perl\ -' . s:warnopt . s:taintopt . 'c\ %:S' CompilerSet errorformat= \%-G%.%#had\ compilation\ errors., \%-G%.%#syntax\ OK, \%m\ at\ %f\ line\ %l., \%+A%.%#\ at\ %f\ line\ %l\\,%.%#, \%+C%.%# " Explanation: " %-G%.%#had\ compilation\ errors., - Ignore the obvious. " %-G%.%#syntax\ OK, - Don't include the 'a-okay' message. " %m\ at\ %f\ line\ %l., - Most errors... " %+A%.%#\ at\ %f\ line\ %l\\,%.%#, - As above, including ', near ...' " %+C%.%# - ... Which can be multi-line. let &cpo = s:savecpo unlet s:savecpo