Mercurial > vim
view ci/unlisted.make @ 33865:8cdb69ea3711 v9.0.2143
patch 9.0.2143: [security]: buffer-overflow in ex_substitute
Commit: https://github.com/vim/vim/commit/abfa13ebe92d81aaf66669c428d767847b577453
Author: Christian Brabandt <cb@256bit.org>
Date: Thu Nov 30 11:32:18 2023 +0100
patch 9.0.2143: [security]: buffer-overflow in ex_substitute
Problem: [security]: buffer-overflow in ex_substitute
Solution: clear memory after allocating
When allocating the new_start pointer in ex_substitute() the memory
pointer points to some garbage that the following for loop in
ex_cmds.c:4743 confuses and causes it to accessing the new_start pointer
beyond it's size, leading to a buffer-overlow.
So fix this by using alloc_clear() instead of alloc(), which will
clear the memory by NUL and therefore cause the loop to terminate
correctly.
Reported by @henices, thanks!
closes: #13596
Signed-off-by: Christian Brabandt <cb@256bit.org>
author | Christian Brabandt <cb@256bit.org> |
---|---|
date | Sun, 10 Dec 2023 15:16:05 +0100 |
parents | e6c291944e18 |
children |
line wrap: on
line source
# vim: ft=make SHELL = /bin/bash # List all files that are tracked in git but not listed in Filelist. # Exit code is 2 ("Make encountered an error") if any such files exist. # Filelist is a Makefile that defines many variables, so we use Make itself to # query which variables it defines, then expand them all by wrapping each name # in $(...), importing Filelist and using $(eval). include Filelist $(eval all_patterns := $(shell \ make -f Filelist --question --print-data-base --no-builtin-rules \ --no-builtin-variables 2>/dev/null \ | sed -nre \ '/^# makefile .from \x27Filelist\x27,/ { \ n; \ s/ = .*//; \ T; \ s/.*/$$(\0)/; \ p; \ }')) # In Makefile's `prepeare` target, all the IN_README_DIR files are moved from # READMEdir to the root, so add those files in their Git-tracked location: all_patterns := $(all_patterns) \ $(foreach readme, $(IN_README_DIR), READMEdir/$(readme)) # The result 'all_patterns' is a list of patterns (globs), which we expand with # wildcard to get actual filenames. Note this means Filelist can list a file # that does not exist, and it will be omitted at this step. listed_files := $(wildcard $(all_patterns)) # Default target to actually run the comparison: .PHONY: check check: @# There are too many files to list on the command line, so we write @# that to a temporary file, one per line. $(file > Filelist-listed-files) $(foreach filename, $(listed_files),\ $(file >> Filelist-listed-files,$(filename))) @# Compare the sorted lists. Delete that temporary file on both @# success and failure, but exit with diff's exit code. diff -u0 --label files-in-git <(git ls-files | sort) \ --label Filelist <(sort --unique Filelist-listed-files); \ RV=$$?; \ rm Filelist-listed-files; \ (($$RV != 0)) && echo "Add files to the right variable in Filelist."; \ exit $$RV