Mercurial > vim
view src/os_vms_mms.c @ 34389:8b0e390b61fe v9.1.0121
patch 9.1.0121: Infinite loop or signed overflow with 'smoothscroll'
Commit: https://github.com/vim/vim/commit/02fcae02a926e4e8379d77fb716da4202029882d
Author: Sean Dewar <6256228+seandewar@users.noreply.github.com>
Date: Wed Feb 21 19:40:44 2024 +0100
patch 9.1.0121: Infinite loop or signed overflow with 'smoothscroll'
Problem: infinite loop in win_update with 'smoothscroll' set when
window width is equal to textoff, or signed integer overflow
if smaller.
Solution: don't revalidate wp->w_skipcol in that case, as no buffer text
is being shown. (Sean Dewar)
Don't instead reset w_skipcol; that would lose the scroll position
within the line, which may be undesirable if the window is made wider
later.
Also include changes from the splitmove PR #14042 that I (in my infinite
Git wisdom) forgot to commit. This includes a change to
Test_window_split_no_room to ensure it doesn't fail for some screen
sizes.
Move Test_smoothscroll_in_zero_width_window to test_scroll_opt.vim, as
that file feels more appropriate.
closes: #14068
Signed-off-by: Sean Dewar <6256228+seandewar@users.noreply.github.com>
Signed-off-by: Christian Brabandt <cb@256bit.org>
author | Christian Brabandt <cb@256bit.org> |
---|---|
date | Wed, 21 Feb 2024 19:45:06 +0100 |
parents | 2463194c8cdd |
children |
line wrap: on
line source
#include <stdio.h> #include <stdlib.h> #include <string.h> #include <unixio.h> #include "vim.h" int main(int argc, char *argv[]) { FILE *fpi, *fpo; char cmd[132], buf[BUFSIZ], *argp, *error_file, target[132], *mms; int err = 0, err_line = 0; mms = "mms"; argc--; argv++; while (argc-- > 0) { argp = *argv++; if (*argp == '-') { switch (*++argp) { case 'm': mms = ++argp; break; case 'e': if (!*(error_file = ++argp)) { error_file = *argv++; argc--; } break; default: break; } } else { if (*target) strcat(target, " "); strcat(target, argp); } } vim_snprintf(cmd, sizeof(cmd), "%s/output=tmp:errors.vim_tmp %s", mms, target); system(cmd); fpi = fopen("tmp:errors.vim_tmp", "r"); fpo = fopen(error_file, "w"); while (fgets(buf, BUFSIZ, fpi)) { if (!memcmp(buf, "%CC-", 4)) { err_line++; buf[strlen(buf)-1] = '\0'; err++; } else { if (err_line) { if (strstr(buf, _("At line"))) { err_line = 0; fprintf(fpo, "@"); } else buf[strlen(buf)-1] = '\0'; } } fprintf(fpo, "%s", buf); } fclose(fpi); fclose(fpo); while (!delete("tmp:errors.vim_tmp")) /*nop*/; exit(err ? 44 : 1); return(0); }