Mercurial > vim
view src/gui_xmebw.h @ 34389:8b0e390b61fe v9.1.0121
patch 9.1.0121: Infinite loop or signed overflow with 'smoothscroll'
Commit: https://github.com/vim/vim/commit/02fcae02a926e4e8379d77fb716da4202029882d
Author: Sean Dewar <6256228+seandewar@users.noreply.github.com>
Date: Wed Feb 21 19:40:44 2024 +0100
patch 9.1.0121: Infinite loop or signed overflow with 'smoothscroll'
Problem: infinite loop in win_update with 'smoothscroll' set when
window width is equal to textoff, or signed integer overflow
if smaller.
Solution: don't revalidate wp->w_skipcol in that case, as no buffer text
is being shown. (Sean Dewar)
Don't instead reset w_skipcol; that would lose the scroll position
within the line, which may be undesirable if the window is made wider
later.
Also include changes from the splitmove PR #14042 that I (in my infinite
Git wisdom) forgot to commit. This includes a change to
Test_window_split_no_room to ensure it doesn't fail for some screen
sizes.
Move Test_smoothscroll_in_zero_width_window to test_scroll_opt.vim, as
that file feels more appropriate.
closes: #14068
Signed-off-by: Sean Dewar <6256228+seandewar@users.noreply.github.com>
Signed-off-by: Christian Brabandt <cb@256bit.org>
author | Christian Brabandt <cb@256bit.org> |
---|---|
date | Wed, 21 Feb 2024 19:45:06 +0100 |
parents | 4aead6a9b7a9 |
children |
line wrap: on
line source
/* vi:set ts=8 sts=4 sw=4 noet: * * VIM - Vi IMproved by Bram Moolenaar * * Do ":help uganda" in Vim to read copying and usage conditions. * Do ":help credits" in Vim to see a list of people who contributed. * See README.txt for an overview of the Vim source code. */ /* * * (C) 2002,2005 by Marcin Dalecki <martin@dalecki.de> * * MARCIN DALECKI ASSUMES NO RESPONSIBILITY FOR THE USE OR INABILITY TO USE ANY * OF THIS SOFTWARE . THIS SOFTWARE IS PROVIDED "AS IS" WITHOUT WARRANTY OF ANY * KIND, AND MARCIN DALECKI EXPRESSLY DISCLAIMS ALL IMPLIED WARRANTIES, * INCLUDING BUT NOT LIMITED TO THE IMPLIED WARRANTIES OF MERCHANTABILITY AND * FITNESS FOR A PARTICULAR PURPOSE. */ #ifndef EnhancedB_H #define EnhancedB_H /* * New resources for the Extended Pushbutton widget */ #ifndef XmNshift # define XmNshift "shift" #endif #ifndef XmCShift # define XmCShift "Shift" #endif #ifndef XmNlabelLocation # define XmNlabelLocation "labelLocation" #endif #ifndef XmCLocation # define XmCLocation "Location" #endif #ifndef XmNpixmapData # define XmNpixmapData "pixmapData" #endif #ifndef XmNpixmapFile # define XmNpixmapFile "pixmapFile" #endif /* * Constants for labelLocation. */ #ifdef HAVE_XM_JOINSIDET_H # include <Xm/JoinSideT.h> #else # define XmLEFT 1 # define XmRIGHT 2 # define XmTOP 3 # define XmBOTTOM 4 #endif #define XmIsEnhancedButton(w) XtIsSubclass(w, xmEnhancedButtonWidgetClass) /* * Convenience creation function. */ extern Widget XgCreateEPushButtonWidget(Widget, char *, ArgList, Cardinal); extern WidgetClass xmEnhancedButtonWidgetClass; typedef struct _XmEnhancedButtonClassRec *XmEnhancedButtonWidgetClass; typedef struct _XmEnhancedButtonRec *XmEnhancedButtonWidget; #endif