Mercurial > vim
view src/testdir/test_vim9_fails.vim @ 34686:83875247fbc0 v9.1.0224
patch 9.1.0224: cursor may move too many lines over "right" & "below" virt text
Commit: https://github.com/vim/vim/commit/515f734e687f28f7199b2a8042197624d9f3ec15
Author: Dylan Thacker-Smith <dylan.ah.smith@gmail.com>
Date: Thu Mar 28 12:01:14 2024 +0100
patch 9.1.0224: cursor may move too many lines over "right" & "below" virt text
Problem: If a line has "right" & "below" virtual text properties,
where the "below" property may be stored first due to lack of
ordering between them, then the line height is calculated to
be 1 more and causes the cursor to far over the line.
Solution: Remove some unnecessary setting of a
`next_right_goes_below = TRUE` flag for "below" and "above"
text properties. (Dylan Thacker-Smith)
I modified a regression test I recently added to cover this case,
leveraging the fact that "after", "right" & "below" text properties are
being stored in the reverse of the order they are added in. The
previous version of this regression test was crafted to workaround this
issue so it can be addressed by this separate patch.
closes: #14317
Signed-off-by: Dylan Thacker-Smith <dylan.ah.smith@gmail.com>
Signed-off-by: Christian Brabandt <cb@256bit.org>
author | Christian Brabandt <cb@256bit.org> |
---|---|
date | Thu, 28 Mar 2024 12:15:03 +0100 |
parents | 54e36d01847b |
children |
line wrap: on
line source
" Test for Vim9 script with failures, causing memory leaks to be reported. " The leaks happen after a fork() and can be ignored. source check.vim def Test_assignment() if !has('channel') CheckFeature channel else var chan1: channel var job1: job var job2: job = job_start('willfail') endif enddef " Unclear why this test causes valgrind to report problems. def Test_job_info_return_type() if !has('job') CheckFeature job else var job: job = job_start(&shell) var jobs = job_info() assert_equal('list<job>', typename(jobs)) assert_equal('dict<any>', typename(job_info(jobs[0]))) job_stop(job) endif enddef " Using "idx" from a legacy global function does not work. " This caused a crash when called from legacy context. " This creates a dict that contains a partial that refers to the dict, causing " valgrind to report "possibly leaked memory". func Test_partial_call_fails() let lines =<< trim END vim9script var l = ['a', 'b', 'c'] def Iter(container: any): any var idx = -1 var obj = {state: container} def g:NextItem__(self: dict<any>): any ++idx return self.state[idx] enddef obj.__next__ = function('g:NextItem__', [obj]) return obj enddef var it = Iter(l) echo it.__next__() END call writefile(lines, 'XpartialCall', 'D') let caught = 'no' try source XpartialCall catch /E1248:/ let caught = 'yes' endtry call assert_equal('yes', caught) delfunc g:NextItem__ endfunc