Mercurial > vim
view src/testdir/test_retab.vim @ 34686:83875247fbc0 v9.1.0224
patch 9.1.0224: cursor may move too many lines over "right" & "below" virt text
Commit: https://github.com/vim/vim/commit/515f734e687f28f7199b2a8042197624d9f3ec15
Author: Dylan Thacker-Smith <dylan.ah.smith@gmail.com>
Date: Thu Mar 28 12:01:14 2024 +0100
patch 9.1.0224: cursor may move too many lines over "right" & "below" virt text
Problem: If a line has "right" & "below" virtual text properties,
where the "below" property may be stored first due to lack of
ordering between them, then the line height is calculated to
be 1 more and causes the cursor to far over the line.
Solution: Remove some unnecessary setting of a
`next_right_goes_below = TRUE` flag for "below" and "above"
text properties. (Dylan Thacker-Smith)
I modified a regression test I recently added to cover this case,
leveraging the fact that "after", "right" & "below" text properties are
being stored in the reverse of the order they are added in. The
previous version of this regression test was crafted to workaround this
issue so it can be addressed by this separate patch.
closes: #14317
Signed-off-by: Dylan Thacker-Smith <dylan.ah.smith@gmail.com>
Signed-off-by: Christian Brabandt <cb@256bit.org>
| author | Christian Brabandt <cb@256bit.org> |
|---|---|
| date | Thu, 28 Mar 2024 12:15:03 +0100 |
| parents | 6a6c56354cfc |
| children |
line wrap: on
line source
" Test :retab source check.vim func SetUp() new call setline(1, "\ta \t b c ") endfunc func TearDown() bwipe! endfunc func Retab(bang, n) let l:old_tabstop = &tabstop let l:old_line = getline(1) exe "retab" . a:bang . a:n let l:line = getline(1) call setline(1, l:old_line) if a:n > 0 " :retab changes 'tabstop' to n with argument n > 0. call assert_equal(a:n, &tabstop) exe 'set tabstop=' . l:old_tabstop else " :retab does not change 'tabstop' with empty or n <= 0. call assert_equal(l:old_tabstop, &tabstop) endif return l:line endfunc func Test_retab() set tabstop=8 noexpandtab call assert_equal("\ta\t b c ", Retab('', '')) call assert_equal("\ta\t b c ", Retab('', 0)) call assert_equal("\ta\t b c ", Retab('', 8)) call assert_equal("\ta\t b\t c\t ", Retab('!', '')) call assert_equal("\ta\t b\t c\t ", Retab('!', 0)) call assert_equal("\ta\t b\t c\t ", Retab('!', 8)) call assert_equal("\t\ta\t\t\tb c ", Retab('', 4)) call assert_equal("\t\ta\t\t\tb\t\t c\t ", Retab('!', 4)) call assert_equal(" a\t\tb c ", Retab('', 10)) call assert_equal(" a\t\tb c ", Retab('!', 10)) set tabstop=8 expandtab call assert_equal(" a b c ", Retab('', '')) call assert_equal(" a b c ", Retab('', 0)) call assert_equal(" a b c ", Retab('', 8)) call assert_equal(" a b c ", Retab('!', '')) call assert_equal(" a b c ", Retab('!', 0)) call assert_equal(" a b c ", Retab('!', 8)) call assert_equal(" a b c ", Retab(' ', 4)) call assert_equal(" a b c ", Retab('!', 4)) call assert_equal(" a b c ", Retab(' ', 10)) call assert_equal(" a b c ", Retab('!', 10)) set tabstop=4 noexpandtab call assert_equal("\ta\t\tb c ", Retab('', '')) call assert_equal("\ta\t\tb\t\t c\t ", Retab('!', '')) call assert_equal("\t a\t\t\tb c ", Retab('', 3)) call assert_equal("\t a\t\t\tb\t\t\tc\t ", Retab('!', 3)) call assert_equal(" a\t b c ", Retab('', 5)) call assert_equal(" a\t b\t\t c\t ", Retab('!', 5)) set tabstop=4 expandtab call assert_equal(" a b c ", Retab('', '')) call assert_equal(" a b c ", Retab('!', '')) call assert_equal(" a b c ", Retab('', 3)) call assert_equal(" a b c ", Retab('!', 3)) call assert_equal(" a b c ", Retab('', 5)) call assert_equal(" a b c ", Retab('!', 5)) set tabstop& expandtab& endfunc func Test_retab_error() call assert_fails('retab -1', 'E487:') call assert_fails('retab! -1', 'E487:') call assert_fails('ret -1000', 'E487:') call assert_fails('ret 10000', 'E475:') call assert_fails('ret 80000000000000000000', 'E475:') endfunc func RetabLoop() while 1 set ts=4000 retab 4 endwhile endfunc func Test_retab_endless() " inside try/catch we can catch the error message call setline(1, "\t0\t") let caught = 'no' try call RetabLoop() catch /E1240:/ let caught = v:exception endtry call assert_match('E1240:', caught) set tabstop& endfunc func Test_nocatch_retab_endless() " when not inside try/catch an interrupt is generated to get out of loops call setline(1, "\t0\t") call assert_fails('call RetabLoop()', ['E1240:', 'Interrupted']) set tabstop& endfunc " vim: shiftwidth=2 sts=2 expandtab