Mercurial > vim
view src/testdir/test_move.vim @ 34686:83875247fbc0 v9.1.0224
patch 9.1.0224: cursor may move too many lines over "right" & "below" virt text
Commit: https://github.com/vim/vim/commit/515f734e687f28f7199b2a8042197624d9f3ec15
Author: Dylan Thacker-Smith <dylan.ah.smith@gmail.com>
Date: Thu Mar 28 12:01:14 2024 +0100
patch 9.1.0224: cursor may move too many lines over "right" & "below" virt text
Problem: If a line has "right" & "below" virtual text properties,
where the "below" property may be stored first due to lack of
ordering between them, then the line height is calculated to
be 1 more and causes the cursor to far over the line.
Solution: Remove some unnecessary setting of a
`next_right_goes_below = TRUE` flag for "below" and "above"
text properties. (Dylan Thacker-Smith)
I modified a regression test I recently added to cover this case,
leveraging the fact that "after", "right" & "below" text properties are
being stored in the reverse of the order they are added in. The
previous version of this regression test was crafted to workaround this
issue so it can be addressed by this separate patch.
closes: #14317
Signed-off-by: Dylan Thacker-Smith <dylan.ah.smith@gmail.com>
Signed-off-by: Christian Brabandt <cb@256bit.org>
author | Christian Brabandt <cb@256bit.org> |
---|---|
date | Thu, 28 Mar 2024 12:15:03 +0100 |
parents | 984969b81d63 |
children |
line wrap: on
line source
" Test the ":move" command. source check.vim source screendump.vim func Test_move() enew! call append(0, ['line 1', 'line 2', 'line 3']) g /^$/ delete _ set nomodified move . call assert_equal(['line 1', 'line 2', 'line 3'], getline(1, 3)) call assert_false(&modified) 1,2move 0 call assert_equal(['line 1', 'line 2', 'line 3'], getline(1, 3)) call assert_false(&modified) 1,3move 3 call assert_equal(['line 1', 'line 2', 'line 3'], getline(1, 3)) call assert_false(&modified) 1move 2 call assert_equal(['line 2', 'line 1', 'line 3'], getline(1, 3)) call assert_true(&modified) set nomodified 3move 0 call assert_equal(['line 3', 'line 2', 'line 1'], getline(1, 3)) call assert_true(&modified) set nomodified 2,3move 0 call assert_equal(['line 2', 'line 1', 'line 3'], getline(1, 3)) call assert_true(&modified) set nomodified call assert_fails('1,2move 1', 'E134:') call assert_fails('2,3move 2', 'E134:') call assert_fails("move -100", 'E16:') call assert_fails("move +100", 'E16:') call assert_fails('move', 'E16:') call assert_fails("move 'r", 'E20:') %bwipeout! endfunc func Test_move_undo() CheckRunVimInTerminal let lines =<< trim END call setline(1, ['First', 'Second', 'Third', 'Fourth']) END call writefile(lines, 'Xtest_move_undo.vim', 'D') let buf = RunVimInTerminal('-S Xtest_move_undo.vim', #{rows: 10, cols: 60, statusoff: 2}) call term_sendkeys(buf, "gg:move +1\<CR>") call VerifyScreenDump(buf, 'Test_move_undo_1', {}) " here the display would show the last few lines scrolled down call term_sendkeys(buf, "u") call term_sendkeys(buf, ":\<Esc>") call VerifyScreenDump(buf, 'Test_move_undo_2', {}) call StopVimInTerminal(buf) endfunc " vim: shiftwidth=2 sts=2 expandtab