Mercurial > vim
view src/testdir/test_hide.vim @ 34686:83875247fbc0 v9.1.0224
patch 9.1.0224: cursor may move too many lines over "right" & "below" virt text
Commit: https://github.com/vim/vim/commit/515f734e687f28f7199b2a8042197624d9f3ec15
Author: Dylan Thacker-Smith <dylan.ah.smith@gmail.com>
Date: Thu Mar 28 12:01:14 2024 +0100
patch 9.1.0224: cursor may move too many lines over "right" & "below" virt text
Problem: If a line has "right" & "below" virtual text properties,
where the "below" property may be stored first due to lack of
ordering between them, then the line height is calculated to
be 1 more and causes the cursor to far over the line.
Solution: Remove some unnecessary setting of a
`next_right_goes_below = TRUE` flag for "below" and "above"
text properties. (Dylan Thacker-Smith)
I modified a regression test I recently added to cover this case,
leveraging the fact that "after", "right" & "below" text properties are
being stored in the reverse of the order they are added in. The
previous version of this regression test was crafted to workaround this
issue so it can be addressed by this separate patch.
closes: #14317
Signed-off-by: Dylan Thacker-Smith <dylan.ah.smith@gmail.com>
Signed-off-by: Christian Brabandt <cb@256bit.org>
author | Christian Brabandt <cb@256bit.org> |
---|---|
date | Thu, 28 Mar 2024 12:15:03 +0100 |
parents | e373843e2980 |
children |
line wrap: on
line source
" Tests for :hide command/modifier and 'hidden' option func SetUp() let s:save_hidden = &hidden let s:save_bufhidden = &bufhidden let s:save_autowrite = &autowrite set nohidden set bufhidden= set noautowrite endfunc function TearDown() let &hidden = s:save_hidden let &bufhidden = s:save_bufhidden let &autowrite = s:save_autowrite endfunc function Test_hide() let orig_bname = bufname('') let orig_winnr = winnr('$') new Xf1 set modified call assert_fails('edit Xf2') bwipeout! Xf1 new Xf1 set modified edit! Xf2 call assert_equal(['Xf2', 2], [bufname(''), winnr('$')]) call assert_equal([1, 0], [buflisted('Xf1'), bufloaded('Xf1')]) bwipeout! Xf1 bwipeout! Xf2 new Xf1 set modified " :hide as a command hide call assert_equal([orig_bname, orig_winnr], [bufname(''), winnr('$')]) call assert_equal([1, 1], ['Xf1'->buflisted(), 'Xf1'->bufloaded()]) bwipeout! Xf1 new Xf1 set modified " :hide as a command with trailing comment hide " comment call assert_equal([orig_bname, orig_winnr], [bufname(''), winnr('$')]) call assert_equal([1, 1], [buflisted('Xf1'), bufloaded('Xf1')]) bwipeout! Xf1 new Xf1 set modified " :hide as a command with bar hide | new Xf2 " comment call assert_equal(['Xf2', 2], [bufname(''), winnr('$')]) call assert_equal([1, 1], [buflisted('Xf1'), bufloaded('Xf1')]) bwipeout! Xf1 bwipeout! Xf2 new Xf1 set modified " :hide as a modifier with trailing comment hide edit Xf2 " comment call assert_equal(['Xf2', 2], [bufname(''), winnr('$')]) call assert_equal([1, 1], [buflisted('Xf1'), bufloaded('Xf1')]) bwipeout! Xf1 bwipeout! Xf2 new Xf1 set modified " To check that the bar is not recognized to separate commands hide echo "one|two" call assert_equal(['Xf1', 2], [bufname(''), winnr('$')]) call assert_equal([1, 1], [buflisted('Xf1'), bufloaded('Xf1')]) bwipeout! Xf1 " set hidden new Xf1 set hidden set modified edit Xf2 " comment call assert_equal(['Xf2', 2], [bufname(''), winnr('$')]) call assert_equal([1, 1], [buflisted('Xf1'), bufloaded('Xf1')]) bwipeout! Xf1 bwipeout! Xf2 " set hidden bufhidden=wipe new Xf1 set bufhidden=wipe set modified hide edit! Xf2 " comment call assert_equal(['Xf2', 2], [bufname(''), winnr('$')]) call assert_equal([0, 0], [buflisted('Xf1'), bufloaded('Xf1')]) bwipeout! Xf2 endfunc " vim: shiftwidth=2 sts=2 expandtab