Mercurial > vim
view src/testdir/test_flatten.vim @ 34686:83875247fbc0 v9.1.0224
patch 9.1.0224: cursor may move too many lines over "right" & "below" virt text
Commit: https://github.com/vim/vim/commit/515f734e687f28f7199b2a8042197624d9f3ec15
Author: Dylan Thacker-Smith <dylan.ah.smith@gmail.com>
Date: Thu Mar 28 12:01:14 2024 +0100
patch 9.1.0224: cursor may move too many lines over "right" & "below" virt text
Problem: If a line has "right" & "below" virtual text properties,
where the "below" property may be stored first due to lack of
ordering between them, then the line height is calculated to
be 1 more and causes the cursor to far over the line.
Solution: Remove some unnecessary setting of a
`next_right_goes_below = TRUE` flag for "below" and "above"
text properties. (Dylan Thacker-Smith)
I modified a regression test I recently added to cover this case,
leveraging the fact that "after", "right" & "below" text properties are
being stored in the reverse of the order they are added in. The
previous version of this regression test was crafted to workaround this
issue so it can be addressed by this separate patch.
closes: #14317
Signed-off-by: Dylan Thacker-Smith <dylan.ah.smith@gmail.com>
Signed-off-by: Christian Brabandt <cb@256bit.org>
author | Christian Brabandt <cb@256bit.org> |
---|---|
date | Thu, 28 Mar 2024 12:15:03 +0100 |
parents | 18319c0c36f9 |
children |
line wrap: on
line source
" Test for flatting list. func Test_flatten() call assert_fails('call flatten(1)', 'E686:') call assert_fails('call flatten({})', 'E686:') call assert_fails('call flatten("string")', 'E686:') call assert_fails('call flatten([], [])', 'E745:') call assert_fails('call flatten([], -1)', 'E900: maxdepth') call assert_equal([], flatten([])) call assert_equal([], flatten([[]])) call assert_equal([], flatten([[[]]])) call assert_equal([1, 2, 3], flatten([1, 2, 3])) call assert_equal([1, 2, 3], flatten([[1], 2, 3])) call assert_equal([1, 2, 3], flatten([1, [2], 3])) call assert_equal([1, 2, 3], flatten([1, 2, [3]])) call assert_equal([1, 2, 3], flatten([[1], [2], 3])) call assert_equal([1, 2, 3], flatten([1, [2], [3]])) call assert_equal([1, 2, 3], flatten([[1], 2, [3]])) call assert_equal([1, 2, 3], flatten([[1], [2], [3]])) call assert_equal([1, 2, 3], flatten([[1, 2, 3], []])) call assert_equal([1, 2, 3], flatten([[], [1, 2, 3]])) call assert_equal([1, 2, 3], flatten([[1, 2], [], [3]])) call assert_equal([1, 2, 3], flatten([[], [1, 2, 3], []])) call assert_equal([1, 2, 3, 4], flatten(range(1, 4))) " example in the help call assert_equal([1, 2, 3, 4, 5], flatten([1, [2, [3, 4]], 5])) call assert_equal([1, 2, [3, 4], 5], flatten([1, [2, [3, 4]], 5], 1)) call assert_equal([0, [1], 2, [3], 4], flatten([[0, [1]], 2, [[3], 4]], 1)) call assert_equal([1, 2, 3], flatten([[[[1]]], [2], [3]], 3)) call assert_equal([[1], [2], [3]], flatten([[[1], [2], [3]]], 1)) call assert_equal([[1]], flatten([[1]], 0)) " Make it flatten if the given maxdepth is larger than actual depth. call assert_equal([1, 2, 3], flatten([[1, 2, 3]], 1)) call assert_equal([1, 2, 3], flatten([[1, 2, 3]], 2)) let l:list = [[1], [2], [3]] call assert_equal([1, 2, 3], flatten(l:list)) call assert_equal([1, 2, 3], l:list) " Tests for checking reference counter works well. let l:x = {'foo': 'bar'} call assert_equal([1, 2, l:x, 3], flatten([1, [2, l:x], 3])) call test_garbagecollect_now() call assert_equal('bar', l:x.foo) let l:list = [[1], [2], [3]] call assert_equal([1, 2, 3], flatten(l:list)) call test_garbagecollect_now() call assert_equal([1, 2, 3], l:list) " Tests for checking circular reference list can be flattened. let l:x = [1] let l:y = [x] let l:z = flatten(l:y) call assert_equal([1], l:z) call test_garbagecollect_now() let l:x[0] = 2 call assert_equal([2], l:x) call assert_equal([1], l:z) " NOTE: primitive types are copied. call assert_equal([1], l:y) let l:x = [2] let l:y = [1, [l:x], 3] " [1, [[2]], 3] let l:z = flatten(l:y, 1) call assert_equal([1, [2], 3], l:z) let l:x[0] = 9 call assert_equal([1, [9], 3], l:z) " Reference to l:x is kept. call assert_equal([1, [9], 3], l:y) let l:x = [1] let l:y = [2] call add(x, y) " l:x = [1, [2]] call add(y, x) " l:y = [2, [1, [...]]] call assert_equal([1, 2, 1, 2], flatten(l:x, 2)) call assert_equal([2, l:x], l:y) let l4 = [ 1, [ 11, [ 101, [ 1001 ] ] ] ] call assert_equal(l4, flatten(deepcopy(l4), 0)) call assert_equal([1, 11, [101, [1001]]], flatten(deepcopy(l4), 1)) call assert_equal([1, 11, 101, [1001]], flatten(deepcopy(l4), 2)) call assert_equal([1, 11, 101, 1001], flatten(deepcopy(l4), 3)) call assert_equal([1, 11, 101, 1001], flatten(deepcopy(l4), 4)) call assert_equal([1, 11, 101, 1001], flatten(deepcopy(l4))) endfunc func Test_flattennew() let l = [1, [2, [3, 4]], 5] call assert_equal([1, 2, 3, 4, 5], flattennew(l)) call assert_equal([1, [2, [3, 4]], 5], l) call assert_equal([1, 2, [3, 4], 5], flattennew(l, 1)) call assert_equal([1, [2, [3, 4]], 5], l) let l4 = [ 1, [ 11, [ 101, [ 1001 ] ] ] ] call assert_equal(l4, flatten(deepcopy(l4), 0)) call assert_equal([1, 11, [101, [1001]]], flattennew(l4, 1)) call assert_equal([1, 11, 101, [1001]], flattennew(l4, 2)) call assert_equal([1, 11, 101, 1001], flattennew(l4, 3)) call assert_equal([1, 11, 101, 1001], flattennew(l4, 4)) call assert_equal([1, 11, 101, 1001], flattennew(l4)) endfunc " vim: shiftwidth=2 sts=2 expandtab