Mercurial > vim
view src/testdir/popupbounce.vim @ 34686:83875247fbc0 v9.1.0224
patch 9.1.0224: cursor may move too many lines over "right" & "below" virt text
Commit: https://github.com/vim/vim/commit/515f734e687f28f7199b2a8042197624d9f3ec15
Author: Dylan Thacker-Smith <dylan.ah.smith@gmail.com>
Date: Thu Mar 28 12:01:14 2024 +0100
patch 9.1.0224: cursor may move too many lines over "right" & "below" virt text
Problem: If a line has "right" & "below" virtual text properties,
where the "below" property may be stored first due to lack of
ordering between them, then the line height is calculated to
be 1 more and causes the cursor to far over the line.
Solution: Remove some unnecessary setting of a
`next_right_goes_below = TRUE` flag for "below" and "above"
text properties. (Dylan Thacker-Smith)
I modified a regression test I recently added to cover this case,
leveraging the fact that "after", "right" & "below" text properties are
being stored in the reverse of the order they are added in. The
previous version of this regression test was crafted to workaround this
issue so it can be addressed by this separate patch.
closes: #14317
Signed-off-by: Dylan Thacker-Smith <dylan.ah.smith@gmail.com>
Signed-off-by: Christian Brabandt <cb@256bit.org>
author | Christian Brabandt <cb@256bit.org> |
---|---|
date | Thu, 28 Mar 2024 12:15:03 +0100 |
parents | 9606c0adc148 |
children |
line wrap: on
line source
" Use this script to measure the redrawing performance when a popup is being " displayed. Usage with gcc: " cd src " # Edit Makefile to uncomment PROFILE_CFLAGS and PROFILE_LIBS " make reconfig " ./vim --clean -S testdir/popupbounce.vim main.c " gprof vim gmon.out | vim - " using line continuation set nocp " don't switch screens when quitting, so we can read the frames/sec set t_te= let winid = popup_create(['line1', 'line2', 'line3', 'line4'], { \ 'line' : 1, \ 'col' : 1, \ 'zindex' : 101, \ }) redraw let start = reltime() let framecount = 0 let line = 1.0 let col = 1 let downwards = 1 let col_inc = 1 let initial_speed = 0.2 let speed = initial_speed let accel = 1.1 let time = 0.1 let countdown = 0 while 1 if downwards let speed += time * accel let line += speed else let speed -= time * accel let line -= speed endif if line + 3 >= &lines let downwards = 0 let speed = speed * 0.8 let line = &lines - 3 endif if !downwards && speed < 1.0 let downwards = 1 let speed = initial_speed if line + 4 > &lines && countdown == 0 let countdown = 50 endif endif let col += col_inc if col + 4 >= &columns let col_inc = -1 elseif col <= 1 let col_inc = 1 endif call popup_move(winid, {'line': float2nr(line), 'col': col}) redraw let framecount += 1 if countdown > 0 let countdown -= 1 if countdown == 0 break endif endif endwhile let elapsed = reltimefloat(reltime(start)) echomsg framecount .. ' frames in ' .. string(elapsed) .. ' seconds, ' .. string(framecount / elapsed) .. ' frames/sec' qa