Mercurial > vim
view src/nbdebug.h @ 34686:83875247fbc0 v9.1.0224
patch 9.1.0224: cursor may move too many lines over "right" & "below" virt text
Commit: https://github.com/vim/vim/commit/515f734e687f28f7199b2a8042197624d9f3ec15
Author: Dylan Thacker-Smith <dylan.ah.smith@gmail.com>
Date: Thu Mar 28 12:01:14 2024 +0100
patch 9.1.0224: cursor may move too many lines over "right" & "below" virt text
Problem: If a line has "right" & "below" virtual text properties,
where the "below" property may be stored first due to lack of
ordering between them, then the line height is calculated to
be 1 more and causes the cursor to far over the line.
Solution: Remove some unnecessary setting of a
`next_right_goes_below = TRUE` flag for "below" and "above"
text properties. (Dylan Thacker-Smith)
I modified a regression test I recently added to cover this case,
leveraging the fact that "after", "right" & "below" text properties are
being stored in the reverse of the order they are added in. The
previous version of this regression test was crafted to workaround this
issue so it can be addressed by this separate patch.
closes: #14317
Signed-off-by: Dylan Thacker-Smith <dylan.ah.smith@gmail.com>
Signed-off-by: Christian Brabandt <cb@256bit.org>
author | Christian Brabandt <cb@256bit.org> |
---|---|
date | Thu, 28 Mar 2024 12:15:03 +0100 |
parents | 50555279168b |
children |
line wrap: on
line source
/* vi:set ts=8 sw=8 noet: * * VIM - Vi IMproved by Bram Moolenaar * Visual Workshop integration by Gordon Prieur * * Do ":help uganda" in Vim to read copying and usage conditions. * Do ":help credits" in Vim to see a list of people who contributed. */ #ifndef NBDEBUG_H #define NBDEBUG_H #ifdef NBDEBUG # ifndef ASSERT # define ASSERT(c) \ if (!(c)) \ { \ fprintf(stderr, "Assertion failed: line %d, file %s\n", \ __LINE__, __FILE__); \ fflush(stderr); \ abort(); \ } # endif # define nbdebug(a) nbdbg a # define NB_TRACE 0x00000001 # define NB_TRACE_VERBOSE 0x00000002 # define NB_TRACE_COLONCMD 0x00000004 # define NB_PRINT 0x00000008 # define NB_DEBUG_ALL 0xffffffff # define NBDLEVEL(flags) (nb_debug != NULL && (nb_dlevel & (flags))) # define NBDEBUG_TRACE 1 typedef enum { WT_ENV = 1, // look for env var if set WT_WAIT, // look for ~/.gvimwait if set WT_STOP // look for ~/.gvimstop if set } WtWait; void nbdbg(char *, ...) ATTRIBUTE_FORMAT_PRINTF(1, 2); void nbdebug_wait(u_int wait_flags, char *wait_var, u_int wait_secs); void nbdebug_log_init(char *log_var, char *level_var); extern FILE *nb_debug; extern u_int nb_dlevel; // nb_debug verbosity level #else // not NBDEBUG # ifndef ASSERT # define ASSERT(c) # endif /* * The following 3 stubs are needed because a macro cannot be used because of * the variable number of arguments. */ void nbdbg( char *fmt, ...) { } #endif // NBDEBUG #endif // NBDEBUG_H