patch 9.1.0224: cursor may move too many lines over "right" & "below" virt text Commit: https://github.com/vim/vim/commit/515f734e687f28f7199b2a8042197624d9f3ec15 Author: Dylan Thacker-Smith <dylan.ah.smith@gmail.com> Date: Thu Mar 28 12:01:14 2024 +0100 patch 9.1.0224: cursor may move too many lines over "right" & "below" virt text Problem: If a line has "right" & "below" virtual text properties, where the "below" property may be stored first due to lack of ordering between them, then the line height is calculated to be 1 more and causes the cursor to far over the line. Solution: Remove some unnecessary setting of a `next_right_goes_below = TRUE` flag for "below" and "above" text properties. (Dylan Thacker-Smith) I modified a regression test I recently added to cover this case, leveraging the fact that "after", "right" & "below" text properties are being stored in the reverse of the order they are added in. The previous version of this regression test was crafted to workaround this issue so it can be addressed by this separate patch. closes: #14317 Signed-off-by: Dylan Thacker-Smith <dylan.ah.smith@gmail.com> Signed-off-by: Christian Brabandt <cb@256bit.org>

INIT
UTF8 1
WANTSTATE gm

!79th Column
PUSH "\e[75G"
PUSH "A"x5
  putglyph 0x41 1 0,74
  putglyph 0x41 1 0,75
  putglyph 0x41 1 0,76
  putglyph 0x41 1 0,77
  putglyph 0x41 1 0,78
  ?cursor = 0,79

!80th Column Phantom
PUSH "A"
  putglyph 0x41 1 0,79
  ?cursor = 0,79

!Line Wraparound
PUSH "B"
  putglyph 0x42 1 1,0
  ?cursor = 1,1

!Line Wraparound during combined write
PUSH "\e[78G"
PUSH "BBBCC"
  putglyph 0x42 1 1,77
  putglyph 0x42 1 1,78
  putglyph 0x42 1 1,79
  putglyph 0x43 1 2,0
  putglyph 0x43 1 2,1
  ?cursor = 2,2

!DEC Auto Wrap Mode
RESET
PUSH "\e[?7l"
PUSH "\e[75G"
PUSH "D"x6
  putglyph 0x44 1 0,74
  putglyph 0x44 1 0,75
  putglyph 0x44 1 0,76
  putglyph 0x44 1 0,77
  putglyph 0x44 1 0,78
  putglyph 0x44 1 0,79
  ?cursor = 0,79
PUSH "D"
  putglyph 0x44 1 0,79
  ?cursor = 0,79
PUSH "\e[?7h"

!80th column causes linefeed on wraparound
PUSH "\e[25;78HABC"
  putglyph 0x41 1 24,77
  putglyph 0x42 1 24,78
  putglyph 0x43 1 24,79
  ?cursor = 24,79
PUSH "D"
  moverect 1..25,0..80 -> 0..24,0..80
  putglyph 0x44 1 24,0

!80th column phantom linefeed phantom cancelled by explicit cursor move
PUSH "\e[25;78HABC"
  putglyph 0x41 1 24,77
  putglyph 0x42 1 24,78
  putglyph 0x43 1 24,79
  ?cursor = 24,79
PUSH "\e[25;1HD"
  putglyph 0x44 1 24,0