Mercurial > vim
view src/proto/testing.pro @ 33864:6e4c686b6b5b v9.0.2142
patch 9.0.2142: [security]: stack-buffer-overflow in option callback functions
Commit: https://github.com/vim/vim/commit/b39b240c386a5a29241415541f1c99e2e6b8ce47
Author: Christian Brabandt <cb@256bit.org>
Date: Wed Nov 29 11:34:05 2023 +0100
patch 9.0.2142: [security]: stack-buffer-overflow in option callback functions
Problem: [security]: stack-buffer-overflow in option callback functions
Solution: pass size of errbuf down the call stack, use snprintf()
instead of sprintf()
We pass the error buffer down to the option callback functions, but in
some parts of the code, we simply use sprintf(buf) to write into the error
buffer, which can overflow.
So let's pass down the length of the error buffer and use sprintf(buf, size)
instead.
Reported by @henices, thanks!
Signed-off-by: Christian Brabandt <cb@256bit.org>
| author | Christian Brabandt <cb@256bit.org> |
|---|---|
| date | Sun, 10 Dec 2023 15:16:04 +0100 |
| parents | b9a4699d6a35 |
| children |
line wrap: on
line source
/* testing.c */ void f_assert_beeps(typval_T *argvars, typval_T *rettv); void f_assert_nobeep(typval_T *argvars, typval_T *rettv); void f_assert_equal(typval_T *argvars, typval_T *rettv); void f_assert_equalfile(typval_T *argvars, typval_T *rettv); void f_assert_notequal(typval_T *argvars, typval_T *rettv); void f_assert_exception(typval_T *argvars, typval_T *rettv); void f_assert_fails(typval_T *argvars, typval_T *rettv); void f_assert_false(typval_T *argvars, typval_T *rettv); void f_assert_inrange(typval_T *argvars, typval_T *rettv); void f_assert_match(typval_T *argvars, typval_T *rettv); void f_assert_notmatch(typval_T *argvars, typval_T *rettv); void f_assert_report(typval_T *argvars, typval_T *rettv); void f_assert_true(typval_T *argvars, typval_T *rettv); void f_test_alloc_fail(typval_T *argvars, typval_T *rettv); void f_test_autochdir(typval_T *argvars, typval_T *rettv); void f_test_feedinput(typval_T *argvars, typval_T *rettv); void f_test_getvalue(typval_T *argvars, typval_T *rettv); void f_test_option_not_set(typval_T *argvars, typval_T *rettv); void f_test_override(typval_T *argvars, typval_T *rettv); void f_test_refcount(typval_T *argvars, typval_T *rettv); void f_test_garbagecollect_now(typval_T *argvars, typval_T *rettv); void f_test_garbagecollect_soon(typval_T *argvars, typval_T *rettv); void f_test_ignore_error(typval_T *argvars, typval_T *rettv); void f_test_null_blob(typval_T *argvars, typval_T *rettv); void f_test_null_channel(typval_T *argvars, typval_T *rettv); void f_test_null_dict(typval_T *argvars, typval_T *rettv); void f_test_null_job(typval_T *argvars, typval_T *rettv); void f_test_null_list(typval_T *argvars, typval_T *rettv); void f_test_null_function(typval_T *argvars, typval_T *rettv); void f_test_null_partial(typval_T *argvars, typval_T *rettv); void f_test_null_string(typval_T *argvars, typval_T *rettv); void f_test_unknown(typval_T *argvars, typval_T *rettv); void f_test_void(typval_T *argvars, typval_T *rettv); void f_test_setmouse(typval_T *argvars, typval_T *rettv); void f_test_mswin_event(typval_T *argvars, typval_T *rettv); void f_test_gui_event(typval_T *argvars, typval_T *rettv); void f_test_settime(typval_T *argvars, typval_T *rettv); /* vim: set ft=c : */